h8300 generic irq

h8300 using generic irq handler patch.

Signed-off-by Yoshinori Sato <[email protected]>

arch/h8300/kernel/irq.c new file +20 -0

@@ -0,0 +1,211 @@
+/*
+ * linux/arch/h8300/kernel/irq.c
+ *
+ * Copyright 2007 Yoshinori Sato <[email protected]>
+ */
+
+#include <linux/module.h>
+#include <linux/types.h>
+#include <linux/kernel.h>
+#include <linux/sched.h>
+#include <linux/kernel_stat.h>
+#include <linux/seq_file.h>
+#include <linux/init.h>
+#include <linux/random.h>
+#include <linux/bootmem.h>
+#include <linux/irq.h>
+
+#include <asm/system.h>
+#include <asm/traps.h>
+#include <asm/io.h>

Quoted 6 lines

arch/h8300/kernel/irq.c new file +6 -0

+/*
+ * h8300 interrupt controler implementation
+ */
+struct irq_chip h8300irq_chip = {
+	.name		= "H8300-INTC",
+	.startup	= h8300_startup_irq,

arch/h8300/kernel/irq.c line 81

Quoted 6 lines

arch/h8300/kernel/irq.c new file +6 -0

+	.shutdown	= h8300_shutdown_irq,
+	.enable		= h8300_enable_irq,
+	.disable	= h8300_disable_irq,
+	.ack		= NULL,
+	.end		= h8300_end_irq,
+};

I think this could have static scope.

Quoted 4 lines · On Thu, 26 Apr 2007 17:34:37 +0900 Yoshinori Sato <[email protected]>…

h8300 using generic irq handler patch.

Signed-off-by Yoshinori Sato <[email protected]>

Minor things:

Quoted 24 lines

arch/h8300/kernel/irq.c new file +20 -0

@@ -0,0 +1,211 @@
+/*
+ * linux/arch/h8300/kernel/irq.c
+ *
+ * Copyright 2007 Yoshinori Sato <[email protected]>
+ */
+
+#include <linux/module.h>
+#include <linux/types.h>
+#include <linux/kernel.h>
+#include <linux/sched.h>
+#include <linux/kernel_stat.h>
+#include <linux/seq_file.h>
+#include <linux/init.h>
+#include <linux/random.h>
+#include <linux/bootmem.h>
+#include <linux/irq.h>
+
+#include <asm/system.h>
+#include <asm/traps.h>
+#include <asm/io.h>

arch/h8300/kernel/irq.c line 30

Quoted 10 lines

arch/h8300/kernel/irq.c new file +10 -0

+#include <asm/setup.h>
+#include <asm/errno.h>
+
+/*#define DEBUG*/
+
+extern unsigned long *interrupt_redirect_table;
+extern const int h8300_saved_vectors[];
+extern const unsigned long h8300_trap_table[];
+int h8300_enable_irq_pin(unsigned int irq);
+void h8300_disable_irq_pin(unsigned int irq);

Please always avoid putting extern declarations into C files. Please them in a header file which is visible tot he definition site asw well as all callers/users.

For something which is defined in assembly code (like interrupt_redirect_table) it isn't so clear, because we cannot do typechecking. But I think it's still best to include the declaration in a header file so that we only have to declare it once. Plus it _is_ a global symbol.

Quoted 7 lines

arch/h8300/kernel/irq.c new file +7 -0

+
+/*
+ * h8300 interrupt controler implementation
+ */
+struct irq_chip h8300irq_chip = {
+	.name		= "H8300-INTC",
+	.startup	= h8300_startup_irq,

arch/h8300/kernel/irq.c line 81

Quoted 6 lines

arch/h8300/kernel/irq.c new file +6 -0

+	.shutdown	= h8300_shutdown_irq,
+	.enable		= h8300_enable_irq,
+	.disable	= h8300_disable_irq,
+	.ack		= NULL,
+	.end		= h8300_end_irq,
+};

I think this could have static scope.

arch/h8300/kernel/irq.c line 86

Quoted 4 lines

arch/h8300/kernel/irq.c new file +4 -0

+void ack_bad_irq(unsigned int irq)
+{
+	printk("unexpected IRQ trap at vector %02x\n", irq);
+}

printks should generally have facility levels (KERN_*)

arch/h8300/kernel/irq.c line 123

Quoted 1 line

arch/h8300/kernel/irq.c new file +1 -0

+		panic("interrupt vector serup failed.");

typo

arch/h8300/kernel/irq.c line 131

Quoted 1 line

arch/h8300/kernel/irq.c new file +1 -0

+	for ( i = 0; i < NR_IRQS; i++) {

	for (i = 0

arch/h8300/kernel/irq.c line 136

Quoted 5 lines

arch/h8300/kernel/irq.c new file +5 -0

+		if (i == *saved_vector) {
+			ramvec_p++;
+			saved_vector++;
+		} else {
+			if ( i < NR_TRAPS ) {

if (i < NR_TRAPS)