Skip to contentSkip to conversation

xfrm6: Fix a offset value for network header in _decode_session6

PATCH In review Hajime Tazaki 3 participants 3 messages Feb 4, 2015 – Feb 6, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfrm6: Fix a offset value for network header in _decode_session6

When a network-layer header has multiple IPv6 extension headers, then offset for mobility header goes wrong. This regression breaks an xfrm policy lookup for a particular receive packet. Binding update packets of Mobile IPv6 are all discarded without this fix.

Fixes de3b7a06dfe1 ("xfrm6: Fix transport header offset in _decode_session6.")
---
 net/ipv6/xfrm6_policy.c | 1 +
 1 file changed, 1 insertion(+)
net/ipv6/xfrm6_policy.c +1 -0
index 48bf5a0..8d2d01b 100644
@@ -200,6 +200,7 @@ _decode_session6(struct sk_buff *skb, struct flowi *fl, int reverse)
 
 #if IS_ENABLED(CONFIG_IPV6_MIP6)
 		case IPPROTO_MH:
+			offset += ipv6_optlen(exthdr);
 			if (!onlyproto && pskb_may_pull(skb, nh + offset + 3 - skb->data)) {
 				struct ip6_mh *mh;
 
Signature · 1 line
2.1.0
maintainer
#1 lore raw

From: Hajime Tazaki <[email protected]>
Date: Wed, 04 Feb 2015 23:31:10 +0900

Quoted 7 lines

When a network-layer header has multiple IPv6 extension headers, then offset for mobility header goes wrong. This regression breaks an xfrm policy lookup for a particular receive packet. Binding update packets of Mobile IPv6 are all discarded without this fix.

Fixes de3b7a06dfe1 ("xfrm6: Fix transport header offset in _decode_session6.")

Steffen, please review and/or integrate into your tree.

Thanks.

maintainer
#2 lore raw
Quoted 8 lines · David Miller

From: Hajime Tazaki <[email protected]>
Date: Wed, 04 Feb 2015 23:31:10 +0900

Quoted 5 lines

When a network-layer header has multiple IPv6 extension headers, then offset for mobility header goes wrong. This regression breaks an xfrm policy lookup for a particular receive packet. Binding update packets of Mobile IPv6 are all discarded without this fix.

Quoted 4 lines
Quoted 2 lines
Fixes de3b7a06dfe1 ("xfrm6: Fix transport header offset in _decode_session6.")

Steffen, please review and/or integrate into your tree.

Now applied to the ipsec tree, thanks!