Skip to contentSkip to conversation

Can't open CDROM device for writing

PATCH In review Peter Osterlund 2 participants 2 messages Jul 1, 2004 – Jul 2, 2004 Uniform cdrom driver

lore
Share & tools
lore

Peter Osterlund

author
#0 lore raw

PATCH 1/1 Can't open CDROM device for writing

Opening a CDROM device for writing no longer works, because cdrom_open() returns -EROFS even if cdrom_open_write() succeeds. This patch for 2.6.7-bk13 fixes it.

Signed-off-by Peter Osterlund <[email protected]>

---

 linux-petero/drivers/cdrom/cdrom.c |    1 +
 1 files changed, 1 insertion(+)
drivers/cdrom/cdrom.c renamed from drivers/cdrom/cdrom.c~cdrom-write-fix +1 -0
diff -puN drivers/cdrom/cdrom.c~cdrom-write-fix drivers/cdrom/cdrom.c
@@ -901,6 +901,7 @@ int cdrom_open(struct cdrom_device_info 
 				goto err;
 			if (cdrom_open_write(cdi))
 				goto err;
+			ret = 0;
 		}
 	}

_

Signature · 2 lines
Peter Osterlund - [email protected]
http://w1.894.telia.com/~u89404340
#1 lore raw
Quoted 15 lines · Peter Osterlund

Opening a CDROM device for writing no longer works, because cdrom_open() returns -EROFS even if cdrom_open_write() succeeds. This patch for 2.6.7-bk13 fixes it.

Signed-off-by Peter Osterlund <[email protected]>

---

 linux-petero/drivers/cdrom/cdrom.c |    1 +
 1 files changed, 1 insertion(+)

diff -puN drivers/cdrom/cdrom.c~cdrom-write-fix drivers/cdrom/cdrom.c

drivers/cdrom/cdrom.c int cdrom_open(struct cdrom_device_info · line 906

Quoted 6 lines
drivers/cdrom/cdrom.c renamed from drivers/cdrom/cdrom.c~cdrom-write-fix +1 -0
@@ -901,6 +901,7 @@ int cdrom_open(struct cdrom_device_info 
 				goto err;
 			if (cdrom_open_write(cdi))
 				goto err;
+			ret = 0;
 		}
 	}

Indeed, thanks.

Signature · 1 line
Jens Axboe