Skip to contentSkip to conversation

Terminate i386 local APIC DMI exception table

PATCH New Andi Kleen 1 participant 1 message Sep 27, 2004

lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 Terminate i386 local APIC DMI exception table

[sending directly to Linus because Andrew said he is away]

The i386 local APIC DMI exception table was not 0 terminated. The dmi parser would walk into random .data space. Found during code review, not known to cause problems, but should be still fixed. I checked all other DMI tables and they seemed to be ok.

arch/i386/kernel/apic.c renamed from arch/i386/kernel/apic.c-o +2 -1
diff -u linux/arch/i386/kernel/apic.c-o linux/arch/i386/kernel/apic.c
@@ -1233,7 +1233,8 @@
 static struct dmi_system_id __initdata apic_dmi_table[] = {
 	{ need_local_apic, "Intel C440GX+", {
 	  DMI_MATCH(DMI_BOARD_VENDOR,"Intel"),
-	  DMI_MATCH(DMI_BOARD_NAME,"C440GX+") } }
+	  DMI_MATCH(DMI_BOARD_NAME,"C440GX+") } },
+	{},
 };
 
 /*