SOLO6x10: don't do DMA from stack in solo_dma_vin_region().
Subsystems (2)
PATCH 1/1 SOLO6x10: don't do DMA from stack in solo_dma_vin_region().
Signed-off-by Krzysztof Hałasa <[email protected]>
drivers/staging/media/solo6x10/solo6x10-disp.c +16 -8
@@ -176,18 +176,26 @@ static void solo_vout_config(struct solo_dev *solo_dev)static int solo_dma_vin_region (struct solo_dev *solo_dev,u32 off,u16 val,int reg_size) { -u16 buf[64 ]; -int i; -int ret =0 ; +u16 *buf; +const int n =64 , size = n *sizeof (*buf); +int i, ret =0 ; + +if (!(buf =kmalloc (size,GFP_KERNEL ))) +return -ENOMEM ; -for (i =0 ; i <sizeof (buf) >>1 ; i++) +for (i =0 ; i < n; i++) buf[i] =cpu_to_le16 (val); -for (i =0 ; i < reg_size; i +=sizeof (buf)) - ret |=solo_p2m_dma (solo_dev,1 , buf, -SOLO_MOTION_EXT_ADDR (solo_dev) + off + i, -sizeof (buf),0 ,0 ); +for (i =0 ; i < reg_size; i += size) { + ret =solo_p2m_dma (solo_dev,1 , buf, +SOLO_MOTION_EXT_ADDR (solo_dev) + off + i, + size,0 ,0 ); + +if (ret) +break ; + } +kfree (buf);return ret; }
Ismael,
Can you Ack these four patches?
Regards,
Hans
Quoted 46 lines · Krzysztof Hałasa
Signed-off-by Krzysztof Hałasa <[email protected]>drivers/staging/media/solo6x10/solo6x10-disp.c +16
-9@@ -176,18 +176,26 @@ static void solo_vout_config(struct solo_dev *solo_dev)static int solo_dma_vin_region (struct solo_dev *solo_dev,u32 off,u16 val,int reg_size) { -u16 buf[64 ]; -int i; -int ret =0 ; +u16 *buf; +const int n =64 , size = n *sizeof (*buf); +int i, ret =0 ; + +if (!(buf =kmalloc (size,GFP_KERNEL ))) +return -ENOMEM ; -for (i =0 ; i <sizeof (buf) >>1 ; i++) +for (i =0 ; i < n; i++) buf[i] =cpu_to_le16 (val); -for (i =0 ; i < reg_size; i +=sizeof (buf)) - ret |=solo_p2m_dma (solo_dev,1 , buf, -SOLO_MOTION_EXT_ADDR (solo_dev) + off + i, -sizeof (buf),0 ,0 ); +for (i =0 ; i < reg_size; i += size) { + ret =solo_p2m_dma (solo_dev,1 , buf, +SOLO_MOTION_EXT_ADDR (solo_dev) + off + i, + size,0 ,0 ); + +if (ret) +break ; + } +kfree (buf);return ret; } --To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 1 line · On Thu, 12 Sep 2013 14:25:36 +0200 [email protected] (Krzysztof Hałasa) wrote:
Signed-off-by Krzysztof Hałasa <[email protected]>
Acked-by Ismael Luceno <[email protected]>
<...>