Skip to contentSkip to conversation

rc: do not enable remote controller adapters by default.

PATCH In review Stephen Wilson 5 participants 7 messages Feb 16, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rc: do not enable remote controller adapters by default.

Having the RC_CORE config default to INPUT is almost equivalent to saying "yes". Default to "no" instead.

---
 drivers/media/rc/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/media/rc/Kconfig +1 -1
index 3785162..8842843 100644
@@ -1,7 +1,7 @@
 menuconfig RC_CORE
 	tristate "Remote Controller adapters"
 	depends on INPUT
-	default INPUT
+	default n
 	---help---
 	  Enable support for Remote Controllers on Linux. This is
 	  needed in order to support several video capture adapters.

--
1.7.3.5

#1 lore raw
Quoted 4 lines · Stephen Wilson

Having the RC_CORE config default to INPUT is almost equivalent to saying "yes". Default to "no" instead.

I don't particularly like this, if it discourages desktop distributions from building RC_CORE. The whole point of RC_CORE in kernel was to have the remote controllers bundled with TV and DTV cards "just work" out of the box for end users. Also the very popular MCE USB receiver device, shipped with Media Center PC setups, needs it too.

Why exactly do you need it set to "No"?

Regards,
Andy

Quoted 23 lines
---
 drivers/media/rc/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/media/rc/Kconfig +1 -2
index 3785162..8842843 100644
@@ -1,7 +1,7 @@
 menuconfig RC_CORE
 	tristate "Remote Controller adapters"
 	depends on INPUT
-	default INPUT
+	default n
 	---help---
 	  Enable support for Remote Controllers on Linux. This is
 	  needed in order to support several video capture adapters.
--

1.7.3.5
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 11 lines · Andy Walls
Quoted 4 lines · Stephen Wilson

Having the RC_CORE config default to INPUT is almost equivalent to saying "yes". Default to "no" instead.

I don't particularly like this, if it discourages desktop distributions from building RC_CORE. The whole point of RC_CORE in kernel was to have the remote controllers bundled with TV and DTV cards "just work" out of the box for end users. Also the very popular MCE USB receiver device, shipped with Media Center PC setups, needs it too.

A similar argument can be made for any particular feature or device that just works when the functionality is enabled :)

Quoted 1 line

Why exactly do you need it set to "No"?

It is not a need. I simply observed that after the IR_ to RC_ rename there was another set of drivers being built which I did not ask for.

It struck me as odd that because basic keyboard/mouse support was enabled I also got support for DTV card remote controls.

I don't think there are any other driver subsystems enabling themselves based on something as generic as INPUT (as a dependency it is just fine, obviously).

Overall, it just seems like the wrong setting to me. Is there another predicate available that makes a bit more sense for RC_CORE other than INPUT? Something related to the TV or DTV cards perhaps?

Take care,

Quoted 19 lines

Regards,
Andy

Quoted 15 lines
---
 drivers/media/rc/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/media/rc/Kconfig +1 -1
index 3785162..8842843 100644
@@ -1,7 +1,7 @@
 menuconfig RC_CORE
 	tristate "Remote Controller adapters"
 	depends on INPUT
-	default INPUT
+	default n
 	---help---
Quoted 8 lines
Quoted 8 lines
drivers/media/rc/Kconfig +0 -1
 	  Enable support for Remote Controllers on Linux. This is
 	  needed in order to support several video capture adapters.
--

1.7.3.5
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
steve

#3 lore raw
Quoted 14 lines · Stephen Wilson
Quoted 11 lines · Andy Walls
Quoted 4 lines · Stephen Wilson

Having the RC_CORE config default to INPUT is almost equivalent to saying "yes". Default to "no" instead.

I don't particularly like this, if it discourages desktop distributions from building RC_CORE. The whole point of RC_CORE in kernel was to have the remote controllers bundled with TV and DTV cards "just work" out of the box for end users. Also the very popular MCE USB receiver device, shipped with Media Center PC setups, needs it too.

Quoted 7 lines

A similar argument can be made for any particular feature or device that just works when the functionality is enabled :)

Quoted 1 line

Why exactly do you need it set to "No"?

It is not a need. I simply observed that after the IR_ to RC_ rename there was another set of drivers being built which I did not ask for.

So disable them. I think most people would rather have this support enabled so that remotes Just Work if a DTV card or stand-alone IR receiver is plugged in without having to hunt back through Kconfig options to figure out why it doesn't...

Quoted 10 lines

It struck me as odd that because basic keyboard/mouse support was enabled I also got support for DTV card remote controls.

I don't think there are any other driver subsystems enabling themselves based on something as generic as INPUT (as a dependency it is just fine, obviously).

Overall, it just seems like the wrong setting to me. Is there another predicate available that makes a bit more sense for RC_CORE other than INPUT? Something related to the TV or DTV cards perhaps?

No. As Andy said, there are stand-alone devices, such as the Windows Media Center Ed. eHome Infrared Transceivers which are simply a usb device, no direct relation to any TV devices. A fair number of systems these days are also shipping with built-in CIR support by way of a sub-function on an LPC SuperIO chip. Remotes can be used to control more than just changing channels on a TV tuner card (think music player, video playback app streaming content from somewhere on the network, etc).

Signature · 2 lines
Jarod Wilson
[email protected]
#4 lore raw
Quoted 39 lines · Jarod Wilson
Quoted 14 lines · Stephen Wilson
Quoted 11 lines · Andy Walls
Quoted 4 lines · Stephen Wilson

Having the RC_CORE config default to INPUT is almost equivalent to saying "yes". Default to "no" instead.

I don't particularly like this, if it discourages desktop distributions from building RC_CORE. The whole point of RC_CORE in kernel was to have the remote controllers bundled with TV and DTV cards "just work" out of the box for end users. Also the very popular MCE USB receiver device, shipped with Media Center PC setups, needs it too.

Quoted 7 lines

A similar argument can be made for any particular feature or device that just works when the functionality is enabled :)

Quoted 1 line

Why exactly do you need it set to "No"?

It is not a need. I simply observed that after the IR_ to RC_ rename there was another set of drivers being built which I did not ask for.

So disable them. I think most people would rather have this support enabled so that remotes Just Work if a DTV card or stand-alone IR receiver is plugged in without having to hunt back through Kconfig options to figure out why it doesn't...

Quoted 10 lines

It struck me as odd that because basic keyboard/mouse support was enabled I also got support for DTV card remote controls.

I don't think there are any other driver subsystems enabling themselves based on something as generic as INPUT (as a dependency it is just fine, obviously).

Overall, it just seems like the wrong setting to me. Is there another predicate available that makes a bit more sense for RC_CORE other than INPUT? Something related to the TV or DTV cards perhaps?

Quoted 7 lines

No. As Andy said, there are stand-alone devices, such as the Windows Media Center Ed. eHome Infrared Transceivers which are simply a usb device, no direct relation to any TV devices. A fair number of systems these days are also shipping with built-in CIR support by way of a sub-function on an LPC SuperIO chip. Remotes can be used to control more than just changing channels on a TV tuner card (think music player, video playback app streaming content from somewhere on the network, etc).

OK. No problem. Thanks for for taking the time to explain!

--
steve

#5 lore raw
In reply to Jarod Wilson
Quoted 7 lines · Jarod Wilson
Quoted 2 lines

It is not a need.  I simply observed that after the IR_ to RC_ rename there was another set of drivers being built which I did not ask for.

So disable them. I think most people would rather have this support enabled so that remotes Just Work if a DTV card or stand-alone IR receiver is plugged in without having to hunt back through Kconfig options to figure out why it doesn't...

Unfortunately _ALL_ the usb DVB devices are unavailable if you do not enable IR_CORE "Infrared remote controller adapters" in v4l. This is a little annoying as the usb device I use doesn't even have IR capabilities. It doesn't seem like something that should be forced on the user -- enable IR or you can't even compile the driver you need, which doesn't even use IR.

It's not the end of the world but I don't particularly appreciate the enable-everything approach. It would be nice to at least have the option to trim the fat if you want.. Isn't that partially what Linux is supposed to be about in the first place?

Just my two cents...

#6 lore raw

Em 16-02-2011 15:25, VDR User escreveu:

Quoted 16 lines · Jarod Wilson
Quoted 7 lines
Quoted 2 lines

It is not a need. I simply observed that after the IR_ to RC_ rename there was another set of drivers being built which I did not ask for.

So disable them. I think most people would rather have this support enabled so that remotes Just Work if a DTV card or stand-alone IR receiver is plugged in without having to hunt back through Kconfig options to figure out why it doesn't...

Unfortunately _ALL_ the usb DVB devices are unavailable if you do not enable IR_CORE "Infrared remote controller adapters" in v4l. This is a little annoying as the usb device I use doesn't even have IR capabilities. It doesn't seem like something that should be forced on the user -- enable IR or you can't even compile the driver you need, which doesn't even use IR.

Quoted 4 lines

It's not the end of the world but I don't particularly appreciate the enable-everything approach. It would be nice to at least have the option to trim the fat if you want.. Isn't that partially what Linux is supposed to be about in the first place?

Unfortunately, the way almost all drivers/media/[video|dvb] was made, the IR (and input support on webcams) are tighted to the driver.

It would be possible to change it (and it is not that hard), but it requires people with enough time and skills to go into each driver that can support IR, split the IR code into a separate module and be sure that the driver will compile and work with or without IR support.

Cheers,
Mauro