Skip to contentSkip to conversation

RFC: initramfs unpack point and rules

DISCUSSION Krzysztof Halasa 2 participants 4 messages Apr 5, 2007 – Apr 13, 2007 Generic include/asm header files

lore
Share & tools
lore
#0 lore raw

Hi,

I recently got a BSOD bootup problem with external initramfs (it's ARM but it seems it doesn't matter).

--------------------------------------------------------------------------

First problem: initramfs is unpacked way before console drivers are initialized, so you aren't going to see the panic():

init/initramfs.c:static int __init populate_rootfs(void)
...

		printk(KERN_INFO "Unpacking initramfs...");
		err = unpack_to_rootfs((char *)initrd_start,
			initrd_end - initrd_start, 0);
		if (err)
			panic(err);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
		printk(" done\n");
		free_initrd();

I wonder why is initramfs unpacked that early, before most drivers? I'd expect it much later in the boot sequence, just before userspace and initial devices (/dev/console etc) are needed. Should it be moved there? populate_rootfs() unpacks both builtin and external initramfs.

--------------------------------------------------------------------------

Second problem:
RedBoot> exec -r 0x800000 -s 8000000 -c "console=ttyS0,115200"

Using base address 0x00030000 and length 0x001eea08 Uncompressing Linux...............................done, booting the kernel. [nothing then]

Obviously I didn't want to specify the exact size and expected inflate to determine it by itself. I think a valid gzipped cpio image, followed by some junk, should not be a problem here. Currently, unpack_to_rootfs() does the job but returns "bad gzip magic numbers" error message - I think I should change it to return that message only for first initramfs header and return a success if some junk is spotted after a valid end of compressed data.

Opinions?

Signature · 1 line
Krzysztof Halasa
#1 lore raw
Quoted 4 lines

I wonder why is initramfs unpacked that early, before most drivers? I'd expect it much later in the boot sequence, just before userspace and initial devices (/dev/console etc) are needed. Should it be moved there? populate_rootfs() unpacks both builtin and external initramfs.

I mean something like the attached patch would change the boot order from:

TCP reno registered
Unpacking initramfs... done ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Freeing initrd memory: 7812K
NetWinder Floating Point Emulator V0.97 (double precision)
io scheduler noop registered (default)
IXP4xx Watchdog Timer: heartbeat 60 sec
Serial: 8250/16550 driver $Revision: 1.90 $ 2 ports, IRQ sharing disabled serial8250.0: ttyS0 at MMIO 0xc8000000 (irq = 15) is a XScale serial8250.0: ttyS1 at MMIO 0xc8001000 (irq = 13) is a XScale PPP generic driver version 2.4.2
...

to:

802.1Q VLAN Support v1.8 Ben Greear <[email protected]> All bugs added by David S. Miller <[email protected]> Unpacking initramfs... done ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Freeing initrd memory: 7812K
XScale DSP coprocessor detected.
Freeing init memory: 628K
Time: OSTS clocksource has been installed.

login:

What do you think?

In case someone wants to apply it (but something tells me it's not that simple):

include/asm-generic/vmlinux.lds.h +1 -1
index 9fcc8d9..33e3036 100644
@@ -223,9 +223,9 @@
   	*(.initcall4s.init)						\
   	*(.initcall5.init)						\
   	*(.initcall5s.init)						\
-	*(.initcallrootfs.init)						\
   	*(.initcall6.init)						\
   	*(.initcall6s.init)						\
+	*(.initcallrootfs.init)						\
   	*(.initcall7.init)						\
   	*(.initcall7s.init)
 
include/linux/init.h +1 -1
index 5a593a1..6da2106 100644
@@ -111,9 +111,9 @@ extern void setup_arch(char **);
 #define subsys_initcall_sync(fn)	__define_initcall("4s",fn,4s)
 #define fs_initcall(fn)			__define_initcall("5",fn,5)
 #define fs_initcall_sync(fn)		__define_initcall("5s",fn,5s)
-#define rootfs_initcall(fn)		__define_initcall("rootfs",fn,rootfs)
 #define device_initcall(fn)		__define_initcall("6",fn,6)
 #define device_initcall_sync(fn)	__define_initcall("6s",fn,6s)
+#define rootfs_initcall(fn)		__define_initcall("rootfs",fn,rootfs)
 #define late_initcall(fn)		__define_initcall("7",fn,7)
 #define late_initcall_sync(fn)		__define_initcall("7s",fn,7s)
 
Signature · 1 line
Krzysztof Halasa
#2 lore raw
In reply to Krzysztof Halasa
Quoted 14 lines · Krzysztof Halasa

First problem: initramfs is unpacked way before console drivers are initialized, so you aren't going to see the panic():

init/initramfs.c:static int __init populate_rootfs(void)
...

		printk(KERN_INFO "Unpacking initramfs...");
		err = unpack_to_rootfs((char *)initrd_start,
			initrd_end - initrd_start, 0);
		if (err)
			panic(err);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
		printk(" done\n");
		free_initrd();
Quoted 4 lines

I wonder why is initramfs unpacked that early, before most drivers? I'd expect it much later in the boot sequence, just before userspace and initial devices (/dev/console etc) are needed. Should it be moved there? populate_rootfs() unpacks both builtin and external initramfs.

Nope. The point is to have it as early as possible, so that we had more or less normal environment when drivers, etc. are being initialized.

#3 lore raw
Quoted 2 lines · Al Viro

Nope. The point is to have it as early as possible, so that we had more or less normal environment when drivers, etc. are being initialized.

But traditionally the "normal environment" is a root fs not yet mounted. Do the drivers need initramfs? Which drivers?

In both cases it's a bit before /sbin/init (or /init) is launched, udevd isn't running and firmware can't be loaded.

OTOH when something goes wrong before console drivers are initialized, nothing can be seen. And with initramfs (especially with the external one) it's easy to screw something.

Signature · 1 line
Krzysztof Halasa