NFSv4 ACL set and inode attribute cache
Subsystems (2)
Hi,
I guess we are not marking the inode attribute as invalid when we set the ACL value. For ex:
/d# mkdir sub3
/d# ls -dl sub3
drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3
/d# nfs4_setfacl -s A:fd:EVERYONE@:rwax sub3
/d# ls -dl sub3
drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3
/d#
On the server i have the mode bits as
/d# ls -dl sub3
drwxrwxrwx 2 root root 4096 Nov 10 17:56 sub3
/d#
-aneesh
Quoted 15 lines · Aneesh Kumar K.V
Hi,
I guess we are not marking the inode attribute as invalid when we set the ACL value. For ex:
/d# mkdir sub3
/d# ls -dl sub3
drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3
/d#nfs4_setfacl-s A:fd:EVERYONE@:rwax sub3
/d# ls -dl sub3
drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3
/d#
Quoted 4 lines
On the server i have the mode bits as
/d# ls -dl sub3
drwxrwxrwx 2 root root 4096 Nov 10 17:56 sub3
/d#
We also have similar issue other way round. ie setting the mode bits don't result in ACL values being invalidated. But a second request get the right value of ACL as show below.
/d# nfs4_getfacl x
A::OWNER@:rw
A::GROUP@:rw
A::EVERYONE@:r
/d# chmod 600 x
/d# nfs4_getfacl x
A::OWNER@:rw
A::GROUP@:rw
A::EVERYONE@:r
/d#
Expected value is
/d# nfs4_getfacl x
A::OWNER@:rw
-aneesh
Quoted 16 lines · Aneesh Kumar K. V
Quoted 15 lines · Aneesh Kumar K.V
Hi,
I guess we are not marking the inode attribute as invalid when we set the ACL value. For ex:
/d# mkdir sub3
/d# ls -dl sub3
drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3
/d#nfs4_setfacl-s A:fd:EVERYONE@:rwax sub3
/d# ls -dl sub3
drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3
/d#
Quoted 8 lines
Quoted 4 lines
On the server i have the mode bits as
/d# ls -dl sub3
drwxrwxrwx 2 root root 4096 Nov 10 17:56 sub3
/d#We also have similar issue other way round. ie setting the mode bits don't result in ACL values being invalidated. But a second request get the right value of ACL as show below.
Both look like bugs to me. (I remember their being pointed out before, though--did we drop the ball, or was there some reason for the current behavior?)
--b.
Quoted 22 lines
/d#
nfs4_getfaclx
A::OWNER@:rw
A::GROUP@:rw
A::EVERYONE@:r
/d# chmod 600 x
/d#nfs4_getfaclx
A::OWNER@:rw
A::GROUP@:rw
A::EVERYONE@:r
/d#Expected value is
/d#
nfs4_getfaclx
A::OWNER@:rw-aneesh
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 36 lines · Aneesh Kumar K. V
Quoted 15 lines · Aneesh Kumar K.V
Hi,
I guess we are not marking the inode attribute as invalid when we set the ACL value. For ex:
/d# mkdir sub3
/d# ls -dl sub3
drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3
/d#nfs4_setfacl-s A:fd:EVERYONE@:rwax sub3
/d# ls -dl sub3
drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3
/d#Quoted 4 lines
On the server i have the mode bits as
/d# ls -dl sub3
drwxrwxrwx 2 root root 4096 Nov 10 17:56 sub3
/d#We also have similar issue other way round. ie setting the mode bits don't result in ACL values being invalidated. But a second request get the right value of ACL as show below.
/d#
nfs4_getfaclx
A::OWNER@:rw
A::GROUP@:rw
A::EVERYONE@:r
/d# chmod 600 x
/d#nfs4_getfaclx
A::OWNER@:rw
A::GROUP@:rw
A::EVERYONE@:r
/d#
Quoted 5 lines
Expected value is
/d#
nfs4_getfaclx
A::OWNER@:rw
The below patch fix the problem for me. If this is the right way to fix, I can send a proper patch with commit message and s-o-b.
fs/nfs/nfs4proc.c +7 -0
@@ -3359,6 +3359,8 @@ static ssize_t nfs4_proc_get_acl(struct inode *inode, void *buf, size_t buflen) ret =nfs_revalidate_inode (server, inode);if (ret <0 )return ret; +if (NFS_I (inode)->cache_validity &NFS_INO_INVALID_ACL ) +nfs_zap_acl_cache (inode); ret =nfs4_read_cached_acl (inode, buf, buflen);if (ret != -ENOENT )return ret;
@@ -3387,6 +3389,11 @@ static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t buflnfs_inode_return_delegation (inode);buf_to_pages (buf, buflen, arg.acl_pages, &arg.acl_pgbase); ret =nfs4_call_sync (server, &msg, &arg, &res,1 ); +/* +* Acl update can result in inode attribute update. +* so mark the attribute cache invalid. +*/ +NFS_I (inode)->cache_validity |=NFS_INO_INVALID_ATTR ;nfs_access_zap_cache (inode);nfs_zap_acl_cache (inode);return ret;
Quoted 61 lines · Aneesh Kumar K. V
Quoted 36 lines · Aneesh Kumar K. V
Quoted 15 lines · Aneesh Kumar K.V
Hi,
I guess we are not marking the inode attribute as invalid when we set the ACL value. For ex:
/d# mkdir sub3
/d# ls -dl sub3
drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3
/d#nfs4_setfacl-s A:fd:EVERYONE@:rwax sub3
/d# ls -dl sub3
drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3
/d#Quoted 4 lines
On the server i have the mode bits as
/d# ls -dl sub3
drwxrwxrwx 2 root root 4096 Nov 10 17:56 sub3
/d#We also have similar issue other way round. ie setting the mode bits don't result in ACL values being invalidated. But a second request get the right value of ACL as show below.
/d#
nfs4_getfaclx
A::OWNER@:rw
A::GROUP@:rw
A::EVERYONE@:r
/d# chmod 600 x
/d#nfs4_getfaclx
A::OWNER@:rw
A::GROUP@:rw
A::EVERYONE@:r
/d#Quoted 5 lines
Expected value is
/d#
nfs4_getfaclx
A::OWNER@:rwThe below patch fix the problem for me. If this is the right way to fix, I can send a proper patch with commit message and s-o-b.
fs/nfs/nfs4proc.c +2
-0@@ -3359,6 +3359,8 @@ static ssize_t nfs4_proc_get_acl(struct inode *inode, void *buf, size_t buflen) ret =nfs_revalidate_inode (server, inode);if (ret <0 )return ret; +if (NFS_I (inode)->cache_validity &NFS_INO_INVALID_ACL ) +nfs_zap_acl_cache (inode); ret =nfs4_read_cached_acl (inode, buf, buflen);if (ret != -ENOENT )return ret;@@ -3387,6 +3389,11 @@ static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t buflnfs_inode_return_delegation (inode);
fs/nfs/nfs4proc.c static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t bufl · line 3399
Quoted 10 lines
fs/nfs/nfs4proc.c +5
-0buf_to_pages (buf, buflen, arg.acl_pages, &arg.acl_pgbase); ret =nfs4_call_sync (server, &msg, &arg, &res,1 ); +/* +* Acl update can result in inode attribute update. +* so mark the attribute cache invalid. +*/ +NFS_I (inode)->cache_validity |=NFS_INO_INVALID_ATTR ;nfs_access_zap_cache (inode);nfs_zap_acl_cache (inode);return ret;
Any update on this ? Another option i figured out today is to make sure we add FATTR4_WORD0_ACL in nfs4_fattr_bitmap for fetching the modified acl value on mode update. Similarly setfacl can be compounded with the getattr request.
-aneesh
Quoted 61 lines · Aneesh Kumar K. V
Quoted 60 lines · Aneesh Kumar K. V
Quoted 36 lines · Aneesh Kumar K. V
Quoted 15 lines · Aneesh Kumar K.V
Hi,
I guess we are not marking the inode attribute as invalid when we set the ACL value. For ex:
/d# mkdir sub3
/d# ls -dl sub3
drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3
/d#nfs4_setfacl-s A:fd:EVERYONE@:rwax sub3
/d# ls -dl sub3
drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3
/d#Quoted 4 lines
On the server i have the mode bits as
/d# ls -dl sub3
drwxrwxrwx 2 root root 4096 Nov 10 17:56 sub3
/d#We also have similar issue other way round. ie setting the mode bits don't result in ACL values being invalidated. But a second request get the right value of ACL as show below.
/d#
nfs4_getfaclx
A::OWNER@:rw
A::GROUP@:rw
A::EVERYONE@:r
/d# chmod 600 x
/d#nfs4_getfaclx
A::OWNER@:rw
A::GROUP@:rw
A::EVERYONE@:r
/d#Quoted 5 lines
Expected value is
/d#
nfs4_getfaclx
A::OWNER@:rwThe below patch fix the problem for me. If this is the right way to fix, I can send a proper patch with commit message and s-o-b.
fs/nfs/nfs4proc.c +2
-0@@ -3359,6 +3359,8 @@ static ssize_t nfs4_proc_get_acl(struct inode *inode, void *buf, size_t buflen) ret =nfs_revalidate_inode (server, inode);if (ret <0 )return ret; +if (NFS_I (inode)->cache_validity &NFS_INO_INVALID_ACL ) +nfs_zap_acl_cache (inode); ret =nfs4_read_cached_acl (inode, buf, buflen);if (ret != -ENOENT )return ret;@@ -3387,6 +3389,11 @@ static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t bufl
Quoted 8 lines
fs/nfs/nfs4proc.c static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t bufl · line 3396
Quoted 8 lines
fs/nfs/nfs4proc.c +5
-0nfs_inode_return_delegation (inode);buf_to_pages (buf, buflen, arg.acl_pages, &arg.acl_pgbase); ret =nfs4_call_sync (server, &msg, &arg, &res,1 ); +/* +* Acl update can result in inode attribute update. +* so mark the attribute cache invalid. +*/ +NFS_I (inode)->cache_validity |=NFS_INO_INVALID_ATTR ;
This needs to be done under the correct spin locks, so please use the helper nfs_mark_for_revalidate() instead of attempting to open coding it.
Quoted 9 lines
fs/nfs/nfs4proc.c static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t bufl · line 3399
Quoted 3 lines
fs/nfs/nfs4proc.c +0
-0nfs_access_zap_cache (inode);nfs_zap_acl_cache (inode);return ret;Any update on this ? Another option i figured out today is to make sure we add
FATTR4_WORD0_ACLinnfs4_fattr_bitmapfor fetching the modified acl value on mode update. Similarly setfacl can be compounded with the getattr request.
We actually used to compound setacl with a GETATTR(FATTR4_WORD0_ACL) in order to ensure that the server sets it correctly. Unfortunately, that caused some servers to return NFS4ERR_RESOURCE due to the burden of caching all that acl information in the duplicate request queue.
I'd be fine with adding an ordinary getattr request, though, as long as it is allowed to fail (i.e. the result of __nfs4_proc_set_acl() must only depend on the setacl).
Trond
Signature · 6 lines
Trond Myklebust Linux NFS client maintainer NetApp [email protected] www.netapp.com
Quoted 66 lines · Trond Myklebust
Quoted 65 lines · Aneesh Kumar K. V
Quoted 64 lines · Aneesh Kumar K. V
Quoted 36 lines · Aneesh Kumar K. V
Quoted 15 lines · Aneesh Kumar K.V
Hi,
I guess we are not marking the inode attribute as invalid when we set the ACL value. For ex:
/d# mkdir sub3
/d# ls -dl sub3
drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3
/d#nfs4_setfacl-s A:fd:EVERYONE@:rwax sub3
/d# ls -dl sub3
drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3
/d#Quoted 4 lines
On the server i have the mode bits as
/d# ls -dl sub3
drwxrwxrwx 2 root root 4096 Nov 10 17:56 sub3
/d#We also have similar issue other way round. ie setting the mode bits don't result in ACL values being invalidated. But a second request get the right value of ACL as show below.
/d#
nfs4_getfaclx
A::OWNER@:rw
A::GROUP@:rw
A::EVERYONE@:r
/d# chmod 600 x
/d#nfs4_getfaclx
A::OWNER@:rw
A::GROUP@:rw
A::EVERYONE@:r
/d#Quoted 5 lines
Expected value is
/d#
nfs4_getfaclx
A::OWNER@:rwThe below patch fix the problem for me. If this is the right way to fix, I can send a proper patch with commit message and s-o-b.
fs/nfs/nfs4proc.c +3
-0@@ -3359,6 +3359,8 @@ static ssize_t nfs4_proc_get_acl(struct inode *inode, void *buf, size_t buflen) ret =nfs_revalidate_inode (server, inode);if (ret <0 )return ret; +if (NFS_I (inode)->cache_validity &NFS_INO_INVALID_ACL ) +nfs_zap_acl_cache (inode); ret =nfs4_read_cached_acl (inode, buf, buflen);if (ret != -ENOENT )return ret;@@ -3387,6 +3389,11 @@ static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t buflnfs_inode_return_delegation (inode);buf_to_pages (buf, buflen, arg.acl_pages, &arg.acl_pgbase); ret =nfs4_call_sync (server, &msg, &arg, &res,1 ); +/*
Quoted 8 lines
Quoted 4 lines
fs/nfs/nfs4proc.c static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t bufl · line 3396
Quoted 4 lines
fs/nfs/nfs4proc.c +4
-0+* Acl update can result in inode attribute update. +* so mark the attribute cache invalid. +*/ +NFS_I (inode)->cache_validity |=NFS_INO_INVALID_ATTR ;This needs to be done under the correct spin locks, so please use the helper
nfs_mark_for_revalidate()instead of attempting to open coding it.
nfs_mark_for_revalidate mark other fields as invalid. Do we need to do that when updating ACL ? If not how about
spin_lock(&inode->i_lock);
NFS_I(inode)->cache_validity |= NFS_INO_INVALID_ATTR;
spin_unlock(&inode->i_lock);Quoted 11 lines
Quoted 10 lines
fs/nfs/nfs4proc.c static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t bufl · line 3399
Quoted 4 lines
fs/nfs/nfs4proc.c +0
-0nfs_access_zap_cache (inode);nfs_zap_acl_cache (inode);return ret;Any update on this ? Another option i figured out today is to make sure we add
FATTR4_WORD0_ACLinnfs4_fattr_bitmapfor fetching the modified acl value on mode update. Similarly setfacl can be compounded with the getattr request.
Quoted 4 lines
We actually used to compound setacl with a
GETATTR(FATTR4_WORD0_ACL)in order to ensure that the server sets it correctly. Unfortunately, that caused some servers to returnNFS4ERR_RESOURCEdue to the burden of caching all that acl information in the duplicate request queue.
What i was suggesting was to compound setacl with GETATTR(FATTR4_WORD1_MODE) so that we get the update mode bits as a part of response. Also componding setattr request with GETATTR(FATTR4_WORD0_ACL)
Quoted 5 lines
I'd be fine with adding an ordinary getattr request, though, as long as it is allowed to fail (i.e. the result of
__nfs4_proc_set_acl()must only depend on the setacl).
-aneesh
Quoted 94 lines · Aneesh Kumar K. V
Quoted 66 lines · Trond Myklebust
Quoted 65 lines · Aneesh Kumar K. V
Quoted 64 lines · Aneesh Kumar K. V
Quoted 36 lines · Aneesh Kumar K. V
Quoted 15 lines · Aneesh Kumar K.V
Hi,
I guess we are not marking the inode attribute as invalid when we set the ACL value. For ex:
/d# mkdir sub3
/d# ls -dl sub3
drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3
/d#nfs4_setfacl-s A:fd:EVERYONE@:rwax sub3
/d# ls -dl sub3
drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3
/d#Quoted 4 lines
On the server i have the mode bits as
/d# ls -dl sub3
drwxrwxrwx 2 root root 4096 Nov 10 17:56 sub3
/d#We also have similar issue other way round. ie setting the mode bits don't result in ACL values being invalidated. But a second request get the right value of ACL as show below.
/d#
nfs4_getfaclx
A::OWNER@:rw
A::GROUP@:rw
A::EVERYONE@:r
/d# chmod 600 x
/d#nfs4_getfaclx
A::OWNER@:rw
A::GROUP@:rw
A::EVERYONE@:r
/d#Quoted 5 lines
Expected value is
/d#
nfs4_getfaclx
A::OWNER@:rwThe below patch fix the problem for me. If this is the right way to fix, I can send a proper patch with commit message and s-o-b.
fs/nfs/nfs4proc.c +3
-0@@ -3359,6 +3359,8 @@ static ssize_t nfs4_proc_get_acl(struct inode *inode, void *buf, size_t buflen) ret =nfs_revalidate_inode (server, inode);if (ret <0 )return ret; +if (NFS_I (inode)->cache_validity &NFS_INO_INVALID_ACL ) +nfs_zap_acl_cache (inode); ret =nfs4_read_cached_acl (inode, buf, buflen);if (ret != -ENOENT )return ret;@@ -3387,6 +3389,11 @@ static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t buflnfs_inode_return_delegation (inode);buf_to_pages (buf, buflen, arg.acl_pages, &arg.acl_pgbase); ret =nfs4_call_sync (server, &msg, &arg, &res,1 ); +/* Quoted 8 lines
Quoted 4 lines
fs/nfs/nfs4proc.c static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t bufl · line 3396
Quoted 4 lines
fs/nfs/nfs4proc.c +4
-0+* Acl update can result in inode attribute update. +* so mark the attribute cache invalid. +*/ +NFS_I (inode)->cache_validity |=NFS_INO_INVALID_ATTR ;This needs to be done under the correct spin locks, so please use the helper
nfs_mark_for_revalidate()instead of attempting to open coding it.
nfs_mark_for_revalidatemark other fields as invalid. Do we need to do that when updating ACL ? If not how aboutspin_lock(&inode->i_lock); NFS_I(inode)->cache_validity |= NFS_INO_INVALID_ATTR; spin_unlock(&inode->i_lock);Quoted 11 lines
Quoted 10 lines
fs/nfs/nfs4proc.c static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t bufl · line 3399
Quoted 4 lines
fs/nfs/nfs4proc.c +0
-0nfs_access_zap_cache (inode);nfs_zap_acl_cache (inode);return ret;Any update on this ? Another option i figured out today is to make sure we add
FATTR4_WORD0_ACLinnfs4_fattr_bitmapfor fetching the modified acl value on mode update. Similarly setfacl can be compounded with the getattr request.
Quoted 8 lines
Quoted 4 lines
We actually used to compound setacl with a
GETATTR(FATTR4_WORD0_ACL)in order to ensure that the server sets it correctly. Unfortunately, that caused some servers to returnNFS4ERR_RESOURCEdue to the burden of caching all that acl information in the duplicate request queue.What i was suggesting was to compound setacl with
GETATTR(FATTR4_WORD1_MODE)so that we get the update mode bits as a part of response. Also componding setattr request withGETATTR(FATTR4_WORD0_ACL)
The problem was that ACL's are essentially arbitrary length, so some servers didn't like having to a reply with an ACL in it. Mode bits are a small fixed length so don't have the same problem.
So that would suggest setting an ACL and getting a mode in one compound would be OK, but if you set a mode and got an ACL in one compound you might need to be prepared to handle NFS4ERR_RESOURCE.
--b.
Quoted 76 lines · Aneesh Kumar K. V
Quoted 66 lines · Trond Myklebust
Quoted 65 lines · Aneesh Kumar K. V
Quoted 64 lines · Aneesh Kumar K. V
Quoted 36 lines · Aneesh Kumar K. V
Quoted 15 lines · Aneesh Kumar K.V
Hi,
I guess we are not marking the inode attribute as invalid when we set the ACL value. For ex:
/d# mkdir sub3
/d# ls -dl sub3
drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3
/d#nfs4_setfacl-s A:fd:EVERYONE@:rwax sub3
/d# ls -dl sub3
drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3
/d#Quoted 4 lines
On the server i have the mode bits as
/d# ls -dl sub3
drwxrwxrwx 2 root root 4096 Nov 10 17:56 sub3
/d#We also have similar issue other way round. ie setting the mode bits don't result in ACL values being invalidated. But a second request get the right value of ACL as show below.
/d#
nfs4_getfaclx
A::OWNER@:rw
A::GROUP@:rw
A::EVERYONE@:r
/d# chmod 600 x
/d#nfs4_getfaclx
A::OWNER@:rw
A::GROUP@:rw
A::EVERYONE@:r
/d#Quoted 5 lines
Expected value is
/d#
nfs4_getfaclx
A::OWNER@:rwThe below patch fix the problem for me. If this is the right way to fix, I can send a proper patch with commit message and s-o-b.
fs/nfs/nfs4proc.c +3
-0@@ -3359,6 +3359,8 @@ static ssize_t nfs4_proc_get_acl(struct inode *inode, void *buf, size_t buflen) ret =nfs_revalidate_inode (server, inode);if (ret <0 )return ret; +if (NFS_I (inode)->cache_validity &NFS_INO_INVALID_ACL ) +nfs_zap_acl_cache (inode); ret =nfs4_read_cached_acl (inode, buf, buflen);if (ret != -ENOENT )return ret;@@ -3387,6 +3389,11 @@ static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t buflnfs_inode_return_delegation (inode);buf_to_pages (buf, buflen, arg.acl_pages, &arg.acl_pgbase); ret =nfs4_call_sync (server, &msg, &arg, &res,1 ); +/* Quoted 8 lines
Quoted 4 lines
fs/nfs/nfs4proc.c static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t bufl · line 3396
Quoted 4 lines
fs/nfs/nfs4proc.c +4
-0+* Acl update can result in inode attribute update. +* so mark the attribute cache invalid. +*/ +NFS_I (inode)->cache_validity |=NFS_INO_INVALID_ATTR ;This needs to be done under the correct spin locks, so please use the helper
nfs_mark_for_revalidate()instead of attempting to open coding it.
Quoted 8 lines
nfs_mark_for_revalidatemark other fields as invalid. Do we need to do that when updating ACL ? If not how aboutspin_lock(&inode->i_lock); NFS_I(inode)->cache_validity |= NFS_INO_INVALID_ATTR; spin_unlock(&inode->i_lock);
That's fine as a short term fix. For the long term, let's try to add the getattr, as you suggested, so that we can do the inode attribute revalidation here.
Quoted 10 lines
Quoted 10 lines
Quoted 9 lines
fs/nfs/nfs4proc.c static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t bufl · line 3399
Quoted 3 lines
fs/nfs/nfs4proc.c +0
-0nfs_access_zap_cache (inode);nfs_zap_acl_cache (inode);return ret;Any update on this ? Another option i figured out today is to make sure we add
FATTR4_WORD0_ACLinnfs4_fattr_bitmapfor fetching the modified acl value on mode update. Similarly setfacl can be compounded with the getattr request.
Quoted 8 lines
Quoted 4 lines
We actually used to compound setacl with a
GETATTR(FATTR4_WORD0_ACL)in order to ensure that the server sets it correctly. Unfortunately, that caused some servers to returnNFS4ERR_RESOURCEdue to the burden of caching all that acl information in the duplicate request queue.What i was suggesting was to compound setacl with
GETATTR(FATTR4_WORD1_MODE)so that we get the update mode bits as a part of response. Also componding setattr request withGETATTR(FATTR4_WORD0_ACL)
You'd be missing the change attribute and the ctime, both of which are also guaranteed to change when the acl is changed.
We might as well just do a full attribute revalidation...
Signature · 6 lines
Trond Myklebust Linux NFS client maintainer NetApp [email protected] www.netapp.com