Skip to contentSkip to conversation

local_irq_enable() in __do_softirq()?

PATCH Peter Osterlund 1 participant 1 message Jul 30, 2005

lore
Share & tools
lore
#0 lore raw

Hi,

The change "x86_64: Switch to the interrupt stack when running a softirq in local_bh ..." (ed6b676ca8b50e0b538e61c283d52fd04f007abf) contains this:

kernel/softirq.c +2 -2
@@ -86,7 +86,7 @@ restart:
 	/* Reset the pending bitmask before enabling irqs */
 	local_softirq_pending() = 0;
 
-	local_irq_enable();
+	//local_irq_enable();
 
 	h = softirq_vec;
 
@@ -99,7 +99,7 @@ restart:
 		pending >>= 1;
 	} while (pending);
 
-	local_irq_disable();
+	//local_irq_disable();
 
 	pending = local_softirq_pending();
 	if (pending && --max_restart)

Is that intentional? If so, shouldn't the code be removed instead of commented out?

Signature · 2 lines
Peter Osterlund - [email protected]
http://web.telia.com/~u89404340