Skip to contentSkip to conversation

how to get virtual address from dma address

DISCUSSION Pete Zaitcev 1 participant 1 message Oct 6, 2001 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 6 lines
Quoted 5 lines

I can not even count on one hand how many people I've helped converting, who wanted a bus_to_virt() and when I showed them how to do it with information the device provided already they said "oh wow, I never would have thought of that". That process won't happen as often with the suggested feature.

Quoted 7 lines

I look at all the hash-table stuff in the usb-ohci driver and I think to myself about all the complexity that is there (and I haven't managed to convince myself yet that it is actually SMP-safe) and all the time wasted doing that stuff, when on probably 95% of the machines that use the usb-ohci driver, the hashing stuff is totally unnecessary. I am talking about powermacs, which don't have an iommu, and where the reverse mapping is as simple as adding a constant.

That's one kinky driver, no wonder you were traumatized by looking at it. I think you must not project the shock and horror of usb-ohci onto other drivers. Gerard already defended the Symbios SCSI.

There may be some approaches to deal with the problem. One is to leave hash in and clean up the rest. It would probably break a number of devices and take a time to straighten out. Another possibility is to limit the number of URBs that are posted in any given time to the hardware.

Quoted 6 lines

That was my second argument, which you didn't reply to - that doing the reverse mapping is very simple on some platforms, and so the right place to do reverse mapping is in the platform-aware code, not in the drivers. On other platforms the reverse mapping is more complex, but the complexity is bounded by the complexity that is already there in drivers like the usb-ohci driver.

No, it's not bounded. Outside implementation has to be much more complex to accomodate slightly different requirements of different drivers.

And remember, you can put it in, but cannot pull it out.

-- Pete