Skip to contentSkip to conversation

printk loglevel cleanup (again)

PATCH Pete Zaitcev 4 participants 4 messages Nov 27, 2001 – Nov 28, 2001 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Linus refused wholesale cleanups in the past. Try to identify worst offenders and start from those, and work through component maintainers. It's a lot more work, but you have to tough it out.

-- Pete

Quoted 3 lines

When I was making this patch I couldn't resist and fixed messed up tabs around affected printks, wrapped some lines longer than 80 columns, fixed some typos.

#2 lore raw
In reply to a message not in the archive
Quoted 3 lines · Pete Zaitcev

Linus refused wholesale cleanups in the past. Try to identify worst offenders and start from those, and work through component maintainers. It's a lot more work, but you have to tough it out.

This patch can be split into individual patches right at any hunk boundary. I think any interested maintainer can take it and apply relevant parts (or as a whole, since their diffs for Linus are most probaly made only from relevant kernel subtrees (they won't propagate unwanted modifications))

Anyway, it's only printks.
--
vda

#3 lore raw

Small security bug with misconfigured access rights

Well, I don't know if it is really a bug.

Create a directory like this:

# ls -la
total 12
drwxr-sr-x   2 pochini  root         4096 Nov 28 16:33 .
drwxr-xr-x  32 pochini  users        8192 Nov 28 16:25 ..

Sgid bit is set and the directory is owned by me and the group is root (yes, it shouldn't be).

When I create a file here, it gets the root group even if I don't belong to it.

[kernel 2.4.5]

Bye.

#4 lore raw

Re: Small security bug with misconfigured access rights

Quoted 9 lines · Giuliano Pochini

Well, I don't know if it is really a bug.

Create a directory like this:

# ls -la
total 12
drwxr-sr-x   2 pochini  root         4096 Nov 28 16:33 .
drwxr-xr-x  32 pochini  users        8192 Nov 28 16:25 ..
Quoted 5 lines

Sgid bit is set and the directory is owned by me and the group is root (yes, it shouldn't be).

When I create a file here, it gets the root group even if I don't belong to it.

That's the correct behavior. Quoting "man mount":

grpid or bsdgroups / nogrpid or sysvgroups
These options define what group id a newly created file
gets. When
grpid is set, it takes the group id of the directory in
which it is
created; otherwise (the default) it takes the fsgid of the
current pro-
cess, unless the directory has the setgid bit set, in
which case it
takes the gid from the parent directory, and also gets the
setgid bit
set if it is a directory itself.

Jordan Russell