Skip to contentSkip to conversation

my review of the Device Driver Hardening Design Spec

DISCUSSION Pete Zaitcev 5 participants 9 messages Sep 21, 2002 – Sep 22, 2002 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 3 lines

- actually, what do any of these CONFIG_ options do, and why would someone not want the CONFIG_DRIVER_ROBUST to be always enabled?

Probably performance blows when it is enabled.

Quoted 7 lines

In summary, I think that a lot of people have spent a lot of time in creating this document, and the surrounding code that matches this document. I really wish that a tiny bit of that effort had gone into contacting the Linux kernel development community, and asking to work with them on a project like this. Due to that not happening, and by looking at the resultant spec and code, I'm really afraid the majority of that time and effort will have been wasted.

Eek. They never mentioned any code before now. In fact they explicitly said they weren't going to code before the spec was ready.

-- Pete

#2 lore raw
Quoted 9 lines · Pete Zaitcev
Quoted 8 lines

In summary, I think that a lot of people have spent a lot of time in creating this document, and the surrounding code that matches this document. I really wish that a tiny bit of that effort had gone into contacting the Linux kernel development community, and asking to work with them on a project like this. Due to that not happening, and by looking at the resultant spec and code, I'm really afraid the majority of that time and effort will have been wasted.

Quoted 3 lines

Eek. They never mentioned any code before now. In fact they explicitly said they weren't going to code before the spec was ready.

Oh, there's lots of code:
A "hardened" binary kernel driver:
http://unc.dl.sourceforge.net/sourceforge/hardeneddrivers/sampledriver-0.1-1.i386.rpm
(um people, why a binary? Where's the source for this?)

Some header files:
http://unc.dl.sourceforge.net/sourceforge/hardeneddrivers/ddhardening_headerfiles.tar.gz

A bunch of diagnostics code:
http://linux-diag.sourceforge.net/code/cpu_affinity-v0.2.1.tar.gz
http://linux-diag.sourceforge.net/code/pmem-0.2.1.tar.gz
http://linux-diag.sourceforge.net/code/crms-0.1.1.tar.gz

And a bunch of resource monitoring code:
http://sourceforge.net/project/showfiles.php?group_id=54710

CG people, are you wanting any of this code to be in the main kernel? If so, why have you not submitted it to anyone yet? And why did you write any code before the spec was ready if you said you were not going to do that?

thanks,

greg k-h

#4 lore raw

Hello Francois , A suggestion for Documentation . Please produce output of Windows docs into non-propitary formats . txt , pfd , ps , ... Tia , JimL

Quoted 12 lines · Francois Romieu

[Cc list trimmed]

Greg KH <[email protected]> :
[...]

Quoted 4 lines

Oh, there's lots of code:
A "hardened" binary kernel driver:
http://unc.dl.sourceforge.net/sourceforge/hardeneddrivers/sampledriver-0.1-1.i386.rpm
(um people, why a binary? Where's the source for this?)

In the cvs. See:
http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/hardeneddrivers/sample_driver/src/

Quoted 8 lines

--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

       +------------------------------------------------------------------+
       | James   W.   Laferriere | System    Techniques | Give me VMS     |
       | Network        Engineer |     P.O. Box 854     |  Give me Linux  |
       | [email protected] | Coudersport PA 16915 |   only  on  AXP |
       +------------------------------------------------------------------+
#5 lore raw

Mr. James W. Laferriere <[email protected]> :
[...]

Quoted 3 lines

Hello Francois , A suggestion for Documentation . Please produce output of Windows docs into non-propitary formats . txt , pfd , ps , ... Tia , JimL

I don't remember having written a doc in proprietary format lately.

Signature · 1 line
Ueimor
#6 lore raw

Hello Francios , ... Hth , JimL

http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/hardeneddrivers/docs/DD_hardening_spec.doc

Quoted 6 lines · Francois Romieu

Mr. James W. Laferriere <[email protected]> :
[...]

Quoted 3 lines

Hello Francois , A suggestion for Documentation . Please produce output of Windows docs into non-propitary formats . txt , pfd , ps , ... Tia , JimL

I don't remember having written a doc in proprietary format lately.

       +------------------------------------------------------------------+
       | James   W.   Laferriere | System    Techniques | Give me VMS     |
       | Network        Engineer |     P.O. Box 854     |  Give me Linux  |
       | [email protected] | Coudersport PA 16915 |   only  on  AXP |
       +------------------------------------------------------------------+
#7 lore raw

Hello Francois , found the pdf of the same doc I beleive .
Tia , JimL

Quoted 19 lines · Mr. James W. Laferriere

Hello Francios , ... Hth , JimL

http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/hardeneddrivers/docs/DD_hardening_spec.doc

Quoted 6 lines · Francois Romieu

Mr. James W. Laferriere <[email protected]> :
[...]

Quoted 3 lines

Hello Francois , A suggestion for Documentation . Please produce output of Windows docs into non-propitary formats . txt , pfd , ps , ... Tia , JimL

I don't remember having written a doc in proprietary format lately.

       +------------------------------------------------------------------+
       | James   W.   Laferriere | System    Techniques | Give me VMS     |
       | Network        Engineer |     P.O. Box 854     |  Give me Linux  |
       | [email protected] | Coudersport PA 16915 |   only  on  AXP |
       +------------------------------------------------------------------+
Quoted 6 lines

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

       +------------------------------------------------------------------+
       | James   W.   Laferriere | System    Techniques | Give me VMS     |
       | Network        Engineer |     P.O. Box 854     |  Give me Linux  |
       | [email protected] | Coudersport PA 16915 |   only  on  AXP |
       +------------------------------------------------------------------+
#8 lore raw
In reply to Francois Romieu
Quoted 11 lines · Francois Romieu

[Cc list trimmed]

Greg KH <[email protected]> :
[...]

Quoted 4 lines

Oh, there's lots of code:
A "hardened" binary kernel driver:
http://unc.dl.sourceforge.net/sourceforge/hardeneddrivers/sampledriver-0.1-1.i386.rpm
(um people, why a binary? Where's the source for this?)

In the cvs. See:
http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/hardeneddrivers/sample_driver/src/

Thanks for pointing this out, I missed it.

Hm, if this is the code that the CG group is proposing for reliable drivers, we are all in trouble. See:
http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/*checkout*/hardeneddrivers/sample_driver/src/sampledriver.h?rev=1.1.1.1

as a very small example of what not to do :)

I'd be glad to provide concrete criticism of the other files in this directory, if I thought people would actually change their programming style to follow what their own spec says to do...

{sigh}

http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/*checkout*/hardeneddrivers/sample_driver/src/sampledriver_init.c?rev=1.1.1.1
contains so many examples of bad style, and real bugs...

greg k-h

#9 lore raw

#ifndef __MYDRVR_H__
#define __MYDRVR_H__

#define MYDRVR_IOCTL_MAGIC 'm'

#define MYDRVR_IOCTL_RCV _IO(MYDRVR_IOCTL_MAGIC, 0)

typedef struct _MYDRVR_CONTEXT {

unsigned long cRCV; /* number of RCV ioctls made */ unsigned long cDeviceOpen; /* device open count */

} MYDRVR_CONTEXT, *PMYDRVR_CONTEXT;

#define ZEROMEMORY(pAddr, cbSize)               \
{                                               \
    int i;                                      \
    char *d = (char *)(pAddr);                  \
    for ( i = 0; i < (cbSize); i++, *d++ = 0 ); \
}

#endif /* __MYDRVR_H__ */

SHEESH, COULD THEY LEARN THERE IS MORE TO LIFE THAN ALL CAPS??

Sweet, that is "stick ugly"!

stick ugly : beating with a stick and it can not made any uglier than it
is presently.

Andre Hedrick
LAD Storage Consulting Group

Quoted 37 lines · Greg KH
Quoted 11 lines · Francois Romieu

[Cc list trimmed]

Greg KH <[email protected]> :
[...]

Quoted 4 lines

Oh, there's lots of code:
A "hardened" binary kernel driver:
http://unc.dl.sourceforge.net/sourceforge/hardeneddrivers/sampledriver-0.1-1.i386.rpm
(um people, why a binary? Where's the source for this?)

In the cvs. See:
http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/hardeneddrivers/sample_driver/src/

Thanks for pointing this out, I missed it.

Hm, if this is the code that the CG group is proposing for reliable drivers, we are all in trouble. See:
http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/*checkout*/hardeneddrivers/sample_driver/src/sampledriver.h?rev=1.1.1.1

as a very small example of what not to do :)

I'd be glad to provide concrete criticism of the other files in this directory, if I thought people would actually change their programming style to follow what their own spec says to do...

{sigh}

http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/*checkout*/hardeneddrivers/sample_driver/src/sampledriver_init.c?rev=1.1.1.1
contains so many examples of bad style, and real bugs...

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/