Skip to contentSkip to conversation

interrupt.h needs <asm/system.h>

PATCH Pete Zaitcev 1 participant 1 message Nov 18, 2002 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

include/linux/interrupt.h line 14

Quoted 13 lines

<asm/system.h> is needed for smp_mb(). Apparently this definition is pulled in some other way on ia32.

include/linux/interrupt.h +1 -0
@@ -8,6 +8,7 @@
 #include <asm/hardirq.h>
 #include <asm/ptrace.h>
 #include <asm/softirq.h>
+#include <asm/system.h>
 
 struct irqaction {
 	void (*handler)(int, void *, struct pt_regs *);

Geert's patch looks correct to me.

By the way, I am curious, why do we never comment why a header was included, like so: "#include <asm/system.h> /* smp_mb */"? I suspect people are afraid that the comments get stale.

-- Pete