Skip to contentSkip to conversation

typo in drivers/usb/class/usblp.c (resend)

PATCH Pete Zaitcev 1 participant 1 message May 25, 2004 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

On Mon, 24 May 2004 12:11:29 +0200

Review

Quoted 7 lines

i think there's a typo error in usblp.c

if (~status & LP_PERRORP)
newerr = 3;

(quoted diff) +1 -1
-       if (status & LP_POUTPA)
+       if (~status & LP_POUTPA)
                newerr = 1;

This is not a typo. Please refer to the USP Printer Class Specification, chapter 4.2.2 "GET_PORT_STATUS (bRequest = 1)". Bit mask 0x20 consitutes a one-bit field "Paper Emtpy", with values: 1 = Paper Empty, 0 = Paper Not Empty.

-- Pete