Skip to contentSkip to conversation

Backport of a 2.6.x USB driver to 2.4.32 - help needed

DISCUSSION Pete Zaitcev 2 participants 2 messages Jun 9, 2006 – Jun 14, 2006 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 9 lines · Heiko Gerstung

[...] The maintainer of the driver
modified a few things for me in order to address this problem ("it happens because get/set_registers() are called with no process context"), but he was only able to modify the 2.6.x driver for me.

I started to backport the modified version, but it seems that I ran into dependency hell because I get the following two missing functions reported when I try to compile the backported module:

Quoted 5 lines

rtl8150.c: In Funktion »rtl8150_get_settings«:
rtl8150.c:790: Warnung: implicit declaration of function `in_atomic' rtl8150.c: In Funktion »rtl8150_thread«:
rtl8150.c:857: Warnung: implicit declaration of function `schedule_timeout_uninterruptible'

Tell the author to do it differently. Drivers have no business to call in_atomic(). So, he postpones some accesses until later. This is an easy way out, I did it myself in 2.4's usb-serial, but it's wrong. I don't see what his excuse is. Mine was that I didn't want to debug a freaking gazillion of usb-storage subdrivers.

Who's the guy, anyway? Was it Petkan? I'm sure he'll listen to reason, I worked with him before.

I'm going to keep an eye on rtl8150 and oppose in_atomic when it sneaks in.

-- Pete

#2 lore raw

Hi, Pete:

Quoted 17 lines · Pete Zaitcev
Quoted 9 lines · Heiko Gerstung

[...] The maintainer of the driver
modified a few things for me in order to address this problem ("it happens because get/set_registers() are called with no process context"), but he was only able to modify the 2.6.x driver for me.

I started to backport the modified version, but it seems that I ran into dependency hell because I get the following two missing functions reported when I try to compile the backported module:

Quoted 5 lines

rtl8150.c: In Funktion »rtl8150_get_settings«:
rtl8150.c:790: Warnung: implicit declaration of function `in_atomic' rtl8150.c: In Funktion »rtl8150_thread«:
rtl8150.c:857: Warnung: implicit declaration of function `schedule_timeout_uninterruptible'

Quoted 6 lines

Tell the author to do it differently. Drivers have no business to call in_atomic(). So, he postpones some accesses until later. This is an easy way out, I did it myself in 2.4's usb-serial, but it's wrong. I don't see what his excuse is. Mine was that I didn't want to debug a freaking gazillion of usb-storage subdrivers.

His "excuse" is that he simply has not enough time to "do it right"(tm), he just wanted to help me with a quick workaround.

Quoted 2 lines

Who's the guy, anyway? Was it Petkan? I'm sure he'll listen to reason, I worked with him before.

Yes, it's Petko and I know that he is a good coder and just wanted to help me out, although he was busy with projects he gets paid for.

Quoted 2 lines

I'm going to keep an eye on rtl8150 and oppose in_atomic when it sneaks in.

Don't worry, I was not able to resolve the problems I got by working around other problems. We will have to check if there is another solution for our product as we have no chance to use a 2.4 kernel anymore.

Kind regards,
Heiko

Quoted 2 lines

-- Pete

Signature · 13 lines
------------------------------------------------------------------------

*MEINBERG Funkuhren GmbH & Co. KG*
Auf der Landwehr 22
D-31812 Bad Pyrmont, Germany
Tel.: ++49 (0)5281 9309-25
Fax: ++49 (0)5281 9309-30
eMail: [email protected] <mailto:[email protected]>
Internet: www.meinberg.de <http://www.meinberg.de/>

------------------------------------------------------------------------

Meinberg radio clocks: 25 years of accurate time worldwide