Skip to contentSkip to conversation

No subject

DISCUSSION [email protected] 1 participant 1 message Jan 23, 2009

lore
Share & tools
lore
#0 lore raw

disabling it. Is it correct ?

Review

Quoted 7 lines
(quoted diff) +7 -0
+
+	res = eth_getenv_enetaddr("ethaddr", dev->enetaddr);
+	if (!res) {
+		puts("Please set your MAC address!");
+		free(dev);
+		return 0;
+	}

This is wrong. A network driver should not call directly eth_getenv_enetaddr, and you do not need. If you want to check the mac addrsss, use is_valid_ether_addr() inside ax88783_init() before copying the mac to the hardware.

Review

Quoted 2 lines
(quoted diff) +2 -0
+
+	res = ax88183_phy_initial(dev);

Name must be changed.

drivers/net/ax88783.h line 2

Quoted 8 lines
drivers/net/ax88783.h new file +2 -0
new file mode 100644
index 0000000..09ac9ed
@@ -0,0 +1,100 @@
+/*
+ *

As explained, all headers start with copyright on the second line. Drop this line.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================