Skip to contentSkip to conversation

No subject

DISCUSSION [email protected] 1 participant 1 message Jan 23, 2009

lore
Share & tools
lore
#0 lore raw

loaded by coreboot on the chromebook, and it's likely that other coreboot motherboards may want to do the same. Therefore can you change:
board/chromebook-x86/coreboot
to:
board/coreboot/chromebook-x86/

Regarding the empty functions, I know they are required to keep the linker happy. I see two options:

1) #ifdef the call sites
2) create weak stubs

I'm open to debate on the preferred approach

Regards,

Graeme

Quoted 20 lines

Gabe

On Fri, Nov 4, 2011 at 3:24 PM, Mike Frysinger <[email protected] <mailto:[email protected]>> wrote:

i'm not terribly familiar with what it takes to make an x86 board, but i don't
see anything jumping out of this patch.

i would note however that you should merge the boards.cfg update into this patch. merging one or the other doesn't make much sense, and there's no reason to keep them split.

> +void setup_pcat_compatibility()

should be "(void)"
-mike