Skip to contentSkip to conversation

Policy on Tools Posting

DISCUSSION Wilfred Smith 5 participants 6 messages Aug 15, 2019 – Aug 19, 2019 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

My manager (Sai) is asking whether there is precedence for having utilities posted outside the OpenBMC repository. Do we want 100 OpenBMC tools repositories, each managed differently or 1 harmonized repository?

Separately, is there any effort to create a “common core” for OpenBMC such that an effort akin to POSIX or the Single UNIX Specification isn’t needed ten years from now? Without standard API (or at least abstracted tools) for things like where FRU information is located or sending IPMB commands, isn’t the market for innovative software stifled (Android software market vs iOS, or even Linux vs Windows)?

Wilfred

Quoted 631 lines · On Aug 15, 2019, at 12:41 PM, [email protected] wrote:

Send openbmc mailing list submissions to
[email protected]

To subscribe or unsubscribe via the World Wide Web, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.ozlabs.org_listinfo_openbmc&d=DwICAg&c=5VD0RTtNlTh3ycd41b3MUw&r=-ektT-tD9zf2rfUisE63RqiDagGyhGey2hbEGa-47kc&m=CsXIqDLC_9ZYrVSwNllcHo7GjqAG9mj2S6NymPQTblk&s=_RrYmmMf-6XU6r5LsXsWLj8G0K_qaWyo6K2yDU5JGu8&e=
or, via email, send a message with subject or body 'help' to
[email protected]

You can reach the person managing the list at
[email protected]

When replying, please edit your Subject line so it is more specific than "Re: Contents of openbmc digest..."

Today's Topics:

1. Re: Policy on Tools Posting (Vijay Khemka)
2. [PATCH dev-5.2] fsi: scom: Don't abort operations for minor errors (Eddie James)
3. Re: [PATCH] net/ncsi: Ensure 32-bit boundary for data cksum (David Miller)
4. Re: [PATCH v4 2/2] hwmon: pmbus: Add Inspur Power System power supply driver (Guenter Roeck)

----------------------------------------------------------------------

Message: 1
Date: Thu, 15 Aug 2019 19:07:26 +0000
From: Vijay Khemka <[email protected]>
To: Andrew Geissler <[email protected]>, Wilfred Smith
<[email protected]>
Cc: "[email protected]" <[email protected]>
Subject: Re: Policy on Tools Posting
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"

?On 8/15/19, 5:59 AM, "openbmc on behalf of Andrew Geissler" <[email protected] on behalf of [email protected]> wrote:

Quoted 3 lines · Wilfred Smith

1. Are there guidelines/procedures specific to submitting command line tools and utilities? I have heard that there may be a repository and/or path dedicated to CLI tools.

The community has definitely tended to limit wrapper tools within OpenBMC. We had a discussion a while back that we're open to some but the API's to them really need to be thought out and reviewed because command line tools become customer API's (i.e. people start writing scripts on top of these tools that then become key to the manufacturing process or some other critical area).

Anything that goes into OpenBMC needs to support OpenBMC interfaces. For example, I'm not familiar with fruid-util's D-bus service xyz.openbmc_project.FruDevice. A "busctl tree xyz.openbmc_project.Inventory.Manager | cat" shows the inventory items on OpenBMC.

One issue we have within OpenBMC is there may be different implementations of the D-bus API's for a given area. For example, Inventory has different implementations so I'm not sure which repo would best fit your tool. That type of issue leads me to wonder if we should put the tools with the interface definitions in openbmc/phosphor-dbus-interfaces? Or maybe a separate phosphor-tools repo would be more logical for these.
Andrew, I like the idea of having phosphor-tools which can be a placeholder for any commandline tools and can grow as per requirement. Currently it can start with 3 proposed tools.

Either way, I think command line tools should each get their own mini-design doc
(https://github.com/openbmc/docs/blob/master/designs/design-template.md)
Wilfred, Can you please create a document as per this design template and submit for review.

with requirements and interfaces clearly defined for review by the community. If we can find a generic tool that multiple people find useful, we can then find a place to put it. Otherwise, you could host your tools outside of openbmc/ github and just pull them into recipes from within your meta-facebook layer.

Quoted 3 lines

Thanks in advance,

Wilfred

------------------------------

Message: 2
Date: Thu, 15 Aug 2019 14:11:03 -0500
From: Eddie James <[email protected]>
To: [email protected]
Cc: [email protected], Eddie James <[email protected]>
Subject: [PATCH dev-5.2] fsi: scom: Don't abort operations for minor
errors
Message-ID: <[email protected]>

The scom driver currently fails out of operations if certain system errors are flagged in the status register; system checkstop, special attention, or recoverable error. These errors won't impact the ability of the scom engine to perform operations, so the driver should continue under these conditions.
Also, don't do a PIB reset for these conditions, since it won't help.

---
drivers/fsi/fsi-scom.c | 8 +-------

1 file changed, 1 insertion(+), 7 deletions(-)
drivers/fsi/fsi-scom.c +1 -7
index 343153d..004dc03 100644
@@ -38,8 +38,7 @@
 #define SCOM_STATUS_PIB_RESP_MASK	0x00007000
 #define SCOM_STATUS_PIB_RESP_SHIFT	12
 
-#define SCOM_STATUS_ANY_ERR		(SCOM_STATUS_ERR_SUMMARY | \
-					 SCOM_STATUS_PROTECTION | \
+#define SCOM_STATUS_ANY_ERR		(SCOM_STATUS_PROTECTION | \
 					 SCOM_STATUS_PARITY |	  \
 					 SCOM_STATUS_PIB_ABORT | \
 					 SCOM_STATUS_PIB_RESP_MASK)
@@ -251,11 +250,6 @@ static int handle_fsi2pib_status(struct scom_device *scom, uint32_t status)
 	/* Return -EBUSY on PIB abort to force a retry */
 	if (status & SCOM_STATUS_PIB_ABORT)
 		return -EBUSY;
-	if (status & SCOM_STATUS_ERR_SUMMARY) {
-		fsi_device_write(scom->fsi_dev, SCOM_FSI2PIB_RESET_REG, &dummy,
-				 sizeof(uint32_t));
-		return -EIO;
-	}
 	return 0;
 }
 
Signature · 19 lines
1.8.3.1



------------------------------

Message: 3
Date: Thu, 15 Aug 2019 12:32:35 -0700 (PDT)
From: David Miller <[email protected]>
To: [email protected]
Cc: [email protected], [email protected],
	[email protected], [email protected],
	[email protected], [email protected]
Subject: Re: [PATCH] net/ncsi: Ensure 32-bit boundary for data cksum
Message-ID: <[email protected]>
Content-Type: Text/Plain; charset=us-ascii

From: "Terry S. Duncan" <[email protected]>
Date: Tue, 13 Aug 2019 18:18:40 -0700
Quoted 16 lines

The NCSI spec indicates that if the data does not end on a 32 bit boundary, one to three padding bytes equal to 0x00 shall be present to align the checksum field to a 32-bit boundary.

---

net/ncsi/internal.h |  1 +
net/ncsi/ncsi-cmd.c |  2 +-
net/ncsi/ncsi-rsp.c | 12 ++++++++----
3 files changed, 10 insertions(+), 5 deletions(-)
net/ncsi/internal.h +0 -0
index 0b3f0673e1a2..468a19fdfd88 100644

net/ncsi/internal.h struct ncsi_package; · line 188

Quoted 4 lines
net/ncsi/internal.h +1 -0
@@ -185,6 +185,7 @@ struct ncsi_package;
 #define NCSI_TO_CHANNEL(p, c)	(((p) << NCSI_PACKAGE_SHIFT) | (c))
 #define NCSI_MAX_PACKAGE	8
 #define NCSI_MAX_CHANNEL	32
+#define NCSI_ROUND32(x)		(((x) + 3) & ~3) /* Round to 32 bit boundary */

I think we have enough of a proliferation of alignment macros, let's not add more.

Either define this to "ALIGN(x, 4)" or expand that into each of the locations:

net/ncsi/internal.h struct ncsi_package; · line 190

Quoted 3 lines
net/ncsi/internal.h +1 -1
 	pchecksum = (__be32 *)((void *)h + sizeof(struct ncsi_pkt_hdr) +
-		    nca->payload);
+		    NCSI_ROUND32(nca->payload));
		     ALIGN(nca->payload, 4)

net/ncsi/internal.h struct ncsi_package; · line 191

Quoted 2 lines
net/ncsi/internal.h +1 -1
-	pchecksum = (__be32 *)((void *)(h + 1) + payload - 4);
+	pchecksum = (__be32 *)((void *)(h + 1) + NCSI_ROUND32(payload) - 4);

ALIGN(payload, 4)

etc.

------------------------------

Message: 4
Date: Thu, 15 Aug 2019 12:41:02 -0700
From: Guenter Roeck <[email protected]>
To: Vijay Khemka <[email protected]>
Cc: John Wang <[email protected]>, "[email protected]"

	<[email protected]>, "[email protected]" <[email protected]>,
	"[email protected]" <[email protected]>,
	"[email protected]" <[email protected]>,
	"[email protected]" <[email protected]>,
	"[email protected]" <[email protected]>,
	"[email protected]" <[email protected]>,
	"[email protected]" <[email protected]>, "[email protected]"
	<[email protected]>

Subject: Re: [PATCH v4 2/2] hwmon: pmbus: Add Inspur Power System
power supply driver
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8

Quoted 348 lines · Vijay Khemka

?On 8/13/19, 1:36 AM, "openbmc on behalf of John Wang" <[email protected] on behalf of [email protected]> wrote:

Add the driver to monitor Inspur Power System power supplies with hwmon over pmbus.

This driver adds sysfs attributes for additional power supply data, including vendor, model, part_number, serial number, firmware revision, hardware revision, and psu mode(active/standby).

---
v4:
- Remove the additional tabs in the Makefile
- Rebased on 5.3-rc4, not 5.2
v3:
- Sort kconfig/makefile entries alphabetically
- Remove unnecessary initialization
- Use ATTRIBUTE_GROUPS instead of expanding directly
- Use memscan to avoid reimplementation
v2:
- Fix typos in commit message
- Invert Christmas tree
- Configure device with sysfs attrs, not debugfs entries
- Fix errno in fw_version_read, ENODATA to EPROTO
- Change the print format of fw-version
- Use sysfs_streq instead of strcmp("xxx" "\n", "xxx")
- Document sysfs attributes
---

    Documentation/hwmon/inspur-ipsps1.rst |  79 +++++++++
    drivers/hwmon/pmbus/Kconfig           |   9 +
    drivers/hwmon/pmbus/Makefile          |   1 +
    drivers/hwmon/pmbus/inspur-ipsps.c    | 226 ++++++++++++++++++++++++++
    4 files changed, 315 insertions(+)

create mode 100644 Documentation/hwmon/inspur-ipsps1.rst create mode 100644 drivers/hwmon/pmbus/inspur-ipsps.c

   diff --git a/Documentation/hwmon/inspur-ipsps1.rst b/Documentation/hwmon/inspur-ipsps1.rst
   new file mode 100644
   index 000000000000..aa19f0ccc8b0
   --- /dev/null
   +++ b/Documentation/hwmon/inspur-ipsps1.rst
   @@ -0,0 +1,79 @@
   +Kernel driver inspur-ipsps1
   +=======================
   +
   +Supported chips:
   +
   +  * Inspur Power System power supply unit
   +
   +Author: John Wang <[email protected]>
   +
   +Description
   +-----------
   +
   +This driver supports Inspur Power System power supplies. This driver
   +is a client to the core PMBus driver.
   +
   +Usage Notes
   +-----------
   +
   +This driver does not auto-detect devices. You will have to instantiate the
   +devices explicitly. Please see Documentation/i2c/instantiating-devices for
   +details.
   +
   +Sysfs entries
   +-------------
   +
   +The following attributes are supported:
   +
   +======================= ======================================================
   +curr1_input             Measured input current
   +curr1_label             "iin"
   +curr1_max               Maximum current
   +curr1_max_alarm         Current high alarm
   +curr2_input		Measured output current in mA.
   +curr2_label		"iout1"
   +curr2_crit              Critical maximum current
   +curr2_crit_alarm        Current critical high alarm
   +curr2_max               Maximum current
   +curr2_max_alarm         Current high alarm
   +

Please align above details.
+fan1_alarm Fan 1 warning.
+fan1_fault Fan 1 fault.
+fan1_input Fan 1 speed in RPM.
+
+in1_alarm Input voltage under-voltage alarm.
+in1_input Measured input voltage in mV.
+in1_label "vin"
+in2_input Measured output voltage in mV.
+in2_label "vout1"

   +in2_lcrit               Critical minimum output voltage
   +in2_lcrit_alarm         Output voltage critical low alarm
   +in2_max                 Maximum output voltage
   +in2_max_alarm           Output voltage high alarm
   +in2_min                 Minimum output voltage
   +in2_min_alarm           Output voltage low alarm

+
+power1_alarm Input fault or alarm.
+power1_input Measured input power in uW.
+power1_label "pin"
+power1_max Input power limit
+power2_max_alarm Output power high alarm
+power2_max Output power limit
+power2_input Measured output power in uW.
+power2_label "pout"
+
Same alignment issue in description.
+temp[1-3]_input Measured temperature
+temp[1-2]_max Maximum temperature
+temp[1-3]_max_alarm Temperature high alarm
+

   +vendor                  Manufacturer name
   +model                   Product model
   +part_number             Product part number
   +serial_number           Product serial number
   +fw_version              Firmware version
   +hw_version              Hardware version
   +mode                    Work mode. Can be set to active or
   +                        standby, when set to standby, PSU will
   +                        automatically switch between standby
   +                        and redundancy mode.

+======================= ====================================================== diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig index b6588483fae1..d62d69bb7e49 100644
--- a/drivers/hwmon/pmbus/Kconfig
+++ b/drivers/hwmon/pmbus/Kconfig
@@ -46,6 +46,15 @@ config SENSORS_IBM_CFFPS
This driver can also be built as a module. If so, the module will be called ibm-cffps.

   +config SENSORS_INSPUR_IPSPS
   +	tristate "INSPUR Power System Power Supply"
   +	help
   +	  If you say yes here you get hardware monitoring support for the INSPUR
   +	  Power System power supply.
   +
   +	  This driver can also be built as a module. If so, the module will
   +	  be called inspur-ipsps.
   +
    config SENSORS_IR35221
    	tristate "Infineon IR35221"
    	help
   diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile
   index c950ea9a5d00..03bacfcfd660 100644
   --- a/drivers/hwmon/pmbus/Makefile
   +++ b/drivers/hwmon/pmbus/Makefile
   @@ -7,6 +7,7 @@ obj-$(CONFIG_PMBUS)		+= pmbus_core.o
    obj-$(CONFIG_SENSORS_PMBUS)	+= pmbus.o
    obj-$(CONFIG_SENSORS_ADM1275)	+= adm1275.o
    obj-$(CONFIG_SENSORS_IBM_CFFPS)	+= ibm-cffps.o
   +obj-$(CONFIG_SENSORS_INSPUR_IPSPS) += inspur-ipsps.o
    obj-$(CONFIG_SENSORS_IR35221)	+= ir35221.o
    obj-$(CONFIG_SENSORS_IR38064)	+= ir38064.o
    obj-$(CONFIG_SENSORS_IRPS5401)	+= irps5401.o
   diff --git a/drivers/hwmon/pmbus/inspur-ipsps.c b/drivers/hwmon/pmbus/inspur-ipsps.c
   new file mode 100644
   index 000000000000..fa981b881a60
   --- /dev/null
   +++ b/drivers/hwmon/pmbus/inspur-ipsps.c
   @@ -0,0 +1,226 @@
   +// SPDX-License-Identifier: GPL-2.0-or-later
   +/*
   + * Copyright 2019 Inspur Corp.
   + */
   +
   +#include <linux/debugfs.h>
   +#include <linux/device.h>
   +#include <linux/fs.h>
   +#include <linux/i2c.h>
   +#include <linux/module.h>
   +#include <linux/pmbus.h>
   +#include <linux/hwmon-sysfs.h>
   +
   +#include "pmbus.h"
   +
   +#define IPSPS_REG_VENDOR_ID	0x99
   +#define IPSPS_REG_MODEL		0x9A
   +#define IPSPS_REG_FW_VERSION	0x9B
   +#define IPSPS_REG_PN		0x9C
   +#define IPSPS_REG_SN		0x9E
   +#define IPSPS_REG_HW_VERSION	0xB0
   +#define IPSPS_REG_MODE		0xFC
   +
   +#define MODE_ACTIVE		0x55
   +#define MODE_STANDBY		0x0E
   +#define MODE_REDUNDANCY		0x00
   +
   +#define MODE_ACTIVE_STRING		"active"
   +#define MODE_STANDBY_STRING		"standby"
   +#define MODE_REDUNDANCY_STRING		"redundancy"
   +
   +enum ipsps_index {
   +	vendor,
   +	model,
   +	fw_version,
   +	part_number,
   +	serial_number,
   +	hw_version,
   +	mode,
   +	num_regs,
   +};
   +
   +static const u8 ipsps_regs[num_regs] = {
   +	[vendor] = IPSPS_REG_VENDOR_ID,
   +	[model] = IPSPS_REG_MODEL,
   +	[fw_version] = IPSPS_REG_FW_VERSION,
   +	[part_number] = IPSPS_REG_PN,
   +	[serial_number] = IPSPS_REG_SN,
   +	[hw_version] = IPSPS_REG_HW_VERSION,
   +	[mode] = IPSPS_REG_MODE,
   +};
   +
   +static ssize_t ipsps_string_show(struct device *dev,
   +				 struct device_attribute *devattr,
   +				 char *buf)
   +{
   +	u8 reg;
   +	int rc;
   +	char *p;
   +	char data[I2C_SMBUS_BLOCK_MAX + 1];
   +	struct i2c_client *client = to_i2c_client(dev->parent);
   +	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
   +
   +	reg = ipsps_regs[attr->index];
   +	rc = i2c_smbus_read_block_data(client, reg, data);
   +	if (rc < 0)
   +		return rc;
   +
   +	/* filled with printable characters, ending with # */
   +	p = memscan(data, '#', rc);
   +	*p = '\0';
   +
   +	return snprintf(buf, PAGE_SIZE, "%s\n", data);
   +}
   +
   +static ssize_t ipsps_fw_version_show(struct device *dev,
   +				     struct device_attribute *devattr,
   +				     char *buf)
   +{
   +	u8 reg;
   +	int rc;
   +	u8 data[I2C_SMBUS_BLOCK_MAX] = { 0 };
   +	struct i2c_client *client = to_i2c_client(dev->parent);
   +	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
   +
   +	reg = ipsps_regs[attr->index];
   +	rc = i2c_smbus_read_block_data(client, reg, data);
   +	if (rc < 0)
   +		return rc;
   +
   +	if (rc != 6)
   +		return -EPROTO;
   +
   +	return snprintf(buf, PAGE_SIZE, "%u.%02u%u-%u.%02u\n",
   +			data[1], data[2]/* < 100 */, data[3]/*< 10*/,
   +			data[4], data[5]/* < 100 */);
   +}
   +
   +static ssize_t ipsps_mode_show(struct device *dev,
   +			       struct device_attribute *devattr, char *buf)
   +{
   +	u8 reg;
   +	int rc;
   +	struct i2c_client *client = to_i2c_client(dev->parent);
   +	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
   +
   +	reg = ipsps_regs[attr->index];
   +	rc = i2c_smbus_read_byte_data(client, reg);
   +	if (rc < 0)
   +		return rc;
   +
   +	switch (rc) {
   +	case MODE_ACTIVE:
   +		return snprintf(buf, PAGE_SIZE, "[%s] %s %s\n",
   +				MODE_ACTIVE_STRING,
   +				MODE_STANDBY_STRING, MODE_REDUNDANCY_STRING);
   +	case MODE_STANDBY:
   +		return snprintf(buf, PAGE_SIZE, "%s [%s] %s\n",
   +				MODE_ACTIVE_STRING,
   +				MODE_STANDBY_STRING, MODE_REDUNDANCY_STRING);
   +	case MODE_REDUNDANCY:
   +		return snprintf(buf, PAGE_SIZE, "%s %s [%s]\n",
   +				MODE_ACTIVE_STRING,
   +				MODE_STANDBY_STRING, MODE_REDUNDANCY_STRING);
   +	default:
   +		return snprintf(buf, PAGE_SIZE, "unspecified\n");
   +	}
   +}
   +
   +static ssize_t ipsps_mode_store(struct device *dev,
   +				struct device_attribute *devattr,
   +				const char *buf, size_t count)
   +{
   +	u8 reg;
   +	int rc;
   +	struct i2c_client *client = to_i2c_client(dev->parent);
   +	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
   +
   +	reg = ipsps_regs[attr->index];
   +	if (sysfs_streq(MODE_STANDBY_STRING, buf)) {
   +		rc = i2c_smbus_write_byte_data(client, reg,
   +					       MODE_STANDBY);
   +		if (rc < 0)
   +			return rc;
   +		return count;
   +	} else if (sysfs_streq(MODE_ACTIVE_STRING, buf)) {
   +		rc = i2c_smbus_write_byte_data(client, reg,
   +					       MODE_ACTIVE);
   +		if (rc < 0)
   +			return rc;
   +		return count;
   +	}
   +
   +	return -EINVAL;
   +}
   +
   +static SENSOR_DEVICE_ATTR_RO(vendor, ipsps_string, vendor);
   +static SENSOR_DEVICE_ATTR_RO(model, ipsps_string, model);
   +static SENSOR_DEVICE_ATTR_RO(part_number, ipsps_string, part_number);
   +static SENSOR_DEVICE_ATTR_RO(serial_number, ipsps_string, serial_number);
   +static SENSOR_DEVICE_ATTR_RO(hw_version, ipsps_string, hw_version);
   +static SENSOR_DEVICE_ATTR_RO(fw_version, ipsps_fw_version, fw_version);
   +static SENSOR_DEVICE_ATTR_RW(mode, ipsps_mode, mode);
   +
   +static struct attribute *ipsps_attrs[] = {
   +	&sensor_dev_attr_vendor.dev_attr.attr,
   +	&sensor_dev_attr_model.dev_attr.attr,
   +	&sensor_dev_attr_part_number.dev_attr.attr,
   +	&sensor_dev_attr_serial_number.dev_attr.attr,
   +	&sensor_dev_attr_hw_version.dev_attr.attr,
   +	&sensor_dev_attr_fw_version.dev_attr.attr,
   +	&sensor_dev_attr_mode.dev_attr.attr,
   +	NULL,
   +};
   +
   +ATTRIBUTE_GROUPS(ipsps);
   +
   +static struct pmbus_driver_info ipsps_info = {
   +	.pages = 1,
   +	.func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_VOUT | PMBUS_HAVE_IOUT |
   +		PMBUS_HAVE_IIN | PMBUS_HAVE_POUT | PMBUS_HAVE_PIN |
   +		PMBUS_HAVE_FAN12 | PMBUS_HAVE_TEMP | PMBUS_HAVE_TEMP2 |
   +		PMBUS_HAVE_TEMP3 | PMBUS_HAVE_STATUS_VOUT |
   +		PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_STATUS_INPUT |
   +		PMBUS_HAVE_STATUS_TEMP | PMBUS_HAVE_STATUS_FAN12,
Quoted 1 line

This can be dynamic read by chip identify function

PMBUS_SKIP_STATUS_CHECK weakens auto-detetcion to some degree, and auto-detection takes time since it needs to poll all registers to determine if they exist. I don't mind if you insist, but I don't immediately see the benefits.

Quoted 11 lines
   +	.groups = ipsps_groups,
   +};
   +
   +static struct pmbus_platform_data ipsps_pdata = {
   +	.flags = PMBUS_SKIP_STATUS_CHECK,
   +};
   +
   +static int ipsps_probe(struct i2c_client *client,
   +		       const struct i2c_device_id *id)
   +{
   +	client->dev.platform_data = &ipsps_pdata;
Quoted 1 line

Allocate memory for this platform data inside tis function rather than having global variable.

Does that have any value other than consuming more memory if there are multiple instances of the driver ?

Quoted 24 lines
   +	return pmbus_do_probe(client, id, &ipsps_info);
   +}
   +
   +static const struct i2c_device_id ipsps_id[] = {
   +	{ "inspur_ipsps1", 0 },
   +	{}
   +};
   +MODULE_DEVICE_TABLE(i2c, ipsps_id);
   +
   +static const struct of_device_id ipsps_of_match[] = {
   +	{ .compatible = "inspur,ipsps1" },
   +	{}
   +};
   +MODULE_DEVICE_TABLE(of, ipsps_of_match);
   +
   +static struct i2c_driver ipsps_driver = {
   +	.driver = {
   +		.name = "inspur-ipsps",
   +		.of_match_table = ipsps_of_match,
   +	},
   +	.probe = ipsps_probe,
   +	.remove = pmbus_do_remove,
   +	.id_table = ipsps_id,
   +};
Quoted 11 lines
   +
   +module_i2c_driver(ipsps_driver);
   +
   +MODULE_AUTHOR("John Wang");
   +MODULE_DESCRIPTION("PMBus driver for Inspur Power System power supplies");
   +MODULE_LICENSE("GPL");
   -- 
   2.17.1

End of openbmc Digest, Vol 48, Issue 81
***************************************

#2 lore raw
Quoted 3 lines · Wilfred Smith

My manager (Sai) is asking whether there is precedence for having utilities posted outside the OpenBMC repository. Do we want 100 OpenBMC tools repositories, each managed differently or 1 harmonized repository?

Separately, is there any effort to create a “common core” for OpenBMC such that an effort akin to POSIX or the Single UNIX Specification isn’t needed ten years from now? Without standard API (or at least abstracted tools) for things like where FRU information is located or sending IPMB commands, isn’t the market for innovative software stifled (Android software market vs iOS, or even Linux vs Windows)?

My view is to focus on enhancing the Redfish functions so that users of OpenBMC systems can do everything they need to without having use Secure Shell (ssh) or any of the command line utilities ssh can access (such as systemctl, busctl, or obmctool).  See some publicly-readable IBM discussion on this topic here: https://github.com/ibm-openbmc/dev/issues/612

Meanwhile, when us developers need to access the BMC via ssh, we are happy to use the existing command line utilities and don't see the need for any more.

I would prefer to see our energy focused on enhancements to Redfish and on utilities which use the Redfish APIs (akin to redfishtool).

- Joseph

Quoted 89 lines

Wilfred

Quoted 85 lines · On Aug 15, 2019, at 12:41 PM, [email protected] wrote:

Send openbmc mailing list submissions to
[email protected]

To subscribe or unsubscribe via the World Wide Web, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.ozlabs.org_listinfo_openbmc&d=DwICAg&c=5VD0RTtNlTh3ycd41b3MUw&r=-ektT-tD9zf2rfUisE63RqiDagGyhGey2hbEGa-47kc&m=CsXIqDLC_9ZYrVSwNllcHo7GjqAG9mj2S6NymPQTblk&s=_RrYmmMf-6XU6r5LsXsWLj8G0K_qaWyo6K2yDU5JGu8&e=
or, via email, send a message with subject or body 'help' to
[email protected]

You can reach the person managing the list at
[email protected]

When replying, please edit your Subject line so it is more specific than "Re: Contents of openbmc digest..."

Today's Topics:

1. Re: Policy on Tools Posting (Vijay Khemka)
2. [PATCH dev-5.2] fsi: scom: Don't abort operations for minor errors (Eddie James)
3. Re: [PATCH] net/ncsi: Ensure 32-bit boundary for data cksum (David Miller)
4. Re: [PATCH v4 2/2] hwmon: pmbus: Add Inspur Power System power supply driver (Guenter Roeck)

----------------------------------------------------------------------

Message: 1
Date: Thu, 15 Aug 2019 19:07:26 +0000
From: Vijay Khemka <[email protected]>
To: Andrew Geissler <[email protected]>, Wilfred Smith
<[email protected]>
Cc: "[email protected]" <[email protected]>
Subject: Re: Policy on Tools Posting
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"

?On 8/15/19, 5:59 AM, "openbmc on behalf of Andrew Geissler" <[email protected] on behalf of [email protected]> wrote:

Quoted 2 lines · Wilfred Smith

1. Are there guidelines/procedures specific to submitting command line tools and utilities? I have heard that there may be a repository and/or path dedicated to CLI tools.

The community has definitely tended to limit wrapper tools within OpenBMC. We had a discussion a while back that we're open to some but the API's to them really need to be thought out and reviewed because command line tools become customer API's (i.e. people start writing scripts on top of these tools that then become key to the manufacturing process or some other critical area).

Anything that goes into OpenBMC needs to support OpenBMC interfaces. For example, I'm not familiar with fruid-util's D-bus service xyz.openbmc_project.FruDevice. A "busctl tree xyz.openbmc_project.Inventory.Manager | cat" shows the inventory items on OpenBMC.

One issue we have within OpenBMC is there may be different implementations of the D-bus API's for a given area. For example, Inventory has different implementations so I'm not sure which repo would best fit your tool. That type of issue leads me to wonder if we should put the tools with the interface definitions in openbmc/phosphor-dbus-interfaces? Or maybe a separate phosphor-tools repo would be more logical for these.
Andrew, I like the idea of having phosphor-tools which can be a placeholder for any commandline tools and can grow as per requirement. Currently it can start with 3 proposed tools.

Either way, I think command line tools should each get their own mini-design doc
(https://github.com/openbmc/docs/blob/master/designs/design-template.md)
Wilfred, Can you please create a document as per this design template and submit for review.

with requirements and interfaces clearly defined for review by the community. If we can find a generic tool that multiple people find useful, we can then find a place to put it. Otherwise, you could host your tools outside of openbmc/ github and just pull them into recipes from within your meta-facebook layer.

Quoted 3 lines

Thanks in advance,

Wilfred

...snip...

#3 lore raw
Quoted 5 lines · Joseph Reynolds
Quoted 2 lines · Wilfred Smith

My manager (Sai) is asking whether there is precedence for having utilities posted outside the OpenBMC repository. Do we want 100 OpenBMC tools repositories, each managed differently or 1 harmonized repository?

Quoted 7 lines
Quoted 1 line

Separately, is there any effort to create a “common core” for OpenBMC such that an effort akin to POSIX or the Single UNIX Specification isn’t needed ten years from now? Without standard API (or at least abstracted tools) for things like where FRU information is located or sending IPMB commands, isn’t the market for innovative software stifled (Android software market vs iOS, or even Linux vs Windows)?

My view is to focus on enhancing the Redfish functions so that users of OpenBMC systems can do everything they need to without having use Secure Shell (ssh) or any of the command line utilities ssh can access (such as systemctl, busctl, or obmctool). See some publicly-readable IBM discussion on this topic here: https://github.com/ibm-openbmc/dev/issues/612

Once a system has shipped to a customer, ensuring 99% of what they need to use that server is available via Redfish definitely makes sense to me.

Quoted 3 lines

Meanwhile, when us developers need to access the BMC via ssh, we are happy to use the existing command line utilities and don't see the need for any more.

Hmm, I don't think I agree with this. I think obmcutil has provided a lot of useful
abstraction for developers and users of OpenBMC (like our lab team). No one really wants to remember some of the long cumbersome commands done by obmcutil, nor do they want to deal with situations where we change the underlying D-bus API in a certain version of firmware. obmcutil provides a nice abstraction to that and I could see tools that provide abstractions for looking at error logs or listing system inventory could also be useful. I don't think these tools should ever be things people purchasing OpenBMC based products count on using (but they could still be there if they wanted).

Quoted 97 lines

I would prefer to see our energy focused on enhancements to Redfish and on utilities which use the Redfish APIs (akin to redfishtool).

- Joseph

Quoted 89 lines

Wilfred

Quoted 85 lines · On Aug 15, 2019, at 12:41 PM, [email protected] wrote:

Send openbmc mailing list submissions to
[email protected]

To subscribe or unsubscribe via the World Wide Web, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.ozlabs.org_listinfo_openbmc&d=DwICAg&c=5VD0RTtNlTh3ycd41b3MUw&r=-ektT-tD9zf2rfUisE63RqiDagGyhGey2hbEGa-47kc&m=CsXIqDLC_9ZYrVSwNllcHo7GjqAG9mj2S6NymPQTblk&s=_RrYmmMf-6XU6r5LsXsWLj8G0K_qaWyo6K2yDU5JGu8&e=
or, via email, send a message with subject or body 'help' to
[email protected]

You can reach the person managing the list at
[email protected]

When replying, please edit your Subject line so it is more specific than "Re: Contents of openbmc digest..."

Today's Topics:

1. Re: Policy on Tools Posting (Vijay Khemka)
2. [PATCH dev-5.2] fsi: scom: Don't abort operations for minor errors (Eddie James)
3. Re: [PATCH] net/ncsi: Ensure 32-bit boundary for data cksum (David Miller)
4. Re: [PATCH v4 2/2] hwmon: pmbus: Add Inspur Power System power supply driver (Guenter Roeck)

----------------------------------------------------------------------

Message: 1
Date: Thu, 15 Aug 2019 19:07:26 +0000
From: Vijay Khemka <[email protected]>
To: Andrew Geissler <[email protected]>, Wilfred Smith
<[email protected]>
Cc: "[email protected]" <[email protected]>
Subject: Re: Policy on Tools Posting
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"

?On 8/15/19, 5:59 AM, "openbmc on behalf of Andrew Geissler" <[email protected] on behalf of [email protected]> wrote:

Quoted 2 lines · Wilfred Smith

1. Are there guidelines/procedures specific to submitting command line tools and utilities? I have heard that there may be a repository and/or path dedicated to CLI tools.

The community has definitely tended to limit wrapper tools within OpenBMC. We had a discussion a while back that we're open to some but the API's to them really need to be thought out and reviewed because command line tools become customer API's (i.e. people start writing scripts on top of these tools that then become key to the manufacturing process or some other critical area).

Anything that goes into OpenBMC needs to support OpenBMC interfaces. For example, I'm not familiar with fruid-util's D-bus service xyz.openbmc_project.FruDevice. A "busctl tree xyz.openbmc_project.Inventory.Manager | cat" shows the inventory items on OpenBMC.

One issue we have within OpenBMC is there may be different implementations of the D-bus API's for a given area. For example, Inventory has different implementations so I'm not sure which repo would best fit your tool. That type of issue leads me to wonder if we should put the tools with the interface definitions in openbmc/phosphor-dbus-interfaces? Or maybe a separate phosphor-tools repo would be more logical for these.
Andrew, I like the idea of having phosphor-tools which can be a placeholder for any commandline tools and can grow as per requirement. Currently it can start with 3 proposed tools.

Either way, I think command line tools should each get their own mini-design doc
(https://github.com/openbmc/docs/blob/master/designs/design-template.md)
Wilfred, Can you please create a document as per this design template and submit for review.

with requirements and interfaces clearly defined for review by the community. If we can find a generic tool that multiple people find useful, we can then find a place to put it. Otherwise, you could host your tools outside of openbmc/ github and just pull them into recipes from within your meta-facebook layer.

Quoted 3 lines

Thanks in advance,

Wilfred

...snip...

#4 lore raw

On 8/16/19, 12:58 PM, "openbmc on behalf of Andrew Geissler" <[email protected] on behalf of [email protected]> wrote:

On Thu, Aug 15, 2019 at 6:03 PM Joseph Reynolds <[email protected]> wrote:
>
>
> On 8/15/19 4:57 PM, Wilfred Smith wrote:
> > My manager (Sai) is asking whether there is precedence for having utilities posted outside the OpenBMC repository. Do we want 100 OpenBMC tools repositories, each managed differently or 1 harmonized repository?
> >
> > Separately, is there any effort to create a “common core” for OpenBMC such that an effort akin to POSIX or the Single UNIX Specification isn’t needed ten years from now? Without standard API (or at least abstracted tools) for things like where FRU information is located or sending IPMB commands, isn’t the market for innovative software stifled (Android software market vs iOS, or even Linux vs Windows)? >
> My view is to focus on enhancing the Redfish functions so that users of
> OpenBMC systems can do everything they need to without having use Secure
> Shell (ssh) or any of the command line utilities ssh can access (such as
> systemctl, busctl, or obmctool). See some publicly-readable IBM
> discussion on this topic here: https://github.com/ibm-openbmc/dev/issues/612

Once a system has shipped to a customer, ensuring 99% of what they need to use that server is available via Redfish definitely makes sense to me.

> Meanwhile, when us developers need to access the BMC via ssh, we are > happy to use the existing command line utilities and don't see the need > for any more.

Hmm, I don't think I agree with this. I think obmcutil has provided a lot of useful
abstraction for developers and users of OpenBMC (like our lab team). No one really wants to remember some of the long cumbersome commands done by obmcutil, nor do they want to deal with situations where we change the underlying D-bus API in a certain version of firmware. obmcutil provides a nice abstraction to that and I could see tools that provide abstractions for looking at error logs or listing system inventory could also be useful. I don't think these tools should ever be things people purchasing OpenBMC based products count on using (but they could still be there if they wanted).

I agree with Andrew here. There are many instances where simple commandline utility helps in debugging and quickly testing rather than searching through all long commands.

I would prefer to have these ipmb, fru and sensor utils to be hosted in the repo Where obmcutil are. I couldn't find repo for obmcutil.

Quoted 97 lines

I would prefer to see our energy focused on enhancements to Redfish and on utilities which use the Redfish APIs (akin to redfishtool).

- Joseph

Quoted 89 lines

Wilfred

Quoted 85 lines · On Aug 15, 2019, at 12:41 PM, [email protected] wrote:

Send openbmc mailing list submissions to
[email protected]

To subscribe or unsubscribe via the World Wide Web, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.ozlabs.org_listinfo_openbmc&d=DwICAg&c=5VD0RTtNlTh3ycd41b3MUw&r=-ektT-tD9zf2rfUisE63RqiDagGyhGey2hbEGa-47kc&m=CsXIqDLC_9ZYrVSwNllcHo7GjqAG9mj2S6NymPQTblk&s=_RrYmmMf-6XU6r5LsXsWLj8G0K_qaWyo6K2yDU5JGu8&e=
or, via email, send a message with subject or body 'help' to
[email protected]

You can reach the person managing the list at
[email protected]

When replying, please edit your Subject line so it is more specific than "Re: Contents of openbmc digest..."

Today's Topics:

1. Re: Policy on Tools Posting (Vijay Khemka)
2. [PATCH dev-5.2] fsi: scom: Don't abort operations for minor errors (Eddie James)
3. Re: [PATCH] net/ncsi: Ensure 32-bit boundary for data cksum (David Miller)
4. Re: [PATCH v4 2/2] hwmon: pmbus: Add Inspur Power System power supply driver (Guenter Roeck)

----------------------------------------------------------------------

Message: 1
Date: Thu, 15 Aug 2019 19:07:26 +0000
From: Vijay Khemka <[email protected]>
To: Andrew Geissler <[email protected]>, Wilfred Smith
<[email protected]>
Cc: "[email protected]" <[email protected]>
Subject: Re: Policy on Tools Posting
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"

?On 8/15/19, 5:59 AM, "openbmc on behalf of Andrew Geissler" <[email protected] on behalf of [email protected]> wrote:

Quoted 2 lines · Wilfred Smith

1. Are there guidelines/procedures specific to submitting command line tools and utilities? I have heard that there may be a repository and/or path dedicated to CLI tools.

The community has definitely tended to limit wrapper tools within OpenBMC. We had a discussion a while back that we're open to some but the API's to them really need to be thought out and reviewed because command line tools become customer API's (i.e. people start writing scripts on top of these tools that then become key to the manufacturing process or some other critical area).

Anything that goes into OpenBMC needs to support OpenBMC interfaces. For example, I'm not familiar with fruid-util's D-bus service xyz.openbmc_project.FruDevice. A "busctl tree xyz.openbmc_project.Inventory.Manager | cat" shows the inventory items on OpenBMC.

One issue we have within OpenBMC is there may be different implementations of the D-bus API's for a given area. For example, Inventory has different implementations so I'm not sure which repo would best fit your tool. That type of issue leads me to wonder if we should put the tools with the interface definitions in openbmc/phosphor-dbus-interfaces? Or maybe a separate phosphor-tools repo would be more logical for these.
Andrew, I like the idea of having phosphor-tools which can be a placeholder for any commandline tools and can grow as per requirement. Currently it can start with 3 proposed tools.

Either way, I think command line tools should each get their own mini-design doc
(https://github.com/openbmc/docs/blob/master/designs/design-template.md)
Wilfred, Can you please create a document as per this design template and submit for review.

with requirements and interfaces clearly defined for review by the community. If we can find a generic tool that multiple people find useful, we can then find a place to put it. Otherwise, you could host your tools outside of openbmc/ github and just pull them into recipes from within your meta-facebook layer.

Quoted 3 lines

Thanks in advance,

Wilfred

...snip...

#5 lore raw
In reply to Wilfred Smith
Quoted 2 lines · Wilfred Smith

My manager (Sai) is asking whether there is precedence for having utilities posted outside the OpenBMC repository. Do we want 100 OpenBMC tools repositories, each managed differently or 1 harmonized repository?

We do bring in some tools, like for our openpower systems we bring in a pdbg tool[1]. That tool isn't really specific to OpenBMC though, just a useful tool that
works within OpenBMC.

The spirit behind creating https://github.com/openbmc/openbmc-tools was to not have a bunch of the same tools being written by a bunch of different people. So far it's only been tools run outside of OpenBMC though. I know AndrewJ mentioned he may be open to using that repo for what's proposed here. It seems like a better fit then making some other tools repo. To me that's just confusing when you go to a github project and see multiple repositories with "tools" in the name.

[1]: https://github.com/openbmc/openbmc/blob/master/meta-openpower/recipes-bsp/pdbg/pdbg_2.2.bb

Quoted 1 line

Separately, is there any effort to create a “common core” for OpenBMC such that an effort akin to POSIX or the Single UNIX Specification isn’t needed ten years from now? Without standard API (or at least abstracted tools) for things like where FRU information is located or sending IPMB commands, isn’t the market for innovative software stifled (Android software market vs iOS, or even Linux vs Windows)?

Our focus so far has been on standardizing our external interfaces, i.e. Redfish/IPMI.
There has not been much focus on the internals (i.e. ssh) because it's a lot of work to version and standardize something and it's not something people buying OpenBMC machines are very interested in. I think wrapper tools are our best bet but there's been a lot of back and forth on that as well.

Quoted 2 lines

Wilfred

#6 lore raw
In reply to Wilfred Smith

Hi Wilfred,

Quoted 2 lines · Wilfred Smith

My manager (Sai) is asking whether there is precedence for having utilities posted outside the OpenBMC repository.

As in, outside of the github organisation? There's nothing to stop you from doing so (obviously we pull in a lot of software not directly written by the project), however the thing to consider is whether the tools are generally useful to the openbmc community. If they are then it's probably best that we host them under the github org.

Quoted 2 lines

Do we want 100 OpenBMC
tools repositories, each managed differently or 1 harmonized repository?

The answer to this is largely down to who maintains what and what their preferences are.

Quoted 7 lines

Separately, is there any effort to create a “common core” for OpenBMC such that an effort akin to POSIX or the Single UNIX Specification isn’t needed ten years from now? Without standard API (or at least abstracted tools) for things like where FRU information is located or sending IPMB commands, isn’t the market for innovative software stifled (Android software market vs iOS, or even Linux vs Windows)?

Developing a standard set of interfaces is the aim of phosphor-dbus-interfaces. We're exploring what's necessary in a bit of an evolutionary way rather than top-down specification. I think that makes the result more flexible and open to input based on different use-cases.

Quoted 2 lines

Wilfred

Finally, below is the content of a list digest. I have a few requests for your future posts:

* Please reply in-line to (i.e. below) the points to which you are responding, on a point-by-point basis. This makes the conversation much easier to follow.

* Try to trim content that's not relevant to the current thread of conversation. This keeps your emails concise (I haven't trimmed the digest below because it serves to support my point here).

* It looks like you've responded to a digest email from the list that happens to include the thread that you yourself started. Please respond on the thread itself, as responding to the digest splinters the conversation (mail clients that support threading won't properly track the responses here).

Cheers

Andrew

Quoted 634 lines
Quoted 632 lines · On Aug 15, 2019, at 12:41 PM, [email protected] wrote:

Send openbmc mailing list submissions to
[email protected]

To subscribe or unsubscribe via the World Wide Web, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.ozlabs.org_listinfo_openbmc&d=DwICAg&c=5VD0RTtNlTh3ycd41b3MUw&r=-ektT-tD9zf2rfUisE63RqiDagGyhGey2hbEGa-47kc&m=CsXIqDLC_9ZYrVSwNllcHo7GjqAG9mj2S6NymPQTblk&s=_RrYmmMf-6XU6r5LsXsWLj8G0K_qaWyo6K2yDU5JGu8&e=
or, via email, send a message with subject or body 'help' to
[email protected]

You can reach the person managing the list at
[email protected]

When replying, please edit your Subject line so it is more specific than "Re: Contents of openbmc digest..."

Today's Topics:

1. Re: Policy on Tools Posting (Vijay Khemka)
2. [PATCH dev-5.2] fsi: scom: Don't abort operations for minor errors (Eddie James)
3. Re: [PATCH] net/ncsi: Ensure 32-bit boundary for data cksum (David Miller)
4. Re: [PATCH v4 2/2] hwmon: pmbus: Add Inspur Power System power supply driver (Guenter Roeck)

----------------------------------------------------------------------

Message: 1
Date: Thu, 15 Aug 2019 19:07:26 +0000
From: Vijay Khemka <[email protected]>
To: Andrew Geissler <[email protected]>, Wilfred Smith
<[email protected]>
Cc: "[email protected]" <[email protected]>
Subject: Re: Policy on Tools Posting
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"

?On 8/15/19, 5:59 AM, "openbmc on behalf of Andrew Geissler" <[email protected] on behalf of [email protected]> wrote:

Quoted 3 lines · Wilfred Smith

1. Are there guidelines/procedures specific to submitting command line tools and utilities? I have heard that there may be a repository and/or path dedicated to CLI tools.

The community has definitely tended to limit wrapper tools within OpenBMC. We had a discussion a while back that we're open to some but the API's to them really need to be thought out and reviewed because command line tools become customer API's (i.e. people start writing scripts on top of these tools that then become key to the manufacturing process or some other critical area).

Anything that goes into OpenBMC needs to support OpenBMC interfaces. For example, I'm not familiar with fruid-util's D-bus service xyz.openbmc_project.FruDevice. A "busctl tree xyz.openbmc_project.Inventory.Manager | cat" shows the inventory items on OpenBMC.

One issue we have within OpenBMC is there may be different implementations of the D-bus API's for a given area. For example, Inventory has different implementations so I'm not sure which repo would best fit your tool. That type of issue leads me to wonder if we should put the tools with the interface definitions in openbmc/phosphor-dbus-interfaces? Or maybe a separate phosphor-tools repo would be more logical for these.
Andrew, I like the idea of having phosphor-tools which can be a placeholder for any commandline tools and can grow as per requirement. Currently it can start with 3 proposed tools.

Either way, I think command line tools should each get their own mini-design doc
(https://github.com/openbmc/docs/blob/master/designs/design-template.md)
Wilfred, Can you please create a document as per this design template and submit for review.

with requirements and interfaces clearly defined for review by the community. If we can find a generic tool that multiple people find useful, we can then find a place to put it. Otherwise, you could host your tools outside of openbmc/ github and just pull them into recipes from within your meta-facebook layer.

Quoted 3 lines

Thanks in advance,

Wilfred

------------------------------

Message: 2
Date: Thu, 15 Aug 2019 14:11:03 -0500
From: Eddie James <[email protected]>
To: [email protected]
Cc: [email protected], Eddie James <[email protected]>
Subject: [PATCH dev-5.2] fsi: scom: Don't abort operations for minor
errors
Message-ID: <[email protected]>

The scom driver currently fails out of operations if certain system errors are flagged in the status register; system checkstop, special attention, or recoverable error. These errors won't impact the ability of the scom engine to perform operations, so the driver should continue under these conditions.
Also, don't do a PIB reset for these conditions, since it won't help.

---
drivers/fsi/fsi-scom.c | 8 +-------

1 file changed, 1 insertion(+), 7 deletions(-)
drivers/fsi/fsi-scom.c +1 -7
index 343153d..004dc03 100644
@@ -38,8 +38,7 @@
 #define SCOM_STATUS_PIB_RESP_MASK	0x00007000
 #define SCOM_STATUS_PIB_RESP_SHIFT	12
 
-#define SCOM_STATUS_ANY_ERR		(SCOM_STATUS_ERR_SUMMARY | \
-					 SCOM_STATUS_PROTECTION | \
+#define SCOM_STATUS_ANY_ERR		(SCOM_STATUS_PROTECTION | \
 					 SCOM_STATUS_PARITY |	  \
 					 SCOM_STATUS_PIB_ABORT | \
 					 SCOM_STATUS_PIB_RESP_MASK)
@@ -251,11 +250,6 @@ static int handle_fsi2pib_status(struct scom_device *scom, uint32_t status)
 	/* Return -EBUSY on PIB abort to force a retry */
 	if (status & SCOM_STATUS_PIB_ABORT)
 		return -EBUSY;
-	if (status & SCOM_STATUS_ERR_SUMMARY) {
-		fsi_device_write(scom->fsi_dev, SCOM_FSI2PIB_RESET_REG, &dummy,
-				 sizeof(uint32_t));
-		return -EIO;
-	}
 	return 0;
 }
 
Signature · 19 lines
1.8.3.1



------------------------------

Message: 3
Date: Thu, 15 Aug 2019 12:32:35 -0700 (PDT)
From: David Miller <[email protected]>
To: [email protected]
Cc: [email protected], [email protected],
	[email protected], [email protected],
	[email protected], [email protected]
Subject: Re: [PATCH] net/ncsi: Ensure 32-bit boundary for data cksum
Message-ID: <[email protected]>
Content-Type: Text/Plain; charset=us-ascii

From: "Terry S. Duncan" <[email protected]>
Date: Tue, 13 Aug 2019 18:18:40 -0700
Quoted 16 lines

The NCSI spec indicates that if the data does not end on a 32 bit boundary, one to three padding bytes equal to 0x00 shall be present to align the checksum field to a 32-bit boundary.

---

net/ncsi/internal.h |  1 +
net/ncsi/ncsi-cmd.c |  2 +-
net/ncsi/ncsi-rsp.c | 12 ++++++++----
3 files changed, 10 insertions(+), 5 deletions(-)
net/ncsi/internal.h +0 -0
index 0b3f0673e1a2..468a19fdfd88 100644

net/ncsi/internal.h struct ncsi_package; · line 188

Quoted 4 lines
net/ncsi/internal.h +1 -0
@@ -185,6 +185,7 @@ struct ncsi_package;
 #define NCSI_TO_CHANNEL(p, c)	(((p) << NCSI_PACKAGE_SHIFT) | (c))
 #define NCSI_MAX_PACKAGE	8
 #define NCSI_MAX_CHANNEL	32
+#define NCSI_ROUND32(x)		(((x) + 3) & ~3) /* Round to 32 bit boundary */

I think we have enough of a proliferation of alignment macros, let's not add more.

Either define this to "ALIGN(x, 4)" or expand that into each of the locations:

net/ncsi/internal.h struct ncsi_package; · line 190

Quoted 3 lines
net/ncsi/internal.h +1 -1
 	pchecksum = (__be32 *)((void *)h + sizeof(struct ncsi_pkt_hdr) +
-		    nca->payload);
+		    NCSI_ROUND32(nca->payload));
		     ALIGN(nca->payload, 4)

net/ncsi/internal.h struct ncsi_package; · line 191

Quoted 2 lines
net/ncsi/internal.h +1 -1
-	pchecksum = (__be32 *)((void *)(h + 1) + payload - 4);
+	pchecksum = (__be32 *)((void *)(h + 1) + NCSI_ROUND32(payload) - 4);

ALIGN(payload, 4)

etc.

------------------------------

Message: 4
Date: Thu, 15 Aug 2019 12:41:02 -0700
From: Guenter Roeck <[email protected]>
To: Vijay Khemka <[email protected]>
Cc: John Wang <[email protected]>, "[email protected]"

	<[email protected]>, "[email protected]" <[email protected]>,
	"[email protected]" <[email protected]>,
	"[email protected]" <[email protected]>,
	"[email protected]" <[email protected]>,
	"[email protected]" <[email protected]>,
	"[email protected]" <[email protected]>,
	"[email protected]" <[email protected]>, "[email protected]"
	<[email protected]>

Subject: Re: [PATCH v4 2/2] hwmon: pmbus: Add Inspur Power System
power supply driver
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8

Quoted 348 lines · Vijay Khemka

?On 8/13/19, 1:36 AM, "openbmc on behalf of John Wang" <[email protected] on behalf of [email protected]> wrote:

Add the driver to monitor Inspur Power System power supplies with hwmon over pmbus.

This driver adds sysfs attributes for additional power supply data, including vendor, model, part_number, serial number, firmware revision, hardware revision, and psu mode(active/standby).

---
v4:
- Remove the additional tabs in the Makefile
- Rebased on 5.3-rc4, not 5.2
v3:
- Sort kconfig/makefile entries alphabetically
- Remove unnecessary initialization
- Use ATTRIBUTE_GROUPS instead of expanding directly
- Use memscan to avoid reimplementation
v2:
- Fix typos in commit message
- Invert Christmas tree
- Configure device with sysfs attrs, not debugfs entries
- Fix errno in fw_version_read, ENODATA to EPROTO
- Change the print format of fw-version
- Use sysfs_streq instead of strcmp("xxx" "\n", "xxx")
- Document sysfs attributes
---

    Documentation/hwmon/inspur-ipsps1.rst |  79 +++++++++
    drivers/hwmon/pmbus/Kconfig           |   9 +
    drivers/hwmon/pmbus/Makefile          |   1 +
    drivers/hwmon/pmbus/inspur-ipsps.c    | 226 ++++++++++++++++++++++++++
    4 files changed, 315 insertions(+)

create mode 100644 Documentation/hwmon/inspur-ipsps1.rst create mode 100644 drivers/hwmon/pmbus/inspur-ipsps.c

   diff --git a/Documentation/hwmon/inspur-ipsps1.rst b/Documentation/hwmon/inspur-ipsps1.rst
   new file mode 100644
   index 000000000000..aa19f0ccc8b0
   --- /dev/null
   +++ b/Documentation/hwmon/inspur-ipsps1.rst
   @@ -0,0 +1,79 @@
   +Kernel driver inspur-ipsps1
   +=======================
   +
   +Supported chips:
   +
   +  * Inspur Power System power supply unit
   +
   +Author: John Wang <[email protected]>
   +
   +Description
   +-----------
   +
   +This driver supports Inspur Power System power supplies. This driver
   +is a client to the core PMBus driver.
   +
   +Usage Notes
   +-----------
   +
   +This driver does not auto-detect devices. You will have to instantiate the
   +devices explicitly. Please see Documentation/i2c/instantiating-devices for
   +details.
   +
   +Sysfs entries
   +-------------
   +
   +The following attributes are supported:
   +
   +======================= ======================================================
   +curr1_input             Measured input current
   +curr1_label             "iin"
   +curr1_max               Maximum current
   +curr1_max_alarm         Current high alarm
   +curr2_input		Measured output current in mA.
   +curr2_label		"iout1"
   +curr2_crit              Critical maximum current
   +curr2_crit_alarm        Current critical high alarm
   +curr2_max               Maximum current
   +curr2_max_alarm         Current high alarm
   +

Please align above details.
+fan1_alarm Fan 1 warning.
+fan1_fault Fan 1 fault.
+fan1_input Fan 1 speed in RPM.
+
+in1_alarm Input voltage under-voltage alarm.
+in1_input Measured input voltage in mV.
+in1_label "vin"
+in2_input Measured output voltage in mV.
+in2_label "vout1"

   +in2_lcrit               Critical minimum output voltage
   +in2_lcrit_alarm         Output voltage critical low alarm
   +in2_max                 Maximum output voltage
   +in2_max_alarm           Output voltage high alarm
   +in2_min                 Minimum output voltage
   +in2_min_alarm           Output voltage low alarm

+
+power1_alarm Input fault or alarm.
+power1_input Measured input power in uW.
+power1_label "pin"
+power1_max Input power limit
+power2_max_alarm Output power high alarm
+power2_max Output power limit
+power2_input Measured output power in uW.
+power2_label "pout"
+
Same alignment issue in description.
+temp[1-3]_input Measured temperature
+temp[1-2]_max Maximum temperature
+temp[1-3]_max_alarm Temperature high alarm
+

   +vendor                  Manufacturer name
   +model                   Product model
   +part_number             Product part number
   +serial_number           Product serial number
   +fw_version              Firmware version
   +hw_version              Hardware version
   +mode                    Work mode. Can be set to active or
   +                        standby, when set to standby, PSU will
   +                        automatically switch between standby
   +                        and redundancy mode.

+======================= ====================================================== diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig index b6588483fae1..d62d69bb7e49 100644
--- a/drivers/hwmon/pmbus/Kconfig
+++ b/drivers/hwmon/pmbus/Kconfig
@@ -46,6 +46,15 @@ config SENSORS_IBM_CFFPS
This driver can also be built as a module. If so, the module will be called ibm-cffps.

   +config SENSORS_INSPUR_IPSPS
   +	tristate "INSPUR Power System Power Supply"
   +	help
   +	  If you say yes here you get hardware monitoring support for the INSPUR
   +	  Power System power supply.
   +
   +	  This driver can also be built as a module. If so, the module will
   +	  be called inspur-ipsps.
   +
    config SENSORS_IR35221
    	tristate "Infineon IR35221"
    	help
   diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile
   index c950ea9a5d00..03bacfcfd660 100644
   --- a/drivers/hwmon/pmbus/Makefile
   +++ b/drivers/hwmon/pmbus/Makefile
   @@ -7,6 +7,7 @@ obj-$(CONFIG_PMBUS)		+= pmbus_core.o
    obj-$(CONFIG_SENSORS_PMBUS)	+= pmbus.o
    obj-$(CONFIG_SENSORS_ADM1275)	+= adm1275.o
    obj-$(CONFIG_SENSORS_IBM_CFFPS)	+= ibm-cffps.o
   +obj-$(CONFIG_SENSORS_INSPUR_IPSPS) += inspur-ipsps.o
    obj-$(CONFIG_SENSORS_IR35221)	+= ir35221.o
    obj-$(CONFIG_SENSORS_IR38064)	+= ir38064.o
    obj-$(CONFIG_SENSORS_IRPS5401)	+= irps5401.o
   diff --git a/drivers/hwmon/pmbus/inspur-ipsps.c b/drivers/hwmon/pmbus/inspur-ipsps.c
   new file mode 100644
   index 000000000000..fa981b881a60
   --- /dev/null
   +++ b/drivers/hwmon/pmbus/inspur-ipsps.c
   @@ -0,0 +1,226 @@
   +// SPDX-License-Identifier: GPL-2.0-or-later
   +/*
   + * Copyright 2019 Inspur Corp.
   + */
   +
   +#include <linux/debugfs.h>
   +#include <linux/device.h>
   +#include <linux/fs.h>
   +#include <linux/i2c.h>
   +#include <linux/module.h>
   +#include <linux/pmbus.h>
   +#include <linux/hwmon-sysfs.h>
   +
   +#include "pmbus.h"
   +
   +#define IPSPS_REG_VENDOR_ID	0x99
   +#define IPSPS_REG_MODEL		0x9A
   +#define IPSPS_REG_FW_VERSION	0x9B
   +#define IPSPS_REG_PN		0x9C
   +#define IPSPS_REG_SN		0x9E
   +#define IPSPS_REG_HW_VERSION	0xB0
   +#define IPSPS_REG_MODE		0xFC
   +
   +#define MODE_ACTIVE		0x55
   +#define MODE_STANDBY		0x0E
   +#define MODE_REDUNDANCY		0x00
   +
   +#define MODE_ACTIVE_STRING		"active"
   +#define MODE_STANDBY_STRING		"standby"
   +#define MODE_REDUNDANCY_STRING		"redundancy"
   +
   +enum ipsps_index {
   +	vendor,
   +	model,
   +	fw_version,
   +	part_number,
   +	serial_number,
   +	hw_version,
   +	mode,
   +	num_regs,
   +};
   +
   +static const u8 ipsps_regs[num_regs] = {
   +	[vendor] = IPSPS_REG_VENDOR_ID,
   +	[model] = IPSPS_REG_MODEL,
   +	[fw_version] = IPSPS_REG_FW_VERSION,
   +	[part_number] = IPSPS_REG_PN,
   +	[serial_number] = IPSPS_REG_SN,
   +	[hw_version] = IPSPS_REG_HW_VERSION,
   +	[mode] = IPSPS_REG_MODE,
   +};
   +
   +static ssize_t ipsps_string_show(struct device *dev,
   +				 struct device_attribute *devattr,
   +				 char *buf)
   +{
   +	u8 reg;
   +	int rc;
   +	char *p;
   +	char data[I2C_SMBUS_BLOCK_MAX + 1];
   +	struct i2c_client *client = to_i2c_client(dev->parent);
   +	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
   +
   +	reg = ipsps_regs[attr->index];
   +	rc = i2c_smbus_read_block_data(client, reg, data);
   +	if (rc < 0)
   +		return rc;
   +
   +	/* filled with printable characters, ending with # */
   +	p = memscan(data, '#', rc);
   +	*p = '\0';
   +
   +	return snprintf(buf, PAGE_SIZE, "%s\n", data);
   +}
   +
   +static ssize_t ipsps_fw_version_show(struct device *dev,
   +				     struct device_attribute *devattr,
   +				     char *buf)
   +{
   +	u8 reg;
   +	int rc;
   +	u8 data[I2C_SMBUS_BLOCK_MAX] = { 0 };
   +	struct i2c_client *client = to_i2c_client(dev->parent);
   +	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
   +
   +	reg = ipsps_regs[attr->index];
   +	rc = i2c_smbus_read_block_data(client, reg, data);
   +	if (rc < 0)
   +		return rc;
   +
   +	if (rc != 6)
   +		return -EPROTO;
   +
   +	return snprintf(buf, PAGE_SIZE, "%u.%02u%u-%u.%02u\n",
   +			data[1], data[2]/* < 100 */, data[3]/*< 10*/,
   +			data[4], data[5]/* < 100 */);
   +}
   +
   +static ssize_t ipsps_mode_show(struct device *dev,
   +			       struct device_attribute *devattr, char *buf)
   +{
   +	u8 reg;
   +	int rc;
   +	struct i2c_client *client = to_i2c_client(dev->parent);
   +	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
   +
   +	reg = ipsps_regs[attr->index];
   +	rc = i2c_smbus_read_byte_data(client, reg);
   +	if (rc < 0)
   +		return rc;
   +
   +	switch (rc) {
   +	case MODE_ACTIVE:
   +		return snprintf(buf, PAGE_SIZE, "[%s] %s %s\n",
   +				MODE_ACTIVE_STRING,
   +				MODE_STANDBY_STRING, MODE_REDUNDANCY_STRING);
   +	case MODE_STANDBY:
   +		return snprintf(buf, PAGE_SIZE, "%s [%s] %s\n",
   +				MODE_ACTIVE_STRING,
   +				MODE_STANDBY_STRING, MODE_REDUNDANCY_STRING);
   +	case MODE_REDUNDANCY:
   +		return snprintf(buf, PAGE_SIZE, "%s %s [%s]\n",
   +				MODE_ACTIVE_STRING,
   +				MODE_STANDBY_STRING, MODE_REDUNDANCY_STRING);
   +	default:
   +		return snprintf(buf, PAGE_SIZE, "unspecified\n");
   +	}
   +}
   +
   +static ssize_t ipsps_mode_store(struct device *dev,
   +				struct device_attribute *devattr,
   +				const char *buf, size_t count)
   +{
   +	u8 reg;
   +	int rc;
   +	struct i2c_client *client = to_i2c_client(dev->parent);
   +	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
   +
   +	reg = ipsps_regs[attr->index];
   +	if (sysfs_streq(MODE_STANDBY_STRING, buf)) {
   +		rc = i2c_smbus_write_byte_data(client, reg,
   +					       MODE_STANDBY);
   +		if (rc < 0)
   +			return rc;
   +		return count;
   +	} else if (sysfs_streq(MODE_ACTIVE_STRING, buf)) {
   +		rc = i2c_smbus_write_byte_data(client, reg,
   +					       MODE_ACTIVE);
   +		if (rc < 0)
   +			return rc;
   +		return count;
   +	}
   +
   +	return -EINVAL;
   +}
   +
   +static SENSOR_DEVICE_ATTR_RO(vendor, ipsps_string, vendor);
   +static SENSOR_DEVICE_ATTR_RO(model, ipsps_string, model);
   +static SENSOR_DEVICE_ATTR_RO(part_number, ipsps_string, part_number);
   +static SENSOR_DEVICE_ATTR_RO(serial_number, ipsps_string, serial_number);
   +static SENSOR_DEVICE_ATTR_RO(hw_version, ipsps_string, hw_version);
   +static SENSOR_DEVICE_ATTR_RO(fw_version, ipsps_fw_version, fw_version);
   +static SENSOR_DEVICE_ATTR_RW(mode, ipsps_mode, mode);
   +
   +static struct attribute *ipsps_attrs[] = {
   +	&sensor_dev_attr_vendor.dev_attr.attr,
   +	&sensor_dev_attr_model.dev_attr.attr,
   +	&sensor_dev_attr_part_number.dev_attr.attr,
   +	&sensor_dev_attr_serial_number.dev_attr.attr,
   +	&sensor_dev_attr_hw_version.dev_attr.attr,
   +	&sensor_dev_attr_fw_version.dev_attr.attr,
   +	&sensor_dev_attr_mode.dev_attr.attr,
   +	NULL,
   +};
   +
   +ATTRIBUTE_GROUPS(ipsps);
   +
   +static struct pmbus_driver_info ipsps_info = {
   +	.pages = 1,
   +	.func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_VOUT | PMBUS_HAVE_IOUT |
   +		PMBUS_HAVE_IIN | PMBUS_HAVE_POUT | PMBUS_HAVE_PIN |
   +		PMBUS_HAVE_FAN12 | PMBUS_HAVE_TEMP | PMBUS_HAVE_TEMP2 |
   +		PMBUS_HAVE_TEMP3 | PMBUS_HAVE_STATUS_VOUT |
   +		PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_STATUS_INPUT |
   +		PMBUS_HAVE_STATUS_TEMP | PMBUS_HAVE_STATUS_FAN12,
Quoted 1 line

This can be dynamic read by chip identify function

PMBUS_SKIP_STATUS_CHECK weakens auto-detetcion to some degree, and auto-detection takes time since it needs to poll all registers to determine if they exist. I don't mind if you insist, but I don't immediately see the benefits.

Quoted 11 lines
   +	.groups = ipsps_groups,
   +};
   +
   +static struct pmbus_platform_data ipsps_pdata = {
   +	.flags = PMBUS_SKIP_STATUS_CHECK,
   +};
   +
   +static int ipsps_probe(struct i2c_client *client,
   +		       const struct i2c_device_id *id)
   +{
   +	client->dev.platform_data = &ipsps_pdata;
Quoted 1 line

Allocate memory for this platform data inside tis function rather than having global variable.

Does that have any value other than consuming more memory if there are multiple instances of the driver ?

Quoted 24 lines
   +	return pmbus_do_probe(client, id, &ipsps_info);
   +}
   +
   +static const struct i2c_device_id ipsps_id[] = {
   +	{ "inspur_ipsps1", 0 },
   +	{}
   +};
   +MODULE_DEVICE_TABLE(i2c, ipsps_id);
   +
   +static const struct of_device_id ipsps_of_match[] = {
   +	{ .compatible = "inspur,ipsps1" },
   +	{}
   +};
   +MODULE_DEVICE_TABLE(of, ipsps_of_match);
   +
   +static struct i2c_driver ipsps_driver = {
   +	.driver = {
   +		.name = "inspur-ipsps",
   +		.of_match_table = ipsps_of_match,
   +	},
   +	.probe = ipsps_probe,
   +	.remove = pmbus_do_remove,
   +	.id_table = ipsps_id,
   +};
Quoted 11 lines
   +
   +module_i2c_driver(ipsps_driver);
   +
   +MODULE_AUTHOR("John Wang");
   +MODULE_DESCRIPTION("PMBus driver for Inspur Power System power supplies");
   +MODULE_LICENSE("GPL");
   -- 
   2.17.1

End of openbmc Digest, Vol 48, Issue 81
***************************************