Skip to contentSkip to conversation

Exynos: Change get_timer() to work correctly

PATCH New Alexei Fedorov 1 participant 1 message Mar 28, 2013 1 message not in the archive

Subsystems (7)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH v2 1/9 Exynos: Change get_timer() to work correctly

Dear Akshay,
You wrote
"(PCLK = 66 MHz)"
To be precise it's 66.(6)MHz.
Regards.
Alexei.

-----Original Message-----
From: [email protected] [mailto:u-boot-bounces at lists.denx.de] On Behalf Of u-boot-request at lists.denx.de
Sent: 28 March 2013 15:22
To: u-boot at lists.denx.de
Subject: U-Boot Digest, Vol 58, Issue 49

Send U-Boot mailing list submissions to
u-boot at lists.denx.de

To subscribe or unsubscribe via the World Wide Web, visit
http://lists.denx.de/mailman/listinfo/u-boot
or, via email, send a message with subject or body 'help' to
u-boot-request at lists.denx.de

You can reach the person managing the list at
u-boot-owner at lists.denx.de

When replying, please edit your Subject line so it is more specific than "Re: Contents of U-Boot digest..."

Today's Topics:

1. [PATCH 2/5] powerpc/pamu : PAMU configuration for accessing SEC block (Ruchika Gupta)
2. [PATCH 3/5] drivers/sec : Freescale SEC driver (Ruchika Gupta)
3. [PATCH 0/5] FSL SECURE BOOT: Add support for next level image
validation (Ruchika Gupta)
4. [PATCH 4/5] FSL SEC Driver : Add support for descriptor creation (Ruchika Gupta)
5. [PATCH 1/5] arch/powerpc/cpu/mpc8xxx: PAMU driver support (Ruchika Gupta)
6. [PATCH 5/5] Added command for validation of images in case of
secure boot (Ruchika Gupta)
7. Re: [PATCH V2] ARM: bcm2835: fix get_timer() to return ms (Albert ARIBAUD)
8. Re: Splash Screen Enable in (u-boot-2013.01.01.tar.bz2) U-boot source code. (nandakumar.ramaswamy at pricoltech.com)
9. Re: Splash Screen Enable in (u-boot-2013.01.01.tar.bz2) U-boot source code. ( Andreas Bie?mann )
10. [PATCH v3 1/7] cros: add cros_ec driver (Hung-ying Tyan)
11. Re: Splash Screen Enable in (u-boot-2013.01.01.tar.bz2) U-boot source code. (Fabio Estevam)
12. Re: Splash Screen Enable in (u-boot-2013.01.01.tar.bz2) U-boot source code. (Fabio Estevam)
13. Merge conflict on Tegra SPI between u-boot/master and u-boot-arm/master (Albert ARIBAUD)
14. Re: Splash Screen Enable in (u-boot-2013.01.01.tar.bz2) U-boot source code. (Anatolij Gustschin)
15. Re: [PATCH 1/9 v2] Exynos: Change get_timer() to work correctly (Akshay Saraswat)
16. Re: [PATCH v2] mx6: Fix get_board_rev() for the mx6 solo case (Eric Nelson)
17. Re: [PATCH 3/9 v2] Exynos: pwm: Fix two bugs in the exynos pwm configuration code (Akshay Saraswat)
18. Re: [PATCH 4/9 v2] Exynos: Avoid a divide by zero by specifying a non-zero period for pwm 4 (Akshay Saraswat)
19. [PATCH 00/11 v3] Fix and Re-organise PWM Timer (Akshay Saraswat)
20. [PATCH 01/11 v3] Exynos5: config: enable time command (Akshay Saraswat)
21. [PATCH 02/11 v3] Exynos: Change get_timer() to work correctly
(Akshay Saraswat)
22. [PATCH 03/11 v3] Exynos: Add timer_get_us function (Akshay Saraswat)
23. [PATCH 04/11 v3] Exynos: pwm: Fix two bugs in the exynos pwm configuration code (Akshay Saraswat)
24. [PATCH 05/11 v3] Exynos: Avoid a divide by zero by specifying a non-zero period for pwm 4 (Akshay Saraswat)
25. [PATCH 08/11 v3] Exynos: clock: Add generic api to get the clk freq (Akshay Saraswat)
26. [PATCH 09/11 v3] Exynos: clock: Correct pwm source clk selection (Akshay Saraswat)
27. [PATCH 11/11 v3] Exynos: pwm: Remove dead code of function exynos5_get_pwm_clk (Akshay Saraswat)
28. [PATCH 10/11 v3] Exynos: pwm: Use generic api to get pwm clk freq (Akshay Saraswat)
29. [PATCH 06/11 v3] Exynos: Tidy up the pwm_config function in the exynos pwm driver (Akshay Saraswat)
30. Re: [RFC/PATCH 0/4] BCH8 support for OMAP3 (Tom Rini)
31. Re: [PATCH 1/7] USB: Some cleanup prior to USB 3.0 interface
addition (Marek Vasut)
32. Re: [PATCH 2/7] usb: hub: Conditionally power on usb's root-hub ports (Marek Vasut)
33. Re: [PATCH 3/7] usb: Update device class in usb device's descriptor (Marek Vasut)
34. Re: [PATCH 5/7] usb: hub: Increase device enumeration timeout
for broken drives (Marek Vasut)
35. Re: [PATCH 6/7] USB: SS: Add support for Super Speed USB interface (Marek Vasut)
36. Re: [PATCH v9 01/30] mtd: nand: Introduce CONFIG_SYS_NAND_BUSWIDTH_16BIT (Beno?t Th?baudeau)
37. Re: [PATCH 0/5] FSL SECURE BOOT: Add support for next level image validation (Otavio Salvador)
38. Re: [PATCH V2] ARM: bcm2835: fix get_timer() to return ms (Stephen Warren)
39. Re: Merge conflict on Tegra SPI between u-boot/master and u-boot-arm/master (Tom Warren)
40. Re: [PATCH] ARM: bcm2835: fix get_timer() to return mS (Stephen Warren)
41. Re: [PATCH V2] ARM: bcm2835: fix get_timer() to return ms (Albert ARIBAUD)
42. Re: [PATCH v9 01/30] mtd: nand: Introduce CONFIG_SYS_NAND_BUSWIDTH_16BIT (Albert ARIBAUD)
43. Re: Merge conflict on Tegra SPI between u-boot/master and u-boot-arm/master (Tom Warren)
44. Re: [PATCH 1/1 v2] omap3_beagle: Enabling UART3 first allows the Transmitter to be empty (Tom Rini)
45. Re: [PATCH 1/1 v2] omap3_beagle: Enabling UART3 first allows the Transmitter to be empty (Tom Rini)

----------------------------------------------------------------------

Message: 1
Date: Thu, 28 Mar 2013 16:16:32 +0530
From: Ruchika Gupta <[email protected]>
Subject: [U-Boot] [PATCH 2/5] powerpc/pamu : PAMU configuration for
accessing SEC block
To: <[email protected]>, <[email protected]>
Cc: Kuldip Giroh <[email protected]>, Ruchika Gupta
<[email protected]>
Message-ID:

        <[email protected]>

Content-Type: text/plain

---
Based upon git://git.denx.de/u-boot.git branch master

 arch/powerpc/cpu/mpc8xxx/Makefile         |    2 +-
 arch/powerpc/cpu/mpc8xxx/fsl_pamu_table.c |   68 +++++++++++++++++++++++++++++
 arch/powerpc/include/asm/fsl_pamu.h       |    1 +
 3 files changed, 70 insertions(+), 1 deletions(-)
 create mode 100644 arch/powerpc/cpu/mpc8xxx/fsl_pamu_table.c
arch/powerpc/cpu/mpc8xxx/Makefile +1 -1
index 097599e..7099136 100644
@@ -33,7 +33,7 @@ COBJS-$(CONFIG_FSL_IFC) += fsl_ifc.o
 COBJS-$(CONFIG_FSL_LBC) += fsl_lbc.o
 COBJS-$(CONFIG_SYS_SRIO) += srio.o
 COBJS-$(CONFIG_FSL_LAW) += law.o
-COBJS-$(CONFIG_FSL_CORENET) += fsl_pamu.o
+COBJS-$(CONFIG_FSL_CORENET) += fsl_pamu.o fsl_pamu_table.o
 
 endif
 
arch/powerpc/cpu/mpc8xxx/fsl_pamu_table.c new file +68 -0

68 lines not on this page · raw message

arch/powerpc/include/asm/fsl_pamu.h +1 -0
index e2cfe97..85ef9bf 100644
@@ -189,5 +189,6 @@ int pamu_init(void);
 void pamu_enable(void);
 void pamu_disable(void);
 int config_pamu(struct pamu_addr_tbl *tbl, int num_entries, uint32_t liodn);
+int sec_config_pamu_table(uint32_t liodn_ns, uint32_t liodn_s);
 
 #endif

--
1.7.7.6

------------------------------

Message: 2
Date: Thu, 28 Mar 2013 16:16:33 +0530
From: Ruchika Gupta <[email protected]>
Subject: [U-Boot] [PATCH 3/5] drivers/sec : Freescale SEC driver
To: <[email protected]>, <[email protected]>
Cc: Kuldip Giroh <[email protected]>, Ruchika Gupta
<[email protected]>
Message-ID:

        <[email protected]>

Content-Type: text/plain

SEC driver support is required in secure boot

Following files have been picked up from caam driver in Linux :
include/desc.h

The file drivers/sec/jr.c has some functions derived from caam driver in Linux.

---
Based upon git://git.denx.de/u-boot.git branch master

 Makefile                              |    1 +
 arch/powerpc/include/asm/immap_85xx.h |   50 +-
 arch/powerpc/include/asm/types.h      |    5 +-
 drivers/sec/Makefile                  |   46 +
 drivers/sec/jr.c                      |  319 +++++++
 include/desc.h                        | 1605 +++++++++++++++++++++++++++++++++
 include/jr.h                          |  129 +++
 7 files changed, 2152 insertions(+), 3 deletions(-)
 create mode 100644 drivers/sec/Makefile
 create mode 100644 drivers/sec/jr.c
 create mode 100644 include/desc.h
 create mode 100644 include/jr.h
Makefile +1 -0
index 12763ce..2b63585 100644
@@ -329,6 +329,7 @@ LIBS-y += common/libcommon.o
 LIBS-y += lib/libfdt/libfdt.o
 LIBS-y += api/libapi.o
 LIBS-y += post/libpost.o
+LIBS-y += drivers/sec/libsec.o
 LIBS-y += test/libtest.o
 
 ifneq ($(CONFIG_AM33XX)$(CONFIG_OMAP34XX)$(CONFIG_OMAP44XX)$(CONFIG_OMAP54XX),)
arch/powerpc/include/asm/immap_85xx.h +48 -2

74 lines not on this page · raw message

arch/powerpc/include/asm/types.h +4 -1
index b27a6b7..ec9a4c3 100644
@@ -41,8 +41,11 @@ typedef unsigned long long u64;
 
 #define BITS_PER_LONG 32
 
-/* DMA addresses are 32-bits wide */
+#ifdef CONFIG_PHYS_64BIT
+typedef unsigned long long dma_addr_t;
+#else
 typedef u32 dma_addr_t;
+#endif
 
 #ifdef CONFIG_PHYS_64BIT
 typedef unsigned long long phys_addr_t;
drivers/sec/Makefile new file +46 -0

46 lines not on this page · raw message

drivers/sec/jr.c new file +319 -0

319 lines not on this page · raw message

include/desc.h new file +1605 -0

1,605 lines not on this page · raw message

include/jr.h new file +129 -0

129 lines not on this page · raw message

--
1.7.7.6

------------------------------

Message: 3
Date: Thu, 28 Mar 2013 16:16:30 +0530
From: Ruchika Gupta <[email protected]>
Subject: [U-Boot] [PATCH 0/5] FSL SECURE BOOT: Add support for next
level image validation
To: <[email protected]>, <[email protected]>
Cc: Ruchika Gupta <[email protected]> Message-ID:

        <[email protected]>

Content-Type: text/plain

The patch set adds support for next level image validation (linux, rootfs, dtb) in secure boot scenarios.

The patch set adds the following functaionality :
1. In secure boot, PAMU is not in bypassed mode. For validating next level images, CAAM block needs to be accessed. In order to access the CAAM block, first PAMU needs to be configured to allow access to CAAM block from core. This patch set adds the basic driver for PAMU.

2. Support has been added for using job ring interface of SEC block to do cryptographic operations. Descriptors for the following crypto operations have been added
a) RSA modular exponentiation
b) SHA-256
c) cryptographic blob encryption/decryption

3. esbc_validate command added which uses the SEC block and verifies the images. esbc_validate command is meant for validating header and
signature of images (Boot Script and ESBC uboot client).
SHA-256 and RSA operations are performed using SEC block in HW. This command works on both high-end (P4080) and low-end (P1010) platforms.

Ruchika Gupta (5):
arch/powerpc/cpu/mpc8xxx: PAMU driver support powerpc/pamu : PAMU configuration for accessing SEC block drivers/sec : Freescale SEC driver
FSL SEC Driver : Add support for descriptor creation Added command for validation of images in case of secure boot

 Makefile                                     |    1 +
 arch/powerpc/cpu/mpc85xx/Makefile            |    2 +
 arch/powerpc/cpu/mpc85xx/cmd_esbc_validate.c |   54 +
 arch/powerpc/cpu/mpc85xx/cpu_init.c          |   17 +
 arch/powerpc/cpu/mpc85xx/fsl_sfp_snvs.c      |  163 +++
 arch/powerpc/cpu/mpc85xx/fsl_validate.c      |  543 +++++++++
 arch/powerpc/cpu/mpc8xxx/Makefile            |    3 +-
 arch/powerpc/cpu/mpc8xxx/fsl_pamu.c          |  488 ++++++++
 arch/powerpc/cpu/mpc8xxx/fsl_pamu_table.c    |   68 ++
 arch/powerpc/include/asm/fsl_pamu.h          |  194 ++++
 arch/powerpc/include/asm/fsl_secure_boot.h   |   68 ++-
 arch/powerpc/include/asm/fsl_sfp_snvs.h      |   42 +
 arch/powerpc/include/asm/immap_85xx.h        |  121 ++-
 arch/powerpc/include/asm/types.h             |    5 +-
 drivers/sec/Makefile                         |   46 +
 drivers/sec/error.c                          |  259 +++++
 drivers/sec/jobdesc.c                        |  157 +++
 drivers/sec/jr.c                             |  319 +++++
 drivers/sec/rsa_sec.c                        |   95 ++
 drivers/sec/sha.c                            |  111 ++
 include/desc.h                               | 1605 ++++++++++++++++++++++++++
 include/desc_constr.h                        |  200 ++++
 include/jobdesc.h                            |   55 +
 include/jr.h                                 |  129 ++
 include/rsa_sec.h                            |   59 +
 include/sha.h                                |  100 ++
 26 files changed, 4900 insertions(+), 4 deletions(-)
 create mode 100644 arch/powerpc/cpu/mpc85xx/cmd_esbc_validate.c
 create mode 100644 arch/powerpc/cpu/mpc85xx/fsl_sfp_snvs.c
 create mode 100644 arch/powerpc/cpu/mpc85xx/fsl_validate.c
 create mode 100644 arch/powerpc/cpu/mpc8xxx/fsl_pamu.c
 create mode 100644 arch/powerpc/cpu/mpc8xxx/fsl_pamu_table.c
 create mode 100644 arch/powerpc/include/asm/fsl_pamu.h
 create mode 100644 arch/powerpc/include/asm/fsl_sfp_snvs.h
 create mode 100644 drivers/sec/Makefile
 create mode 100644 drivers/sec/error.c
 create mode 100644 drivers/sec/jobdesc.c
 create mode 100644 drivers/sec/jr.c
 create mode 100644 drivers/sec/rsa_sec.c
 create mode 100644 drivers/sec/sha.c
 create mode 100644 include/desc.h
 create mode 100644 include/desc_constr.h
 create mode 100644 include/jobdesc.h
 create mode 100644 include/jr.h
 create mode 100644 include/rsa_sec.h
 create mode 100644 include/sha.h

--
1.7.7.6

------------------------------

Message: 4
Date: Thu, 28 Mar 2013 16:16:34 +0530
From: Ruchika Gupta <[email protected]>
Subject: [U-Boot] [PATCH 4/5] FSL SEC Driver : Add support for
descriptor creation
To: <[email protected]>, <[email protected]>
Cc: Kuldip Giroh <[email protected]>, Ruchika Gupta
<[email protected]>
Message-ID:

        <[email protected]>

Content-Type: text/plain

The patch add supports for descriptor creation for doing 1.SHA256 and RSA Modular exponentiation.
2. Cryptographic blob encryption/decryption

Following files have been picked up from caam driver in Linux :
drivers/sec/error.c
include/desc_constr.h

---
Based upon git://git.denx.de/u-boot.git branch master

 drivers/sec/Makefile  |    2 +-
 drivers/sec/error.c   |  259 +++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/sec/jobdesc.c |  157 ++++++++++++++++++++++++++++++
 drivers/sec/rsa_sec.c |   95 ++++++++++++++++++
 drivers/sec/sha.c     |  111 +++++++++++++++++++++
 include/desc_constr.h |  200 ++++++++++++++++++++++++++++++++++++++
 include/jobdesc.h     |   55 +++++++++++
 include/rsa_sec.h     |   59 +++++++++++
 include/sha.h         |  100 +++++++++++++++++++
 9 files changed, 1037 insertions(+), 1 deletions(-)
 create mode 100644 drivers/sec/error.c
 create mode 100644 drivers/sec/jobdesc.c
 create mode 100644 drivers/sec/rsa_sec.c
 create mode 100644 drivers/sec/sha.c
 create mode 100644 include/desc_constr.h
 create mode 100644 include/jobdesc.h
 create mode 100644 include/rsa_sec.h
 create mode 100644 include/sha.h
drivers/sec/Makefile +1 -1
index 33c707e..01eafba 100644
@@ -25,7 +25,7 @@ include $(TOPDIR)/config.mk
 
 LIB    := $(obj)libsec.o
 
-COBJS-$(CONFIG_SECURE_BOOT) += jr.o
+COBJS-$(CONFIG_SECURE_BOOT) += jr.o jobdesc.o sha.o rsa_sec.o error.o
 
 COBJS  := $(COBJS-y)
 SRCS   := $(COBJS:.o=.c)
drivers/sec/error.c new file +259 -0

259 lines not on this page · raw message

drivers/sec/jobdesc.c new file +157 -0

157 lines not on this page · raw message

drivers/sec/rsa_sec.c new file +95 -0

95 lines not on this page · raw message

drivers/sec/sha.c new file +111 -0

111 lines not on this page · raw message

include/desc_constr.h new file +200 -0

96 lines not on this page · raw message

include/jobdesc.h new file +55 -0

55 lines not on this page · raw message

include/rsa_sec.h new file +59 -0

59 lines not on this page · raw message

include/sha.h new file +100 -0

100 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

--
1.7.7.6

------------------------------

Message: 5
Date: Thu, 28 Mar 2013 16:16:31 +0530
From: Ruchika Gupta <[email protected]>
Subject: [U-Boot] [PATCH 1/5] arch/powerpc/cpu/mpc8xxx: PAMU driver
support
To: <[email protected]>, <[email protected]>
Cc: Kuldip Giroh <[email protected]>, Ruchika Gupta
<[email protected]>
Message-ID:

        <[email protected]>

Content-Type: text/plain

PAMU driver basic support for usage in Secure Boot. In secure boot PAMU is not in bypass mode. Hence to use any peripheral (SEC Job ring in our case), PAMU has to be configured.

The Header file fsl_pamu.h and few functions in driver have been derived from Freescale Libos.

---
Based upon git://git.denx.de/u-boot.git branch master

 arch/powerpc/cpu/mpc8xxx/Makefile     |    3 +-
 arch/powerpc/cpu/mpc8xxx/fsl_pamu.c   |  488 +++++++++++++++++++++++++++++++++
 arch/powerpc/include/asm/fsl_pamu.h   |  193 +++++++++++++
 arch/powerpc/include/asm/immap_85xx.h |   18 ++
 4 files changed, 701 insertions(+), 1 deletions(-)
 create mode 100644 arch/powerpc/cpu/mpc8xxx/fsl_pamu.c
 create mode 100644 arch/powerpc/include/asm/fsl_pamu.h
arch/powerpc/cpu/mpc8xxx/Makefile +2 -1
index 3dc8e05..097599e 100644

Lines of this file are not shown. View the raw message.

arch/powerpc/cpu/mpc8xxx/fsl_pamu.c new file +488 -0

488 lines not on this page · raw message

arch/powerpc/include/asm/fsl_pamu.h new file +193 -0

193 lines not on this page · raw message

arch/powerpc/include/asm/immap_85xx.h +18 -0
index 4eb3f79..17e0f39 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

--
1.7.7.6

------------------------------

Message: 6
Date: Thu, 28 Mar 2013 16:16:35 +0530
From: Ruchika Gupta <[email protected]>
Subject: [U-Boot] [PATCH 5/5] Added command for validation of images
in case of secure boot
To: <[email protected]>, <[email protected]>
Cc: Kuldip Giroh <[email protected]>, Ruchika Gupta
<[email protected]>
Message-ID:

        <[email protected]>

Content-Type: text/plain

1. Default environment will be used for secure boot flow which can't be edited or saved.
2. Command for secure boot is predefined in the default environment which will run on autoboot (and autoboot is the only option allowed in case of secure boot) and it looks like this:
#define CONFIG_SECBOOT \
"setenv bs_hdraddr 0xe8e00000;" \
"esbc_validate $bs_hdraddr;" \
"source $img_addr;" \
"esbc_halt;"
#endif
3. esbc_validate command is meant for validating header and signature of images (Boot Script and ESBC uboot client). SHA-256 and RSA operations are performed using SEC block in HW. This command works on both high-end (P4080) and low-end (P1010) platforms.
Command usage:
esbc_validate img_hdr_addr [pub_key_hash]
4. Boot Script can contain esbc_validate commands and bootm command. Uboot source command used in default secure boot command will run the bootscript.
5. ESBC uboot client can be linux. Additionally, rootfs and device tree blob can also be signed.
6. In the event of header or signature failure in validation, ITS and ITF bits determine further course of action.
7. In case of soft failure, appropriate error is dumped on console and next esbc_validate command is executed.
8. In case of hard failure, SoC is issued RESET REQUEST after dumping error on the console.
9. Command esbc_halt added to ensure either bootm executes after validation of images or core should just spin.

---
Based upon git://git.denx.de/u-boot.git branch master

 arch/powerpc/cpu/mpc85xx/Makefile            |    2 +
 arch/powerpc/cpu/mpc85xx/cmd_esbc_validate.c |   54 +++
 arch/powerpc/cpu/mpc85xx/cpu_init.c          |   17 +
 arch/powerpc/cpu/mpc85xx/fsl_sfp_snvs.c      |  163 ++++++++
 arch/powerpc/cpu/mpc85xx/fsl_validate.c      |  543 ++++++++++++++++++++++++++
 arch/powerpc/include/asm/fsl_secure_boot.h   |   68 ++++-
 arch/powerpc/include/asm/fsl_sfp_snvs.h      |   42 ++
 arch/powerpc/include/asm/immap_85xx.h        |   55 +++
 8 files changed, 943 insertions(+), 1 deletions(-)
 create mode 100644 arch/powerpc/cpu/mpc85xx/cmd_esbc_validate.c
 create mode 100644 arch/powerpc/cpu/mpc85xx/fsl_sfp_snvs.c
 create mode 100644 arch/powerpc/cpu/mpc85xx/fsl_validate.c
 create mode 100644 arch/powerpc/include/asm/fsl_sfp_snvs.h
arch/powerpc/cpu/mpc85xx/Makefile +2 -0
index 6776c85..66b7b67 100644

Lines of this file are not shown. View the raw message.

arch/powerpc/cpu/mpc85xx/cmd_esbc_validate.c new file +54 -0

54 lines not on this page · raw message

arch/powerpc/cpu/mpc85xx/cpu_init.c +17 -0
index de9d916..41d7bf8 100644

Lines of this file are not shown. View the raw message.

arch/powerpc/cpu/mpc85xx/fsl_sfp_snvs.c new file +163 -0

163 lines not on this page · raw message

arch/powerpc/cpu/mpc85xx/fsl_validate.c new file +543 -0

543 lines not on this page · raw message

arch/powerpc/include/asm/fsl_secure_boot.h +67 -1

68 lines not on this page · raw message

arch/powerpc/include/asm/fsl_sfp_snvs.h new file +42 -0

42 lines not on this page · raw message

arch/powerpc/include/asm/immap_85xx.h +55 -0

55 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

--
1.7.7.6

------------------------------

Message: 7
Date: Thu, 28 Mar 2013 12:15:08 +0100
From: Albert ARIBAUD <[email protected]>
Subject: Re: [U-Boot] [PATCH V2] ARM: bcm2835: fix get_timer() to
return ms
To: Stephen Warren <[email protected]>
Cc: u-boot at lists.denx.de
Message-ID: <20130328121508.34cb49f4@lilith>
Content-Type: text/plain; charset=US-ASCII

Hi Stephen,

Quoted 11 lines · Stephen Warren

Apparently, CONFIG_SYS_HZ must be 1000. Change this, and fix the timer driver to conform to this.

Have the timer implementation export a custom API get_timer_us() for use by the BCM2835 MMC API, which needs us resolution for a HW workaround.

---
v2: Export custom API get_timer_us() to allow the MMC driver to maintain
its current workaround implementation.
---

This patch and "mmc: bcm2835: fix delays in bug workaround" cannot be both applied together. Can you do a V2 for the delays fix patch too?

Amicalement,
--
Albert.

------------------------------

Message: 8
Date: Thu, 28 Mar 2013 17:19:15 +0530 (IST)
From: [email protected]
Subject: Re: [U-Boot] Splash Screen Enable in

        (u-boot-2013.01.01.tar.bz2) U-boot source code.

To: "Anatolij Gustschin" <[email protected]>
Cc: u-boot at lists.denx.de
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"

Hello,

1) Please share me, if any one used mx53loco - LVDS settings for hannstar (mcimx-lvds1) display as per the below,

setenv bootargs_base 'setenv bootargs console=ttymxc0,115200 console=tty1 video=mxcdi1fb:RGB666,TOSHIBA-XGA di1_primary ldb=single,di=1,ch1_map=SPWG'

2) And I have modified the below files and codes for splash screen support for mx53loco as per the mx6qsabrelite.c. Please correct me, if I wrong.

File Name: mx53loco.h

Included:
#define CONFIG_SPLASH_SCREEN
#define CONFIG_SPLASH_SCREEN_ALIGN
#define CONFIG_SPLASH_SCREEN_LVDS
#define CONFIG_CMD_BMP

File Name: mx53loco_video.c

Include:
static struct fb_videomode const mcimx_lvds1 = {
.name = "Hannstar-XGA",
.refresh = 60,

 .xres        = 1024,
 .yres        = 768,
 .pixclock    = 15385,
 .left_margin    = 220,
 .right_margin    = 40,
 .upper_margin    = 21,
 .lower_margin    = 7,

.hsync_len = 60,
.vsync_len = 10,
.sync = 4,
};

int board_video_skip(void)
{
int ret;
char const *e = getenv("panel");

printf("Display Panel Name: %s\n", e);

if (e) {
if (strcmp(e, "seiko") == 0) {
ret = ipuv3_fb_init(&seiko_wvga, 0, IPU_PIX_FMT_RGB24); if (ret)
printf("Seiko cannot be configured: %d\n", ret); return ret;
}
else if (strcmp(e, "Hannstar-XGA") == 0) {
ret = ipuv3_fb_init(&mcimx_lvds1, 0, IPU_PIX_FMT_LVDS666); if (ret)
printf("MCIMX_LVDS1 cannot be configured: %d\n", ret); return ret;
}
}

/*
* 'panel' env variable not found or has different value than 'seiko'
* Defaulting to claa lcd.
*/
ret = ipuv3_fb_init(&claa_wvga, 0, IPU_PIX_FMT_RGB565); if (ret)
printf("CLAA cannot be configured: %d\n", ret);
return ret;
}

And I tried the below command. But not get the correct output (SPLASH Image) through U-Boot.

MX53LOCO U-Boot > tftp 100000 /tftpboot/lvds.bmp Using FEC device
TFTP from server 192.168.1.176; our IP address is 192.168.1.189 Filename '/tftpboot/lvds.bmp'.
Load address: 0x100000
Loading: T T T T T

Please give your suggestion and solution ASAP.

Note: I am trying to display from SD-card.

Thanks & Regards,
Nandakumar R.

-----Original Message-----
From: "Anatolij Gustschin" <[email protected]>
Sent: Tuesday, 26 March, 2013 13:00
To: nandakumar.ramaswamy at pricoltech.com
Cc: "Jens Scharsig" <[email protected]>, u-boot at lists.denx.de
Subject: Re: [U-Boot] Splash Screen Enable in (u-boot-2013.01.01.tar.bz2) U-boot source code.

Hello,

On Tue, 26 Mar 2013 11:46:10 +0530 (IST)
nandakumar.ramaswamy at pricoltech.com wrote:
...

Quoted 4 lines

Actually I tried with U-Boot latest release (u-boot-2013.01.01.tar.bz2) also.But I am not able to see the SPLASH SCREEN.
So, please share the SPLASH SCREEN image enable procedure for latest U-boot (u-boot-2013.01.01.tar.bz2) source code for i.mx53loco.

U-Boot release 2013.01.01 for mx53loco supports two LCD panels, CLAA07LC0ACW and Seiko-43WVF1G. If you have a different panel, you will have to add support for it. If you have Seiko panel, please set up environment variable panel as follows:

=> setenv panel seiko
=> saveenv

and reboot, then use load a bmp file and use "bmp" command to display it.

Thanks,

Anatolij

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-50 Fax: +49-8142-66989-80 Email: office at denx.de

Disclaimer:
This e-mail, and any files transmitted with it are "Pricol Technologies Confidential" and intended solely for the use of the individual or entity to whom it is addressed. Any copying, dissemination, disclosure or use of its contents is prohibited. If you have received this e-mail in error, please discard the message and notify us at itsupport at pricoltech.com directly. E-mail communication is not guaranteed to be secure, error or virus-free. They are capable of interception, corruption and delays. Anyone communicating with us via e-mail accepts the risks of e-mail communications and their consequences.

------------------------------

Message: 9
Date: Thu, 28 Mar 2013 13:18:33 +0100
From: " Andreas Bie?mann " <[email protected]>
Subject: Re: [U-Boot] Splash Screen Enable in

        (u-boot-2013.01.01.tar.bz2) U-boot source code.

To: nandakumar.ramaswamy at pricoltech.com
Cc: u-boot at lists.denx.de
Message-ID: <[email protected]>
Content-Type: text/plain; charset=ISO-8859-1

Dear nandakumar.ramaswamy at pricoltech.com,

please stop TOFU [1].

Quoted 2 lines · nandakumar.ramaswamy at pricoltech.com

Hello,

<snip>

Quoted 10 lines

And I tried the below command. But not get the correct output (SPLASH Image) through U-Boot.

MX53LOCO U-Boot > tftp 100000 /tftpboot/lvds.bmp Using FEC device
TFTP from server 192.168.1.176; our IP address is 192.168.1.189 Filename '/tftpboot/lvds.bmp'.
Load address: 0x100000
Loading: T T T T T

Please give your suggestion and solution ASAP.

please read about asking smart questions [2].

Quoted 1 line

Note: I am trying to display from SD-card.

So why you try to read data via tftp? How about fatload or ext2load?

As Anatolij pointed out you need to use the bmp command to display some memory range which contains the BMP image.
To get the BMP image there you can use tftp, however your server (192.168.1.176) seems not to provide the image (/tftpboot/lvds.bmp), cause it runs always in timeout.
Just my 2?, sorry, I can not help you with the i.mx and lcd setup.

Best regards

Andreas Bie?mann

[1] http://www.vranx.de/mail/tofu.html
[2] http://www.catb.org/esr/faqs/smart-questions.html#urgent

------------------------------

Message: 10
Date: Thu, 28 Mar 2013 15:45:54 +0800
From: Hung-ying Tyan <[email protected]>
Subject: [U-Boot] [PATCH v3 1/7] cros: add cros_ec driver
To: U-Boot Mailing List <[email protected]>
Cc: Vincent Palatin <[email protected]>, Gabe Black
<[email protected]>, Bill Richardson <[email protected]>,
Randall Spangler <[email protected]>, Sean Paul
<[email protected]>, Tom Rini <[email protected]>, Louis Yung-Chieh Lo
<[email protected]>
Message-ID: <[email protected]>

This patch adds the cros_ec driver that implements the protocol for communicating with Google's ChromeOS embedded controller.

---
Changes in v3: None
Changes in v2:
- Fixed warnings of exceeding 80 chars in a line.
- Added commit message.
- Dropped the period from commit subject.

 doc/device-tree-bindings/input/cros-ec-keyb.txt |   79 ++
 doc/device-tree-bindings/misc/cros-ec.txt       |   38 +
 doc/device-tree-bindings/spi/exynos-spi.txt     |   55 +
 drivers/misc/Makefile                           |    1 +
 drivers/misc/cros_ec.c                          | 1304 ++++++++++++++++++++
 include/cros_ec.h                               |  449 +++++++
 include/cros_ec_message.h                       |   44 +
 include/ec_commands.h                           | 1440 +++++++++++++++++++++++
 include/fdtdec.h                                |    1 +
 lib/fdtdec.c                                    |    1 +
 10 files changed, 3412 insertions(+)
 create mode 100644 doc/device-tree-bindings/input/cros-ec-keyb.txt
 create mode 100644 doc/device-tree-bindings/misc/cros-ec.txt
 create mode 100644 doc/device-tree-bindings/spi/exynos-spi.txt
 create mode 100644 drivers/misc/cros_ec.c
 create mode 100644 include/cros_ec.h
 create mode 100644 include/cros_ec_message.h
 create mode 100644 include/ec_commands.h
doc/device-tree-bindings/input/cros-ec-keyb.txt new file +79 -0

79 lines not on this page · raw message

doc/device-tree-bindings/misc/cros-ec.txt new file +38 -0
new file mode 100644
index 0000000..07ea7cd

Lines of this file are not shown. View the raw message.

doc/device-tree-bindings/spi/exynos-spi.txt new file +55 -0

55 lines not on this page · raw message

drivers/misc/Makefile +1 -0
index 8cdc3b6..33fe822 100644

Lines of this file are not shown. View the raw message.

drivers/misc/cros_ec.c new file +1304 -0

1,304 lines not on this page · raw message

include/cros_ec.h new file +449 -0

449 lines not on this page · raw message

include/cros_ec_message.h new file +44 -0

44 lines not on this page · raw message

include/ec_commands.h new file +1440 -0

1,440 lines not on this page · raw message

include/fdtdec.h +1 -0
index 51ff266..0f4bbaa 100644

Lines of this file are not shown. View the raw message.

lib/fdtdec.c +1 -0
index 856f90c..24cd6f9 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

--
1.8.1.3

------------------------------

Message: 11
Date: Thu, 28 Mar 2013 09:58:57 -0300
From: Fabio Estevam <[email protected]>
Subject: Re: [U-Boot] Splash Screen Enable in

        (u-boot-2013.01.01.tar.bz2) U-boot source code.

To: nandakumar.ramaswamy at pricoltech.com
Cc: u-boot at lists.denx.de
Message-ID:
<CAOMZO5Cc9oM1Ewz69MjszUpN0ioiDDMed7pDDrA_LDdrBaY3ZA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8

Quoted 7 lines · On Tue, Mar 26, 2013 at 3:16 AM, <[email protected]> wrote:

Hello Jens,

Thanks for your quick response.

Actually I tried with U-Boot latest release (u-boot-2013.01.01.tar.bz2) also.But I am not able to see the SPLASH SCREEN. So, please share the SPLASH SCREEN image enable procedure for latest U-boot (u-boot-2013.01.01.tar.bz2) source code for i.mx53loco.

If you connect the CLAA WVGA panel to mx53loco, the penguin logo and U-boot version will be displayed by default.

LVDS panel has not been added yet, and that should be a simple task. Please refer to the mx53ard board in FSL U-boot:
http://git.freescale.com/git/cgit.cgi/imx/uboot-imx.git/tree/board/freescale/mx53_ard/mx53_ard.c?h=imx_v2009.08

Basically you need to pass the LVDS display timings, setup the LVDS clocks and register the LVDS panel with the correct color format.

And please post your patches to the list once you add the LVDS support :-)

Regards,

Fabio Estevam

------------------------------

Message: 12
Date: Thu, 28 Mar 2013 10:03:43 -0300
From: Fabio Estevam <[email protected]>
Subject: Re: [U-Boot] Splash Screen Enable in

        (u-boot-2013.01.01.tar.bz2) U-boot source code.

To: nandakumar.ramaswamy at pricoltech.com
Cc: u-boot at lists.denx.de
Message-ID:
<CAOMZO5B=jMSZqHnXbo7d3R6ZSKoJGUU7XOc6ta0W5haxw7mSTQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8

Quoted 5 lines · On Thu, Mar 28, 2013 at 8:49 AM, <[email protected]> wrote:

Hello,

1) Please share me, if any one used mx53loco - LVDS settings for hannstar (mcimx-lvds1) display as per the below,

Quoted 8 lines

setenv bootargs_base 'setenv bootargs console=ttymxc0,115200 console=tty1 video=mxcdi1fb:RGB666,TOSHIBA-XGA di1_primary ldb=single,di=1,ch1_map=SPWG'

2) And I have modified the below files and codes for splash screen support for mx53loco as per the mx6qsabrelite.c. Please correct me, if I wrong.

File Name: mx53loco.h

Included:
#define CONFIG_SPLASH_SCREEN

This is already part of include/configs/mx53loco.h

Please post your changes in the format of a patch so that we can understand exactly what you are changing.

Also, please make sure that the backlight is turned on.

On my previous email the mx53ard code I pointed you to uses PWM to drive the backlight, you could simply use a GPIO instead.

------------------------------

Message: 13
Date: Thu, 28 Mar 2013 14:38:23 +0100
From: Albert ARIBAUD <[email protected]>
Subject: [U-Boot] Merge conflict on Tegra SPI between u-boot/master
and u-boot-arm/master
To: U-Boot <[email protected]>
Cc: Tom Rini <[email protected]>, Tom Warren <[email protected]>
Message-ID: <20130328143823.7cb30d58@lilith>
Content-Type: text/plain; charset=US-ASCII

Hello all,

While preparing for an ARM PR, specifically a merge between commit 417c55803118eb8e350d5ab8ba6583fb39f4e2e3 (current u-boot/master ToT) and commit d53e340edf65ff253d3a7b06ebe60501045892e3 (current Tot for u-boot-arm/master), I hit the following merge conflicts:

CONFLICT (content): Merge conflict in lib/fdtdec.c CONFLICT (content): Merge conflict in include/fdtdec.h CONFLICT (content): Merge conflict in drivers/spi/tegra20_sflash.c

While the first two, related to FDT, are simple (colliding additions to the same enum from both branches) and can be manually resolved, the third one, drivers/spi/tegra20_sflash.c, is not, and can not, at least, not by me, as I am not a specialist on Tegra SPI.

Tom (Warren), can you advise on how to best solve this?

Amicalement,
--
Albert.

------------------------------

Message: 14
Date: Thu, 28 Mar 2013 14:41:45 +0100
From: Anatolij Gustschin <[email protected]>
Subject: Re: [U-Boot] Splash Screen Enable in

        (u-boot-2013.01.01.tar.bz2) U-boot source code.

To: nandakumar.ramaswamy at pricoltech.com
Cc: u-boot at lists.denx.de
Message-ID: <20130328144145.69c8f532@crub>
Content-Type: text/plain; charset=US-ASCII

Hello,

Quoted 5 lines · On Thu, 28 Mar 2013 17:19:15 +0530 (IST) nandakumar.ramaswamy at…

Hello,

1) Please share me, if any one used mx53loco - LVDS settings for hannstar (mcimx-lvds1) display as per the below,

I've never used mx53loco board, also I never used a hannstar display. The proper support for it is missing in U-Boot.

Also please restrict the line length in the email text to max. 72 characters and do not top post. Thanks!

Quoted 5 lines

setenv bootargs_base 'setenv bootargs console=ttymxc0,115200 console=tty1 video=mxcdi1fb:RGB666,TOSHIBA-XGA di1_primary ldb=single,di=1,ch1_map=SPWG'

2) And I have modified the below files and codes for splash screen support for mx53loco as per the mx6qsabrelite.c. Please correct me, if I wrong.

Did you set "panel" environment variable to "Hannstar-XGA" and saved the environment ? You are adding a check for it in the board code, you also have to set this variable and save it to the environment, then you have to reset the board so the new setting will take effect.

Quoted 6 lines

File Name: mx53loco.h

Included:
#define CONFIG_SPLASH_SCREEN
#define CONFIG_SPLASH_SCREEN_ALIGN
#define CONFIG_SPLASH_SCREEN_LVDS

Why do you add CONFIG_SPLASH_SCREEN_LVDS here ? This configuration option is not available anywhere, at least in mainline U-Boot code.

Quoted 52 lines

#define CONFIG_CMD_BMP

File Name: mx53loco_video.c

Include:
static struct fb_videomode const mcimx_lvds1 = {
.name = "Hannstar-XGA",
.refresh = 60,

 .xres        = 1024,
 .yres        = 768,
 .pixclock    = 15385,
 .left_margin    = 220,
 .right_margin    = 40,
 .upper_margin    = 21,
 .lower_margin    = 7,

.hsync_len = 60,
.vsync_len = 10,
.sync = 4,
};

int board_video_skip(void)
{
int ret;
char const *e = getenv("panel");

printf("Display Panel Name: %s\n", e);

if (e) {
if (strcmp(e, "seiko") == 0) {
ret = ipuv3_fb_init(&seiko_wvga, 0, IPU_PIX_FMT_RGB24); if (ret)
printf("Seiko cannot be configured: %d\n", ret); return ret;
}
else if (strcmp(e, "Hannstar-XGA") == 0) {
ret = ipuv3_fb_init(&mcimx_lvds1, 0, IPU_PIX_FMT_LVDS666); if (ret)
printf("MCIMX_LVDS1 cannot be configured: %d\n", ret); return ret;
}
}

/*
* 'panel' env variable not found or has different value than 'seiko'
* Defaulting to claa lcd.
*/
ret = ipuv3_fb_init(&claa_wvga, 0, IPU_PIX_FMT_RGB565); if (ret)
printf("CLAA cannot be configured: %d\n", ret);
return ret;
}

Quoted 2 lines

And I tried the below command. But not get the correct output (SPLASH Image) through U-Boot.

Your extensions are not enough, I'm afraid. You probably also have to configure the pin mux for LVDS interface, enable the backlight of the display, configure the backlight intensity, etc. I'm not familiar with mx53loco, I cannot guide you what is all needed to make video support over LVDS working. Please read the schematics of the board and mx53 manual and make sure you understand what is needed to configure LVDS interface and backlight properly. Then add appropriate code.

Quoted 10 lines

MX53LOCO U-Boot > tftp 100000 /tftpboot/lvds.bmp Using FEC device
TFTP from server 192.168.1.176; our IP address is 192.168.1.189 Filename '/tftpboot/lvds.bmp'.
Load address: 0x100000
Loading: T T T T T

Please give your suggestion and solution ASAP.

Note: I am trying to display from SD-card.

Why are you trying to load the bmp file from network then? Do you have a working tftp server for this purpose?

If you have the bmp files on the SD-card, then you have to use appropriate commands to load files from the card, like "mmc rescan", "fatload mmc 0:0 <addr> <filename.bmp>" or similar. Only after the file has been successfully loaded to the address <addr>, you can use "bmp display <addr>" command.

Thanks,

Anatolij

------------------------------

Message: 15
Date: Thu, 28 Mar 2013 10:14:16 -0400
From: Akshay Saraswat <[email protected]>
Subject: Re: [U-Boot] [PATCH 1/9 v2] Exynos: Change get_timer() to
work correctly
To: u-boot at lists.denx.de, mk7.kang at samsung.com
Cc: prashanth.g at samsung.com
Message-ID: <[email protected]>

Thanks for your comments.
Please find the reply corresponding to comments below.

Quoted 12 lines

Dear Akshay,

Quoted 9 lines · Akshay Saraswat

At present get_timer() does not return sane values. It should count up smoothly in milliscond intervals.

arch/arm/cpu/armv7/s5p-common/pwm.c +0 -0
index 44d7bc3..3147f59 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 10 lines

arch/arm/cpu/armv7/s5p-common/pwm.c

Quoted 8 lines
arch/arm/cpu/armv7/s5p-common/pwm.c +6 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

is it workaround?

Yes, this is a part of workaround to get appropriate ticks.

Quoted 27 lines
Quoted 27 lines
arch/arm/cpu/armv7/s5p-common/pwm.c +0 -0

Lines of this file are not shown. View the raw message.

arch/arm/cpu/armv7/s5p-common/timer.c +15 -0
index e78c716..c48a297 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 8 lines

arch/arm/cpu/armv7/s5p-common/timer.c

Quoted 5 lines
arch/arm/cpu/armv7/s5p-common/timer.c +1 -1

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

There are special reason to change the div value?
Please let me know.

We wish to count down at 1MHz, providing a resolution of 1us. This becomes possible with MUX_DIV_4 for timer 4, since, exynos 5250 manual says that for 4-bit divider settings at 1/4 (PCLK = 66 MHz ), we get 66637.07 seconds interval.

Quoted 38 lines
Quoted 38 lines
arch/arm/cpu/armv7/s5p-common/timer.c +0 -34

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 8 lines

arch/arm/cpu/armv7/s5p-common/timer.c

Quoted 6 lines
arch/arm/cpu/armv7/s5p-common/timer.c +4 -2

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

why convert to int?

To avoid side effects of compiler optimizations.

Quoted 9 lines
Quoted 9 lines
arch/arm/cpu/armv7/s5p-common/timer.c +1 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 13 lines

arch/arm/cpu/armv7/s5p-common/timer.c

Quoted 10 lines
arch/arm/cpu/armv7/s5p-common/timer.c +0 -7

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Thanks,
Minkyu Kang.

Regards,
Akshay Saraswat

------------------------------

Message: 16
Date: Thu, 28 Mar 2013 06:58:21 -0700
From: Eric Nelson <[email protected]>
Subject: Re: [U-Boot] [PATCH v2] mx6: Fix get_board_rev() for the mx6
solo case
To: Fabio Estevam <[email protected]>
Cc: u-boot at lists.denx.de, dirk.behme at de.bosch.com
Message-ID: <[email protected]>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed

Quoted 17 lines · Fabio Estevam

When booting a Freescale kernel 3.0.35 on a Wandboard solo, the get_board_rev() returns 0x62xxx, which is not a value understood by the VPU
(Video Processing Unit) library in the kernel and causes the video playback to fail.

The expected values for get_board_rev are:
0x63xxx: For mx6quad/dual
0x61xxx: For mx6dual-lite/solo

So adjust get_board_rev() accordingly and make it as weak function, so that we do not need to define it in every mx6 board file.

---
Changes since v1:
- Avoid extra call to get_cpu_rev()

Quoted 7 lines
  arch/arm/cpu/armv7/mx6/soc.c                  |   12 ++++++++++++
  board/boundary/nitrogen6x/nitrogen6x.c        |    5 -----
  board/freescale/mx6qsabrelite/mx6qsabrelite.c |    5 -----
  board/freescale/mx6qsabresd/mx6qsabresd.c     |    5 -----
  board/wandboard/wandboard.c                   |    5 -----
  5 files changed, 12 insertions(+), 20 deletions(-)

------------------------------

Message: 17
Date: Thu, 28 Mar 2013 10:20:38 -0400
From: Akshay Saraswat <[email protected]>
Subject: Re: [U-Boot] [PATCH 3/9 v2] Exynos: pwm: Fix two bugs in the
exynos pwm configuration code
To: u-boot at lists.denx.de, mk7.kang at samsung.com
Cc: prashanth.g at samsung.com
Message-ID: <[email protected]>

Hi Minkyu,

Thanks for your comments.

Quoted 29 lines

Dear Akshay,

arch/arm/cpu/armv7/s5p-common/timer.c

Quoted 22 lines · Akshay Saraswat

First, the "div" value was being used incorrectly to compute the frequency of the PWM timer. The value passed in is a constant which reflects the value that would be found in a configuration register, 0 to 4. That should correspond to a scaling factor of 1, 2, 4, 8, or 16, 1 << div, but div + 1 was being used instead.

arch/arm/cpu/armv7/s5p-common/timer.c +10 -2

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

good catch. thanks.

Quoted 1 line
Quoted 5 lines

arch/arm/cpu/armv7/s5p-common/timer.c

Quoted 2 lines
arch/arm/cpu/armv7/s5p-common/timer.c +1 -1

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

why don't you use CONFIG_SYS_HZ?
pwm_hz seems to constant.

CONFIG_SYS_HZ may change with boards and as per needs. But requirement here is for a constant value 1000 for all calculations which should remain 1000 only. That's why using pwm_hz and not CONFIG_SYS_HZ.

Quoted 14 lines
Quoted 14 lines
arch/arm/cpu/armv7/s5p-common/timer.c +2 -6

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 7 lines
Quoted 3 lines
     val = readl(&pwm->tcon) & ~(0xf << TCON_OFFSET(pwm_id));
     if (invert && (pwm_id < 4))

Thanks,
Minkyu Kang.

Regards,
Akshay Saraswat

------------------------------

Message: 18
Date: Thu, 28 Mar 2013 10:29:14 -0400
From: Akshay Saraswat <[email protected]>
Subject: Re: [U-Boot] [PATCH 4/9 v2] Exynos: Avoid a divide by zero by
specifying a non-zero period for pwm 4
To: u-boot at lists.denx.de, mk7.kang at samsung.com
Cc: prashanth.g at samsung.com
Message-ID: <[email protected]>

Minkyu,

Thanks for comments.
Please find my reply below the comment.

Quoted 25 lines · Akshay Saraswat
Quoted 4 lines

The pwm_config function in the exynos pwm driver divides by its period period parameter. A function was calling pwm_config with a 0ns period and a 0ns duty cycle. That doesn't actually make any sense physically, and results in a divide by zero in the driver. This change changes the paremters to be a

typo.
paremters -> parameter

Quoted 16 lines

100000ns period and duty cycle.

Test with command "sf probe 1:0; time sf read 40008000 0 1000". Try with different numbers of bytes and see that sane values are obtained Build and boot U-boot with this patch, backlight works properly.

---
Changes since v1:
- Added "Acked-by: Simon Glass".

 arch/arm/cpu/armv7/s5p-common/timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

arch/arm/cpu/armv7/s5p-common/timer.c

Quoted 10 lines
arch/arm/cpu/armv7/s5p-common/timer.c +1 -1
index de61405..6a0fa58 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

0 is a numerator.
I think.. it doesn't matter.

In file pwm.c line 98 we are doing:
frequency = NS_IN_SEC / period_ns;

what we are passing in this call are the values of duty_ns and period_ns. So, there are places where divide by zero may occur.
I think we should keep it to be on a safer side.

Quoted 9 lines

arch/arm/cpu/armv7/s5p-common/timer.c

Quoted 5 lines
arch/arm/cpu/armv7/s5p-common/timer.c +0 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Thanks,
Minkyu Kang.

Regards,
Akshay Saraswat

------------------------------

Message: 19
Date: Thu, 28 Mar 2013 10:32:14 -0400
From: Akshay Saraswat <[email protected]>
Subject: [U-Boot] [PATCH 00/11 v3] Fix and Re-organise PWM Timer
To: u-boot at lists.denx.de, mk7.kang at samsung.com
Cc: prashanth.g at samsung.com
Message-ID: <[email protected]>

This patch set tries to fix few bugs in timer and re-organises PWM clock code.

Changes since v2:
- Patch-1: New patch.
- Patch-2: None.
- Patch-3: None.
- Patch-4: None.
- Patch-5: Fixed typo paremters in commit message.
- Patch-6: None.
- Patch-7: Added "Acked-by: Simon Glass".
- Patch-8:
Fixed typo peripherial to peripheral.
- Made exynos5_get_periph_rate static.
- Added an empty line.
- Replaced "enum periph_id" with "int" in function arguments.
- Removed "#include <asm/arch/periph.h>" from clk.h.
- Added "Acked-by: Simon Glass".
- Patch-9: None.
- Patch-10:
- Replaced "exynos5_get_pwm_clk" with "clock_get_periph_rate" in get_pwm_clk instead of replacing everywhere.
- Added "Acked-by: Simon Glass".
- Patch-11: New patch.

Changes since v1:
- Patch-1: Added "Acked-by: Simon Glass".
- Patch-2: Added "Acked-by: Simon Glass".
- Patch-3: Added "Acked-by: Simon Glass".
- Patch-4: Added "Acked-by: Simon Glass".
- Patch-5: Added "Acked-by: Simon Glass".
- Patch-6: None.
- Patch-7: Fixed few nits.
- Patch-8: Added "Acked-by: Simon Glass".
- Patch-9: Restored get_pwm_clk call in case of non-exynos5 cpu.

Akshay Saraswat (11):
Exynos5: config: enable time command
Exynos: Change get_timer() to work correctly
Exynos: Add timer_get_us function
Exynos: pwm: Fix two bugs in the exynos pwm configuration code
Exynos: Avoid a divide by zero by specifying a non-zero period
for pwm 4
Exynos: Tidy up the pwm_config function in the exynos pwm driver
Exynos: Add peripherial id for pwm
Exynos: clock: Add generic api to get the clk freq
Exynos: clock: Correct pwm source clk selection
Exynos: pwm: Use generic api to get pwm clk freq
Exynos: pwm: Remove dead code of function exynos5_get_pwm_clk

 arch/arm/cpu/armv7/exynos/clock.c         | 167 ++++++++++++++++++++++++++----
 arch/arm/cpu/armv7/s5p-common/pwm.c       |  42 ++++----
 arch/arm/cpu/armv7/s5p-common/timer.c     | 117 ++++++++++-----------
 arch/arm/include/asm/arch-exynos/clk.h    |  15 +++
 arch/arm/include/asm/arch-exynos/periph.h |   5 +
 board/samsung/smdk5250/setup.h            |   2 +-
 include/configs/exynos5250-dt.h           |   3 +
 7 files changed, 244 insertions(+), 107 deletions(-)

--
1.8.0

------------------------------

Message: 20
Date: Thu, 28 Mar 2013 10:32:15 -0400
From: Akshay Saraswat <[email protected]>
Subject: [U-Boot] [PATCH 01/11 v3] Exynos5: config: enable time
command
To: u-boot at lists.denx.de, mk7.kang at samsung.com
Cc: prashanth.g at samsung.com
Message-ID: <[email protected]>

This patch enables time command.

---
Chnages since v2:
- New patch.

 include/configs/exynos5250-dt.h | 3 +++
 1 file changed, 3 insertions(+)
include/configs/exynos5250-dt.h +3 -0
index 2b9d6ac..b13aade 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

--
1.8.0

------------------------------

Message: 21
Date: Thu, 28 Mar 2013 10:32:16 -0400
From: Akshay Saraswat <[email protected]>
Subject: [U-Boot] [PATCH 02/11 v3] Exynos: Change get_timer() to work
correctly
To: u-boot at lists.denx.de, mk7.kang at samsung.com
Cc: prashanth.g at samsung.com
Message-ID: <[email protected]>

From: Simon Glass <[email protected]>

At present get_timer() does not return sane values. It should count up smoothly in milliscond intervals.

We can change the PWM to count down at 1MHz, providing a resolution of 1us and a range of about an hour between required get_timer() calls.

Test with command "sf probe 1:0; time sf read 40008000 0 1000". Try with different numbers of bytes and see that sane values are obtained

---
Changes since v2:
- None.

Changes since v1:
- Added "Acked-by: Simon Glass".

 arch/arm/cpu/armv7/s5p-common/pwm.c   |   6 ++
 arch/arm/cpu/armv7/s5p-common/timer.c | 100 +++++++++++++---------------------
 2 files changed, 44 insertions(+), 62 deletions(-)
arch/arm/cpu/armv7/s5p-common/pwm.c +6 -0
index 44d7bc3..3147f59 100644

Lines of this file are not shown. View the raw message.

arch/arm/cpu/armv7/s5p-common/timer.c +38 -62

100 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

--
1.8.0

------------------------------

Message: 22
Date: Thu, 28 Mar 2013 10:32:17 -0400
From: Akshay Saraswat <[email protected]>
Subject: [U-Boot] [PATCH 03/11 v3] Exynos: Add timer_get_us function
To: u-boot at lists.denx.de, mk7.kang at samsung.com
Cc: prashanth.g at samsung.com
Message-ID: <[email protected]>

From: Che-Liang Chiou <[email protected]>

timer_get_us returns the time in microseconds since a certain reference point of history. However, it does not guarantee to return an accurate time after a long period; instead, it wraps around (that is, the reference point is reset to some other point of history) after some periods. The frequency of wrapping around is about an hour (or 2^32 microseconds).

Test with command "sf probe 1:0; time sf read 40008000 0 1000". Try with different numbers of bytes and see that sane values are obtained

---
Changes since v2:
- None.

Changes since v1:
- Added "Acked-by: Simon Glass".

 arch/arm/cpu/armv7/s5p-common/timer.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
arch/arm/cpu/armv7/s5p-common/timer.c +15 -0
index c48a297..de61405 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

--
1.8.0

------------------------------

Message: 23
Date: Thu, 28 Mar 2013 10:32:18 -0400
From: Akshay Saraswat <[email protected]>
Subject: [U-Boot] [PATCH 04/11 v3] Exynos: pwm: Fix two bugs in the
exynos pwm configuration code
To: u-boot at lists.denx.de, mk7.kang at samsung.com
Cc: prashanth.g at samsung.com
Message-ID: <[email protected]>

From: Gabe Black <[email protected]>

First, the "div" value was being used incorrectly to compute the frequency of the PWM timer. The value passed in is a constant which reflects the value that would be found in a configuration register, 0 to 4. That should correspond to a scaling factor of 1, 2, 4, 8, or 16, 1 << div, but div + 1 was being used instead.

Second, the reset value of the timers were being calculated to give an overall frequency, thrown out, and set to a maximum value. This was done so that PWM 4 could be used as the system clock by counting down from a high value, but it was applied indiscriminantly. It should at most be applied only to PWM 4.

This change also takes the opportunity to tidy up the pwm_init function.

Test with command "sf probe 1:0; time sf read 40008000 0 1000". Try with different numbers of bytes and see that sane values are obtained Build and boot U-boot with this patch, backlight works properly.

---
Changes since v2:
- None.

Changes since v1:
- Added "Acked-by: Simon Glass".

 arch/arm/cpu/armv7/s5p-common/pwm.c | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)
arch/arm/cpu/armv7/s5p-common/pwm.c +14 -10
index 3147f59..02156d1 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

--
1.8.0

------------------------------

Message: 24
Date: Thu, 28 Mar 2013 10:32:19 -0400
From: Akshay Saraswat <[email protected]>
Subject: [U-Boot] [PATCH 05/11 v3] Exynos: Avoid a divide by zero by
specifying a non-zero period for pwm 4
To: u-boot at lists.denx.de, mk7.kang at samsung.com
Cc: prashanth.g at samsung.com
Message-ID: <[email protected]>

From: Gabe Black <[email protected]>

The pwm_config function in the exynos pwm driver divides by its period period parameter. A function was calling pwm_config with a 0ns period and a 0ns duty cycle. That doesn't actually make any sense physically, and results in a divide by zero in the driver. This change changes the parameters to be a 100000ns period and duty cycle.

Test with command "sf probe 1:0; time sf read 40008000 0 1000". Try with different numbers of bytes and see that sane values are obtained Build and boot U-boot with this patch, backlight works properly.

---
Changes since v2:
- Fixed typo paremters in commit message.

Changes since v1:
- Added "Acked-by: Simon Glass".

 arch/arm/cpu/armv7/s5p-common/timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/cpu/armv7/s5p-common/timer.c +1 -1
index de61405..6a0fa58 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

--
1.8.0

------------------------------

Message: 25
Date: Thu, 28 Mar 2013 10:32:21 -0400
From: Akshay Saraswat <[email protected]>
Subject: [U-Boot] [PATCH 08/11 v3] Exynos: clock: Add generic api to
get the clk freq
To: u-boot at lists.denx.de, mk7.kang at samsung.com
Cc: prashanth.g at samsung.com
Message-ID: <[email protected]>

From: Padmavathi Venna <[email protected]>

Add generic api to get the frequency of the required peripherial. This API gets the source clock frequency and returns the required frequency by dividing with first and second dividers based on the requirement.

Test with command "sf probe 1:0; time sf read 40008000 0 1000". Try with different numbers of bytes and see that sane values are obtained Build and boot U-boot with this patch, backlight works properly.

---
Changes since v2:
- Fixed typo peripherial to peripheral.
- Made exynos5_get_periph_rate static.
- Added an empty line.
- Replaced "enum periph_id" with "int" in function arguments.
- Removed "#include <asm/arch/periph.h>" from clk.h.
- Added "Acked-by: Simon Glass".

Changes since v1:
- Fixed few nits.

 arch/arm/cpu/armv7/exynos/clock.c      | 144 +++++++++++++++++++++++++++++++++
 arch/arm/include/asm/arch-exynos/clk.h |  15 ++++
 2 files changed, 159 insertions(+)
arch/arm/cpu/armv7/exynos/clock.c +144 -0

144 lines not on this page · raw message

arch/arm/include/asm/arch-exynos/clk.h +15 -0
index 1935b0b..73f8063 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

--
1.8.0

------------------------------

Message: 26
Date: Thu, 28 Mar 2013 10:32:22 -0400
From: Akshay Saraswat <[email protected]>
Subject: [U-Boot] [PATCH 09/11 v3] Exynos: clock: Correct pwm source
clk selection
To: u-boot at lists.denx.de, mk7.kang at samsung.com
Cc: prashanth.g at samsung.com
Message-ID: <[email protected]>

From: Padmavathi Venna <[email protected]>

MPLL is selected as the source clk of pwm by default

Test with command "sf probe 1:0; time sf read 40008000 0 1000". Try with different numbers of bytes and see that sane values are obtained Build and boot U-boot with this patch, backlight works properly.

---
Changes since v2:
- None.

Changes since v1:
- Added "Acked-by: Simon Glass".

 board/samsung/smdk5250/setup.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/samsung/smdk5250/setup.h +1 -1
index a159601..34d8bc3 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

--
1.8.0

------------------------------

Message: 27
Date: Thu, 28 Mar 2013 10:32:24 -0400
From: Akshay Saraswat <[email protected]>
Subject: [U-Boot] [PATCH 11/11 v3] Exynos: pwm: Remove dead code of
function exynos5_get_pwm_clk
To: u-boot at lists.denx.de, mk7.kang at samsung.com
Cc: prashanth.g at samsung.com
Message-ID: <[email protected]>

As we shall now be using clock_get_periph_rate function. We find no reason for keeping code in function exynos5_get_pwm_clk. Hence, removing it.

---
Changes since v2:
- New patch.

 arch/arm/cpu/armv7/exynos/clock.c | 21 ---------------------
 1 file changed, 21 deletions(-)
arch/arm/cpu/armv7/exynos/clock.c +0 -21
index 1e54e47..223660a 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

--
1.8.0

------------------------------

Message: 28
Date: Thu, 28 Mar 2013 10:32:23 -0400
From: Akshay Saraswat <[email protected]>
Subject: [U-Boot] [PATCH 10/11 v3] Exynos: pwm: Use generic api to get
pwm clk freq
To: u-boot at lists.denx.de, mk7.kang at samsung.com
Cc: prashanth.g at samsung.com
Message-ID: <[email protected]>

From: Padmavathi Venna <[email protected]>

Use generic api to get the pwm clock frequency

Test with command "sf probe 1:0; time sf read 40008000 0 1000". Try with different numbers of bytes and see that sane values are obtained Build and boot U-boot with this patch, backlight works properly.

---
Changes since v2:
- Replaced "exynos5_get_pwm_clk" with "clock_get_periph_rate" in get_pwm_clk instead of replacing everywhere.
- Added "Acked-by: Simon Glass".

Changes since v1:
- Restored get_pwm_clk call in case of non-exynos5 cpu.

 arch/arm/cpu/armv7/exynos/clock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/cpu/armv7/exynos/clock.c +1 -1
index 5860c8f..1e54e47 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

--
1.8.0

------------------------------

Message: 29
Date: Thu, 28 Mar 2013 10:32:20 -0400
From: Akshay Saraswat <[email protected]>
Subject: [U-Boot] [PATCH 06/11 v3] Exynos: Tidy up the pwm_config
function in the exynos pwm driver
To: u-boot at lists.denx.de, mk7.kang at samsung.com
Cc: prashanth.g at samsung.com
Message-ID: <[email protected]>

From: Gabe Black <[email protected]>

Some small fixes in the exynos pwm driver:

1. NS_IN_HZ is non-sensical since these are not compatible units. This constant actually describes the number of nanoseconds in a second. Renamed it to NS_IN_SEC. Also dropped the unnecessary parenthesis.
2. The variable "period" is not used to hold a period, it's used to hold a frequency. Renamed it to "frequency".
3. tcmp is an unsigned value, so (tcmp < 0) will never be true and the if which checks that condition will never execute. Also, there should be no problem if the pwm never switches, so there's no reason to subtract one from tcmp and therefore no reason to compare it against zero. Removed both ifs. If they weren't removed, tcmp should be a signed value.
4. Add a check for a 0 period.

Test with command "sf probe 1:0; time sf read 40008000 0 1000". Try with different numbers of bytes and see that sane values are obtained Build and boot U-boot with this patch, backlight works properly.

---
Changes since v2:
- None.

Changes since v1:
- Added "Acked-by: Simon Glass".

 arch/arm/cpu/armv7/s5p-common/pwm.c | 22 ++++++----------------
 1 file changed, 6 insertions(+), 16 deletions(-)
arch/arm/cpu/armv7/s5p-common/pwm.c +6 -16
index 02156d1..6f401b8 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

--
1.8.0

------------------------------

Message: 30
Date: Thu, 28 Mar 2013 10:21:36 -0400
From: Tom Rini <[email protected]>
Subject: Re: [U-Boot] [RFC/PATCH 0/4] BCH8 support for OMAP3
To: Andreas Bie??mann <[email protected]>
Cc: Scott Wood <[email protected]>, U-Boot Mailing List

        <[email protected]>

Message-ID: <20130328142136.GC5711@bill-the-cat>
Content-Type: text/plain; charset="us-ascii"

Quoted 8 lines · Andreas Bie??mann
Quoted 4 lines · Andreas Bie??mann

This RFC series implements BCH8 for OMAP3 as provided by linux kernel in commit 0e618ef0a6a33cf7ef96c2c824402088dd8ef48c.
This series is heavily influenced by Ilyas series 'NAND support for AM33XX' thus could share some code.

Any comments on that series? I would appreciate to get the BCH8 support in for at least the tricorder board.

OK, so, some comments:
- We should pull the gpmc structs out of arch-*/cpu.h and into <asm/omap_gpmc.h> which also means merging <asm/arch-am33xx/omap_gpmc.h> and <asm/arch-omap3/omap_gpmc.h> but I suspect that's easy.
- In terms of 'nandecc' command, I don't like breaking existing setup/scripts, so my first thought is "nandecc hw" -> 1bit, "nandecc sw" -> sw (both just like today), "nandecc hw bch8" -> bch8 and "nandecc hw hamming" -> 1bit, which leaves room down the line for someone else to add nandecc hw bch4 -> bch4 (which is possible and I know exists in custom solutions somewhere).

Quoted 6 lines
Quoted 2 lines

I have managed to load kernel from an ubifs written by the kernel driver, but is far away from tested thoroughly.

We used that patchset for a while in-house and could not find obvious issues. However we need to hack the SPL a bit to get the bigger footprint into SRAM with 2013.01.

What exactly did you do? We _should_ already be taking up all of SRAM with a few kb saved off for stack. We might be able to get away with less stack, but we'd need to check that a bit with the .su files.

Quoted 8 lines
Quoted 4 lines

Cause my NAND device 'NAND device: Manufacturer ID: 0x2c, Chip ID: 0xbc (Micron NAND 512MiB 1,8V 16-bit)' does support 1bit ECC for first sector if erase is less than 1000, the rest requires 4bit ECC. Therefore the SPL needs to support BCH, the impact is about 9k for the SPL.

So my question here is if this series would be accepted for the upcoming release. I could work on it next week full time, so if I get a go for this release I would do so.

The RFC was well in time, so yes, I'm agreeable given the scope of the changes.

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130328/b2caa293/attachment-0001.pgp>

------------------------------

Message: 31
Date: Thu, 28 Mar 2013 15:26:26 +0100
From: Marek Vasut <[email protected]>
Subject: Re: [U-Boot] [PATCH 1/7] USB: Some cleanup prior to USB 3.0
interface addition
To: Vivek Gautam <[email protected]>
Cc: patches at linaro.org, u-boot at lists.denx.de,
rajeshwari.s at samsung.com, vikas.sajjan at samsung.com
Message-ID: <[email protected]>
Content-Type: Text/Plain; charset="us-ascii"

Dear Vivek Gautam,

common/usb.c

Quoted 43 lines

Some cleanup in usb framework, nothing much on feature side.

---
 common/usb.c         |   18 ++++++++++--------
 common/usb_storage.c |   30 ++++++++++++++++--------------
 include/usb_defs.h   |    2 +-
 3 files changed, 27 insertions(+), 23 deletions(-)
common/usb.c +7 -6
index 6fc0fc1..40c1547 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

This will crash as if_desc is set in the if() branch above and it will be NULL in the else{} branch.

common/usb_storage.c

Quoted 22 lines
common/usb.c +3 -2

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

                                                      if_desc[ifno].\
common/usb_storage.c +0 -1
index fb322b4..475c218 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

&usb_dev_desc[usb_max_devs]) == 1) {

common/usb_storage.c

Quoted 6 lines
common/usb_storage.c +3 -2

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

What is this change here doing?

common/usb_storage.c

Quoted 3 lines
common/usb_storage.c +0 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

[..]

Best regards,
Marek Vasut

------------------------------

Message: 32
Date: Thu, 28 Mar 2013 15:28:03 +0100
From: Marek Vasut <[email protected]>
Subject: Re: [U-Boot] [PATCH 2/7] usb: hub: Conditionally power on
usb's root-hub ports
To: Vivek Gautam <[email protected]>
Cc: patches at linaro.org, u-boot at lists.denx.de,
rajeshwari.s at samsung.com, vikas.sajjan at samsung.com
Message-ID: <[email protected]>
Content-Type: Text/Plain; charset="us-ascii"

Dear Vivek Gautam,

Quoted 9 lines

Power on root hubs' ports only when they are not yet powered on. Its seen with USB 3.0 ports that they are powered on after a H/W reset, as also reflected in XHCI spec (sec 4.3):
"After a Chip Hardware Reset, HCRST, or commanded to the PLS = RxDetect state, all Root Hub ports shall be in Disconnected state, i.e. the port is powered on (PP = 1)"

Just wondering if we shouldn't power-cycle all the ports instead -- aka. turn them off and then turn all of them on again.

Best regards,
Marek Vasut

------------------------------

Message: 33
Date: Thu, 28 Mar 2013 15:28:31 +0100
From: Marek Vasut <[email protected]>
Subject: Re: [U-Boot] [PATCH 3/7] usb: Update device class in usb
device's descriptor
To: Vivek Gautam <[email protected]>
Cc: patches at linaro.org, u-boot at lists.denx.de,
rajeshwari.s at samsung.com, vikas.sajjan at samsung.com
Message-ID: <[email protected]>
Content-Type: Text/Plain; charset="us-ascii"

Dear Vivek Gautam,

Quoted 5 lines

Fetch the device class into usb device's dwcriptors, so that the host controller's driver can use this info to differentiate between HUB and DEVICE.

Is this a full name? Otherwise this patch is OK.

common/usb.c

Quoted 20 lines
---
 common/usb.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
common/usb.c +5 -0
index 40c1547..39fcedd 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Best regards,
Marek Vasut

------------------------------

Message: 34
Date: Thu, 28 Mar 2013 15:32:12 +0100
From: Marek Vasut <[email protected]>
Subject: Re: [U-Boot] [PATCH 5/7] usb: hub: Increase device
enumeration timeout for broken drives
To: Vivek Gautam <[email protected]>
Cc: patches at linaro.org, u-boot at lists.denx.de,
rajeshwari.s at samsung.com, vikas.sajjan at samsung.com
Message-ID: <[email protected]>
Content-Type: Text/Plain; charset="us-ascii"

Dear Vivek Gautam,

Quoted 7 lines

Few broken usb mass storage devices can take some time to set Current Connect Status (CCS) and Connect Status Change (CSC) in Port status register after an attach.
So increasing some timeout when both CCS and CSC bits are not set.

Can we not postpone checking of these CCS and CSC bits for such broken devices? This'd at least allow the "good" devices to be detected quickly and while these are handled, this would give some time for the "bad" ones to do their job too.

Best regards,
Marek Vasut

------------------------------

Message: 35
Date: Thu, 28 Mar 2013 15:35:20 +0100
From: Marek Vasut <[email protected]>
Subject: Re: [U-Boot] [PATCH 6/7] USB: SS: Add support for Super Speed
USB interface
To: Vivek Gautam <[email protected]>
Cc: patches at linaro.org, u-boot at lists.denx.de,
rajeshwari.s at samsung.com, vikas.sajjan at samsung.com
Message-ID: <[email protected]>
Content-Type: Text/Plain; charset="us-ascii"

Dear Vivek Gautam,

Quoted 5 lines

This adds usb framework support for super-speed usb, which will further facilitate to add stack support for xHCI.

[...]

include/usb.h

Quoted 25 lines
include/usb.h +11 -1

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Do we really need this struct usb_ep_desc? Can we not just store the usb_ss_ep_comp_descriptor here as well?

include/usb_defs.h

Quoted 53 lines
include/usb.h +0 -0

Lines of this file are not shown. View the raw message.

include/usb_defs.h +23 -1
index 0c78d9d..e2aaef3 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

------------------------------

Message: 36
Date: Thu, 28 Mar 2013 15:37:57 +0100 (CET)
From: Beno?t Th?baudeau <[email protected]>
Subject: Re: [U-Boot] [PATCH v9 01/30] mtd: nand: Introduce
CONFIG_SYS_NAND_BUSWIDTH_16BIT
To: Albert ARIBAUD <[email protected]>
Cc: Scott Wood <[email protected]>, u-boot at lists.denx.de, Fabio
Estevam <[email protected]>
Message-ID:

        <[email protected]>

Content-Type: text/plain; charset=utf-8

Hi Albert,

Quoted 14 lines · Albert ARIBAUD

Hi Beno?t,

Quoted 9 lines · Beno?t Th?baudeau

From: Fabio Estevam <[email protected]>

Introduce CONFIG_SYS_NAND_BUSWIDTH_16BIT option so that other NAND controller
drivers could use it when a 16-bit NAND is deployed.

drivers/mtd/nand/ndfc has CONFIG_SYS_NDFC_16BIT, so just rename it, so that other NAND drivers could reuse the same symbol.

Quoted 6 lines
Quoted 2 lines

Sorry, I may have got the info before but I seem not to find it back:
is this series available somewhere as a branch that I could pull in easily for testing?

Yes, in your inbox on March 6, 2013 8:22 PM. ;)

Best regards,
Beno?t

------------------------------

Message: 37
Date: Thu, 28 Mar 2013 11:52:52 -0300
From: Otavio Salvador <[email protected]>
Subject: Re: [U-Boot] [PATCH 0/5] FSL SECURE BOOT: Add support for
next level image validation
To: Ruchika Gupta <[email protected]>
Cc: U-Boot Mailing List <[email protected]>, Andy Fleming
<[email protected]>
Message-ID:
<CAP9ODKpHGA-yUkvofgQqJkpcGfGw7yNk9GH5Z8bgZNJ4EkPB4w@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1

Quoted 2 lines · Ruchika Gupta

The patch set adds support for next level image validation (linux, rootfs, dtb) in secure boot scenarios.

It seems to focus in PowerPC, do you know if same code could be ported to ARM?

--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br

------------------------------

Message: 38
Date: Thu, 28 Mar 2013 08:59:05 -0600
From: Stephen Warren <[email protected]>
Subject: Re: [U-Boot] [PATCH V2] ARM: bcm2835: fix get_timer() to
return ms
To: Albert ARIBAUD <[email protected]>
Cc: u-boot at lists.denx.de
Message-ID: <[email protected]>
Content-Type: text/plain; charset=ISO-8859-1

Quoted 11 lines · Albert ARIBAUD

Hi Stephen,

Quoted 6 lines · Stephen Warren

Apparently, CONFIG_SYS_HZ must be 1000. Change this, and fix the timer driver to conform to this.

Have the timer implementation export a custom API get_timer_us() for use by the BCM2835 MMC API, which needs us resolution for a HW workaround.

Quoted 8 lines
Quoted 5 lines

---
v2: Export custom API get_timer_us() to allow the MMC driver to maintain
its current workaround implementation.
---

This patch and "mmc: bcm2835: fix delays in bug workaround" cannot be both applied together. Can you do a V2 for the delays fix patch too?

This patch replaces the two previous separate patches. Only this one needs to be applied.

------------------------------

Message: 39
Date: Thu, 28 Mar 2013 08:08:47 -0700
From: Tom Warren <[email protected]>
Subject: Re: [U-Boot] Merge conflict on Tegra SPI between
u-boot/master and u-boot-arm/master
To: Albert ARIBAUD <[email protected]>
Cc: Tom Rini <[email protected]>, U-Boot <[email protected]> Message-ID:

        <CA+m5__JN+V-o1shbFTrtnzRqk4U5Qb6qDdbrGV78js9JTqbHOg@mail.gmail.com>

Content-Type: text/plain; charset="iso-8859-1"

Albert,

Quoted 11 lines · Albert ARIBAUD

Hello all,

While preparing for an ARM PR, specifically a merge between commit 417c55803118eb8e350d5ab8ba6583fb39f4e2e3 (current u-boot/master ToT) and commit d53e340edf65ff253d3a7b06ebe60501045892e3 (current Tot for u-boot-arm/master), I hit the following merge conflicts:

CONFLICT (content): Merge conflict in lib/fdtdec.c CONFLICT (content): Merge conflict in include/fdtdec.h CONFLICT (content): Merge conflict in drivers/spi/tegra20_sflash.c

Quoted 7 lines

While the first two, related to FDT, are simple (colliding additions to the same enum from both branches) and can be manually resolved, the third one, drivers/spi/tegra20_sflash.c, is not, and can not, at least, not by me, as I am not a specialist on Tegra SPI.

Tom (Warren), can you advise on how to best solve this?

Let me take a look - IIRC, Simon's use of spi_alloc_slave() was the only change to tegra20_sflash.c (replaces the normal malloc() in tegra20_spi_setup_slave()).

Here's a diff of the only change to tegra20_sflash.c (merging Allen's Tegra SPI changes and Simon's SPI changes):

--- drivers/spi/tegra20_sflash.c 2013-03-22 08:43:02.373219315 -0700 +++ /home/tom/denx/u-boot-arm/drivers/spi/tegra20_sflash.c 2013-03-28 08:04:04.899860607 -0700
@@ -127,7 +127,7 @@
return NULL;
}

- spi = spi_alloc_slave(struct tegra_spi_slave, bus, cs);
+ spi = malloc(sizeof(struct tegra_spi_slave)); if (!spi) {
printf("SPI error: malloc of SPI structure failed\n"); return NULL;

Let me know if that's not enough for you to resolve this,

Tom

Quoted 5 lines

Amicalement,
--
Albert.

------------------------------

Message: 40
Date: Thu, 28 Mar 2013 09:10:43 -0600
From: Stephen Warren <[email protected]>
Subject: Re: [U-Boot] [PATCH] ARM: bcm2835: fix get_timer() to return
mS
To: Albert ARIBAUD <[email protected]>
Cc: u-boot at lists.denx.de
Message-ID: <[email protected]>
Content-Type: text/plain; charset=ISO-8859-1

Quoted 9 lines · Albert ARIBAUD

Hi Stephen,

Quoted 2 lines · Stephen Warren

Apparently, CONFIG_SYS_HZ must be 1000. Change this, and fix the timer driver to conform to this.

Is this a fix to some known issue or bug?

Yes. The bootdelay timeout implementation was recently(?) changed and the new code doesn't use CONFIG_SYS_HZ at all, but rather assumes that it's 1000. Since rpi_b's SYS_HZ was 1000000, the bootdelay runs by far too fast. This fixes that.

------------------------------

Message: 41
Date: Thu, 28 Mar 2013 16:14:08 +0100
From: Albert ARIBAUD <[email protected]>
Subject: Re: [U-Boot] [PATCH V2] ARM: bcm2835: fix get_timer() to
return ms
To: Stephen Warren <[email protected]>
Cc: u-boot at lists.denx.de
Message-ID: <20130328161408.5341886b@lilith>
Content-Type: text/plain; charset=US-ASCII

Hi Stephen,

Quoted 18 lines · Stephen Warren
Quoted 17 lines · Albert ARIBAUD

Hi Stephen,

Quoted 11 lines · Stephen Warren

Apparently, CONFIG_SYS_HZ must be 1000. Change this, and fix the timer driver to conform to this.

Have the timer implementation export a custom API get_timer_us() for use by the BCM2835 MMC API, which needs us resolution for a HW workaround.

---
v2: Export custom API get_timer_us() to allow the MMC driver to maintain
its current workaround implementation.
---

Quoted 5 lines
Quoted 2 lines

This patch and "mmc: bcm2835: fix delays in bug workaround" cannot be both applied together. Can you do a V2 for the delays fix patch too?

This patch replaces the two previous separate patches. Only this one needs to be applied.

Ok -- thanks. Will soon (i.e., in one hour at most) be available in u-boot-arm/master.

Amicalement,
--
Albert.

------------------------------

Message: 42
Date: Thu, 28 Mar 2013 16:16:06 +0100
From: Albert ARIBAUD <[email protected]>
Subject: Re: [U-Boot] [PATCH v9 01/30] mtd: nand: Introduce
CONFIG_SYS_NAND_BUSWIDTH_16BIT
To: Beno?t Th?baudeau <[email protected]>
Cc: Fabio Estevam <[email protected]>, Stefano,
u-boot at lists.denx.de, Scott Wood <[email protected]>
Message-ID: <20130328161606.0c66af14@lilith>
Content-Type: text/plain; charset=UTF-8

Hi Beno?t,

Quoted 17 lines · Beno?t Th?baudeau

Hi Albert,

Quoted 14 lines · Albert ARIBAUD

Hi Beno?t,

Quoted 9 lines · Beno?t Th?baudeau

From: Fabio Estevam <[email protected]>

Introduce CONFIG_SYS_NAND_BUSWIDTH_16BIT option so that other NAND controller
drivers could use it when a 16-bit NAND is deployed.

drivers/mtd/nand/ndfc has CONFIG_SYS_NDFC_16BIT, so just rename it, so that other NAND drivers could reuse the same symbol.

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

Sorry, I may have got the info before but I seem not to find it back:
is this series available somewhere as a branch that I could pull in easily for testing?

Yes, in your inbox on March 6, 2013 8:22 PM. ;)

Oh, ok. I'd thought that was v8. I'll pull this in as soon as the current mainline/ARM merge issue is solved.

Quoted 2 lines

Best regards,
Beno?t

Amicalement,
--
Albert.

------------------------------

Message: 43
Date: Thu, 28 Mar 2013 08:16:37 -0700
From: Tom Warren <[email protected]>
Subject: Re: [U-Boot] Merge conflict on Tegra SPI between
u-boot/master and u-boot-arm/master
To: Albert ARIBAUD <[email protected]>
Cc: Tom Rini <[email protected]>, U-Boot <[email protected]> Message-ID:
<CA+m5__Lt_tKrWnYMQEDgaFVcL1WdJDAXBDC9iFaDDcX6-9whvQ@mail.gmail.com>
Content-Type: text/plain; charset="iso-8859-1"

Albert,

Quoted 44 lines · Tom Warren

Albert,

On Thu, Mar 28, 2013 at 6:38 AM, Albert ARIBAUD <[email protected]

Quoted 13 lines

wrote:

Hello all,

While preparing for an ARM PR, specifically a merge between commit 417c55803118eb8e350d5ab8ba6583fb39f4e2e3 (current u-boot/master ToT) and commit d53e340edf65ff253d3a7b06ebe60501045892e3 (current Tot for u-boot-arm/master), I hit the following merge conflicts:

CONFLICT (content): Merge conflict in lib/fdtdec.c CONFLICT (content): Merge conflict in include/fdtdec.h CONFLICT (content): Merge conflict in drivers/spi/tegra20_sflash.c

Quoted 7 lines

While the first two, related to FDT, are simple (colliding additions to the same enum from both branches) and can be manually resolved, the third one, drivers/spi/tegra20_sflash.c, is not, and can not, at least, not by me, as I am not a specialist on Tegra SPI.

Tom (Warren), can you advise on how to best solve this?

Let me take a look - IIRC, Simon's use of spi_alloc_slave() was the only change to tegra20_sflash.c (replaces the normal malloc() in tegra20_spi_setup_slave()).

Here's a diff of the only change to tegra20_sflash.c (merging Allen's Tegra SPI changes and Simon's SPI changes):

home/tom/denx/u-boot-arm/drivers/spi/tegra20_sflash.c 2013-03-28 renamed from spi/tegra20_sflash.c 2013-03-22 08:43:02.373219315 -0700 +0 -0

08:04:04.899860607 -0700

home/tom/denx/u-boot-arm/drivers/spi/tegra20_sflash.c 2013-03-28 renamed from spi/tegra20_sflash.c 2013-03-22 08:43:02.373219315 -0700 +1 -1

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 4 lines

Let me know if that's not enough for you to resolve this,

Tom

Just confirmed - in tegra20_sflash.c, remove the <<<<< HEAD section (#ifdef CONFIG_OF_CONTROL + 2 lines), and keep the "tegra: spi remove non fdt support" section (spi->slave.bus = bus + 4 lines).

Tom

Quoted 7 lines
Quoted 5 lines

Amicalement,
--
Albert.

------------------------------

Message: 44
Date: Thu, 28 Mar 2013 11:21:27 -0400
From: Tom Rini <[email protected]>
Subject: Re: [U-Boot] [PATCH 1/1 v2] omap3_beagle: Enabling UART3
first allows the Transmitter to be empty
To: Andreas Bie??mann <[email protected]>
Cc: Scott Wood <[email protected]>, u-boot at lists.denx.de
Message-ID: <20130328152127.GD5711@bill-the-cat>
Content-Type: text/plain; charset="us-ascii"

Quoted 25 lines · Andreas Bie??mann

Hi Javier,

Quoted 6 lines · Javier Martinez Canillas
Quoted 4 lines · Andreas Bie??mann

Dear Manfred Huber,

Quoted 1 line · Manfred Huber

On 2013-03-27 14:37, Andreas Bie??mann wrote:

<snip>

Quoted 13 lines
Quoted 13 lines
Quoted 6 lines

The reason to setup the baud is for the shift register. It only works with programmed baud registers. A soft reset would also work, but as Scott Wood said it would corrupt the last character. On the other hand the character should be corrupted by disabling the UART. I have no preferred solution: programming the UART or a soft reset. Maybe someone wants to decide.

Well, I think also that re-programming the UART will destroy the last character in shift register anyway.
I wonder which use-case requires UART flushing in u-boot context before initializing the UART for u-boot correctly. Can someone explain this to me? Shouldn't we always start here from the very beginning and setup UART as configured?

We shouldn't be concerned with what is destroyed here as it's going to be related to ROM trying (and then failing and moving on from) to load via UART the next program. We've already started and are running, so the UART is ours to do with as we need. If ROM did load us over UART it really should already be in a clean state.

Quoted 12 lines

<snip>

Quoted 5 lines

When I first hit this bug I tried removing the serial debug cable and this made my IGEPv2 to boot correctly. Then I looked at the latest changes to the serial ns16550 driver and found that cb55b332 "serial/ns16550: wait for TEMT before initializing" was the culprit commit that made my board to not boot.

Thanks for clarification. So there is a need to flush UART before initializing it in u-boot context as said by Scott's comment in cb55b332, at least for some systems.

Quoted 5 lines

I think Manfred's proposed solution in this patch is ok. It fixes a bug when transiting from (some) OMAP ROM code to SPL, therefore we should have the code conditionally on SPL and OMAP. Maybe we find out later, that this also matches other combinations. But for now I think we should just take Manfred's solution in this release, Tom?

Agreed.

Quoted 2 lines

Many thanks to you Manfred for forcing attention on this bug and providing a solution.

And also very much agreed!

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130328/598a67b1/attachment-0001.pgp>

------------------------------

Message: 45
Date: Thu, 28 Mar 2013 11:21:49 -0400
From: Tom Rini <[email protected]>
Subject: Re: [U-Boot] [PATCH 1/1 v2] omap3_beagle: Enabling UART3
first allows the Transmitter to be empty
To: Manfred Huber <[email protected]>
Cc: Scott Wood <[email protected]>, u-boot at lists.denx.de
Message-ID: <20130328152149.GE5711@bill-the-cat>
Content-Type: text/plain; charset="us-ascii"

Quoted 4 lines · Manfred Huber

Please test the Patch. It is very simple on a Beagleboard. I guess you have flashed the actual SPL and u-boot and Beagleboard boots correctly. Now press and hold 'User' button and connect power. SPL should hang. You can see some symbols on the console from the ROM code.

I cannot reproduce this problem on my Beagleboard C5. I note this only so it's clear I tried things out. I'm still supportive of the changes overall as they also don't break anything here. I'm also still waiting to hear back from some folks that might know what the ROM code does or doesn't do.

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130328/ae913832/attachment.pgp>

------------------------------

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

End of U-Boot Digest, Vol 58, Issue 49
**************************************

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Part of the diff is not shown here. View the raw message.