ALSA: xen: Use standard pcm_format_to_bits() for ALSA format bits
Oleksandr Andrushchenko
Reviewed-byHello, Takashi!
Quoted 34 lines
Date: Wed, 25 Jul 2018 23:19:45 +0200
From: Takashi Iwai <[email protected]>
To: [email protected]
Subject: [alsa-devel] [PATCH 10/10] ALSA: xen: Use standard
pcm_format_to_bits()for ALSA format bits
Message-ID: <[email protected]>The open codes with the bit shift in
xen_snd_front_alsa.cgive sparse warnings as the PCM format type is with__bitwise.
There is already a standard macro to get the format bits, so let's use it instead.This fixes sparse warnings like:
sound/xen/xen_snd_front_alsa.c:191:47: warning: restrictedsnd_pcm_format_tdegrades to integerSigned-off-by Takashi Iwai <[email protected]>--- sound/xen/xen_snd_front_alsa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)sound/xen/xen_snd_front_alsa.c +1
-1@@ -188,7 +188,7 @@ static u64 to_sndif_formats_mask(u64 alsa_formats) mask =0 ;for (i =0 ; i <ARRAY_SIZE (ALSA_SNDIF_FORMATS ); i++) -if (1 <<ALSA_SNDIF_FORMATS [i].alsa & alsa_formats) +if (pcm_format_to_bits (ALSA_SNDIF_FORMATS [i].alsa) & alsa_formats) mask |=1 <<ALSA_SNDIF_FORMATS [i].sndif;return mask;
sound/xen/xen_snd_front_alsa.c static u64 to_alsa_formats_mask(u64 sndif_formats) · line 208
Quoted 8 lines
sound/xen/xen_snd_front_alsa.c +1
-1@@ -202,7 +202,7 @@ static u64 to_alsa_formats_mask(u64 sndif_formats) mask =0 ;for (i =0 ; i <ARRAY_SIZE (ALSA_SNDIF_FORMATS ); i++)if (1 <<ALSA_SNDIF_FORMATS [i].sndif & sndif_formats) - mask |=1 <<ALSA_SNDIF_FORMATS [i].alsa; + mask |=pcm_format_to_bits (ALSA_SNDIF_FORMATS [i].alsa);return mask; }
Thank you for your patch,
Thank you,
Oleksandr
Oleksandr Andrushchenko
Reviewed-byHello, Takashi!
Quoted 34 lines
Date: Wed, 25 Jul 2018 23:19:45 +0200
From: Takashi Iwai <[email protected]>
To: [email protected]
Subject: [alsa-devel] [PATCH 10/10] ALSA: xen: Use standard
pcm_format_to_bits()for ALSA format bits
Message-ID: <[email protected]>The open codes with the bit shift in
xen_snd_front_alsa.cgive sparse warnings as the PCM format type is with__bitwise.
There is already a standard macro to get the format bits, so let's use it instead.This fixes sparse warnings like:
sound/xen/xen_snd_front_alsa.c:191:47: warning: restrictedsnd_pcm_format_tdegrades to integerSigned-off-by Takashi Iwai <[email protected]>--- sound/xen/xen_snd_front_alsa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)sound/xen/xen_snd_front_alsa.c +1
-1@@ -188,7 +188,7 @@ static u64 to_sndif_formats_mask(u64 alsa_formats) mask =0 ;for (i =0 ; i <ARRAY_SIZE (ALSA_SNDIF_FORMATS ); i++) -if (1 <<ALSA_SNDIF_FORMATS [i].alsa & alsa_formats) +if (pcm_format_to_bits (ALSA_SNDIF_FORMATS [i].alsa) & alsa_formats) mask |=1 <<ALSA_SNDIF_FORMATS [i].sndif;return mask;
sound/xen/xen_snd_front_alsa.c static u64 to_alsa_formats_mask(u64 sndif_formats) · line 208
Quoted 8 lines
sound/xen/xen_snd_front_alsa.c +1
-1@@ -202,7 +202,7 @@ static u64 to_alsa_formats_mask(u64 sndif_formats) mask =0 ;for (i =0 ; i <ARRAY_SIZE (ALSA_SNDIF_FORMATS ); i++)if (1 <<ALSA_SNDIF_FORMATS [i].sndif & sndif_formats) - mask |=1 <<ALSA_SNDIF_FORMATS [i].alsa; + mask |=pcm_format_to_bits (ALSA_SNDIF_FORMATS [i].alsa);return mask; }
Thank you for your patch,
Thank you,
Oleksandr
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel