Skip to contentSkip to conversation

Drop python 2.7

PATCH Andreas Ziegler 2 participants 3 messages Feb 10, 2022 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi Yann,
Hi Peter,

Quoted 11 lines · Yann E. MORIN

Peter ,All,

On 2022-02-09 17:50 +0100, Peter Korsgaard spake thusly:

Quoted 8 lines

Python 2.7 is EOL since April 2020 and almost all packages support python 3, so drop it before the 2022.02 release.

It is a big series, but the changes are mainly mechanical in nature.

There is still some cleanup to do, E.G. the python2 support in pkg-python and the host python-setuptools package - But this is IMHO the minimum changes before -rc1.

There seem to be some more references to python(2) in packages; this build failure is from package/crda:

# make clean && make
  ...
make[1]: *** No rule to make target 'host-python', needed by '/home/data/buildroot.x86_64/build/host-python-pycryptodomex-3.13.0/.stamp_configured'. 
 Stop.
make: *** [Makefile:23: _all] Error 2
$ grep python-pycryptodomex */*.mk
crda/crda.mk:CRDA_DEPENDENCIES = host-pkgconf host-python-pycryptodomex libnl libgcrypt
python3-pycryptodomex/python3-pycryptodomex.mk:# Please keep in sync with package/python-pycryptodomex/python-pycryptodomex.mk
python3-pycryptodomex/python3-pycryptodomex.mk:HOST_PYTHON3_PYCRYPTODOMEX_DL_SUBDIR = python-pycryptodomex
python-pycryptodomex/python-pycryptodomex.mk:# python-pycryptodomex

Kind regards,
Andreas

Quoted 8 lines
Quoted 1 line

Peter Korsgaard (107):

...

Quoted 1 line

package/python: drop target package

...

Quoted 1 line

package/python: drop host package

...

Quoted 1 line

docs/manual: drop python2 references

Quoted 8 lines

All 107 patches applied, thanks!

I'll reply further to two of them, with ultra-minor nits.

Pfew, 21st century, here we come at last! ;-)

Regards,
Yann E. MORIN.

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Andreas" == Andreas Ziegler <[email protected]> writes:

Hi Yann,
Hi Peter,

Quoted 11 lines · Yann E. MORIN

Peter ,All,

On 2022-02-09 17:50 +0100, Peter Korsgaard spake thusly:

Quoted 8 lines

Python 2.7 is EOL since April 2020 and almost all packages support python 3, so drop it before the 2022.02 release.

It is a big series, but the changes are mainly mechanical in nature.

There is still some cleanup to do, E.G. the python2 support in pkg-python and the host python-setuptools package - But this is IMHO the minimum changes before -rc1.

Quoted 8 lines

There seem to be some more references to python(2) in packages; this build failure is from package/crda:

# make clean && make
  ...
make[1]: *** No rule to make target 'host-python', needed by
'/home/data/buildroot.x86_64/build/host-python-pycryptodomex-3.13.0/.stamp_configured'. Stop.
make: *** [Makefile:23: _all] Error 2

Ahh yes, that is because we end up in package/pkg-python.mk with:

ifeq ($$($(2)_NEEDS_HOST_PYTHON),)
$(2)_DEPENDENCIES += $$(if $$(BR2_PACKAGE_PYTHON3),host-python3,host-python)

And you (presumably) don't have python3 enabled. I'll send a fix.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw

Hi Peter,

Quoted 27 lines · Peter Korsgaard
Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Andreas" == Andreas Ziegler <[email protected]> writes:

Hi Yann,
Hi Peter,

Quoted 7 lines · Yann E. MORIN

Peter ,All,

On 2022-02-09 17:50 +0100, Peter Korsgaard spake thusly:

Quoted 4 lines

Python 2.7 is EOL since April 2020 and almost all packages support python 3, so drop it before the 2022.02 release.

It is a big series, but the changes are mainly mechanical in

nature.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

There is still some cleanup to do, E.G. the python2 support in pkg-python and the host python-setuptools package - But this is

IMHO

Quoted 9 lines
Quoted 1 line
Quoted 1 line

the minimum changes before -rc1.

There seem to be some more references to python(2) in packages; this build failure is from package/crda:

# make clean && make
  ...
make[1]: *** No rule to make target 'host-python', needed by
Quoted 8 lines

'/home/data/buildroot.x86_64/build/host-python-pycryptodomex-3.13.0/.stamp_configured'. Stop.

Quoted 1 line

make: *** [Makefile:23: _all] Error 2

Ahh yes, that is because we end up in package/pkg-python.mk with:

ifeq ($$($(2)_NEEDS_HOST_PYTHON),)
$(2)_DEPENDENCIES += $$(if $$(BR2_PACKAGE_PYTHON3),host-python3,host-python)

Ah, this may be the reason I have two sets of host-python packages in my build tree :-D

Quoted 2 lines

And you (presumably) don't have python3 enabled. I'll send a fix.

Correct, I do not use Python on the target, but (at lest) one package insists on having host-python.

I'm currently testing by changing host-python to host-python3 in package/crda, and found another issue; this probably also needs a change:

[python3.mk]
# Some packages may have build scripts requiring python3, whatever is the

# python version chosen for the target.
# Only install the python symlink in the host tree if python3 is enabled
# for the target.
ifeq ($(BR2_PACKAGE_PYTHON3),y)
define HOST_PYTHON3_INSTALL_SYMLINK
	ln -fs python3 $(HOST_DIR)/bin/python
	ln -fs python3-config $(HOST_DIR)/bin/python-config
endef

Is there any need of keeping separate python3 packages, now that python == python3?

Kind regards,
Andreas

Quoted 2 lines

--
Bye, Peter Korsgaard

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot