Skip to contentSkip to conversation

changes for support of IDS8247 board

PATCH New Heiko Schocher 1 participant 1 message Aug 7, 2007 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 changes for support of IDS8247 board

Hello Sergej,

Sergej Stepanov wrote:
[...]

Quoted 5 lines

#endif /* CFG_CMD_NAND */

(quoted diff) +4 -0
+
+#if defined(CONFIG_OF_FLAT_TREE) && defined(CONFIG_OF_BOARD_SETUP)
+void
+ft_board_setup(void *blob, bd_t *bd)

Review

Quoted 10 lines
(quoted diff) +10 -0
+{
+	u32 *p;
+	int len;
+	ulong clock;
+	/* do what ft_cpu_setup does */
+
+	clock = bd->bi_busfreq;
+	p = ft_get_prop(blob, "/cpus/" OF_CPU "/bus-frequency", &len);
+	if (p != NULL)
+		*p = cpu_to_be32(clock);

This is valid for all MPC8260 processors. I think you should move this
to: cpu/mpc8260/cpu.c and make a ft_cpu_setup ():

#if defined(CONFIG_OF_FLAT_TREE)
void ft_cpu_setup (void *blob, bd_t *bd)

{
	u32 *p;
	ulong clock;
	int len;

	clock = bd->bi_busfreq;
	p = ft_get_prop (blob, "/cpus/" OF_CPU "/bus-frequency", &len);
	if (p != NULL)
	*p = cpu_to_be32 (clock);
}

#endif

and call this function in ft_board_setup ().

Best regards
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany