Skip to contentSkip to conversation

tc: u32 match in nexthdr not working?

LARTC Lutz Pressler 5 participants 12 messages Dec 13, 2001 – Dec 14, 2001

lore
Share & tools
lore
#0 lore raw

Hello,

it seems, that filtering on nexthdr (TCP/UDP) content, especially src or dst port, is not working.

The following has no effect on 2.4.16 or older (even 2.2) kernels:

# tc filter add dev eth0 parent ffff: protocol ip prio 50 u32 match tcp
dst 3128 0xffff police rate 40kbit burst 10k drop flowid :1

Even if

# tc filter ls dev eth0 parent ffff:
filter protocol ip pref 50 u32
filter protocol ip pref 50 u32 fh 800: ht divisor 1
filter protocol ip pref 50 u32 fh 800::800 order 2048 key ht 800 bkt 0 flowid :1
police 4 action drop rate 40Kbit burst 10Kb mtu 2Kb
  match 00000c38/0000ffff at nexthdr+0

looks reasonable, TCP connections to port 3128 are not policed.

If I use "match ip dst <ip-address>" instead, the policing works.

Port based matching isn't working for outgoing shapers either, as can be seen with the statistics functions.

Any idea? Anybody with port based (etc.) filtering actually working?

Regards,
Lutz

Signature · 9 lines
  _              |  Lutz Pressler          |  Tel: ++49-551-3700002
 |_     |\ |     |  Service Network GmbH   |  FAX: ++49-551-3700009
 ._|ER  | \|ET   |  Bahnhofsallee 1b       |   mailto:[email protected]
Service Network  |  D-37081 Goettingen     |  http://www.SerNet.DE/


_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://ds9a.nl/lartc/
#1 lore raw
Quoted 4 lines · Lutz Pressler

The following has no effect on 2.4.16 or older (even 2.2) kernels:

# tc filter add dev eth0 parent ffff: protocol ip prio 50 u32 match tcp
dst 3128 0xffff police rate 40kbit burst 10k drop flowid :1

Double check what this means! This limits speed of data *coming in to* your proxy from a client (browser). That is not a lot - most data will flow he other way, and will indeed not be matched.

Data being received BY your proxy from the internet is not matched by this proxy.

Quoted 8 lines

Even if

# tc filter ls dev eth0 parent ffff:
filter protocol ip pref 50 u32
filter protocol ip pref 50 u32 fh 800: ht divisor 1

filter protocol ip pref 50 u32 fh 800::800 order 2048 key ht 800 bkt 0 flowid :1 police 4 action drop rate 40Kbit burst 10Kb mtu 2Kb
match 00000c38/0000ffff at nexthdr+0

You supply a lot of redundant information. I'm not sure what the '4' means in this rule.

Quoted 3 lines

looks reasonable, TCP connections to port 3128 are not policed.

If I use "match ip dst <ip-address>" instead, the policing works.

Your proxy does no necessarily download FROM port 3128!

Regards,

bert

Signature · 8 lines
http://www.PowerDNS.com          Versatile DNS Software & Services
Trilab                                 The Technology People
Netherlabs BV / Rent-a-Nerd.nl           - Nerd Available -
'SYN! .. SYN|ACK! .. ACK!' - the mating call of the internet

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://ds9a.nl/lartc/
#2 lore raw
In reply to Lutz Pressler
Quoted 11 lines · bert hubert
Quoted 4 lines · Lutz Pressler

The following has no effect on 2.4.16 or older (even 2.2) kernels:

# tc filter add dev eth0 parent ffff: protocol ip prio 50 u32 match tcp
dst 3128 0xffff police rate 40kbit burst 10k drop flowid :1

Double check what this means! This limits speed of data *coming in to* your proxy from a client (browser). That is not a lot - most data will flow he other way, and will indeed not be matched.

Sorry, that was a typo (I forget that I tried the other way too, to be complete, before doing the cut&paste). Of course "src 3128"!

Quoted 11 lines

Data being received BY your proxy from the internet is not matched by this proxy.

Quoted 8 lines

Even if

# tc filter ls dev eth0 parent ffff:
filter protocol ip pref 50 u32
filter protocol ip pref 50 u32 fh 800: ht divisor 1

filter protocol ip pref 50 u32 fh 800::800 order 2048 key ht 800 bkt 0 flowid :1 police 4 action drop rate 40Kbit burst 10Kb mtu 2Kb
match 00000c38/0000ffff at nexthdr+0

and "match 0c380000/ffff0000" here.

Quoted 3 lines

You supply a lot of redundant information. I'm not sure what the '4' means in this rule.

Neither do I, haven't set it explicitly. Seems to increase with every change in policing rules.

Quoted 6 lines
Quoted 4 lines

looks reasonable, TCP connections to port 3128 are not policed.

If I use "match ip dst <ip-address>" instead, the policing works.

Your proxy does no necessarily download FROM port 3128!

I did that - as a test, real situation is not about 3128 - on the client, not the proxy.

Lutz

Signature · 9 lines
  _              |  Lutz Pressler          |  Tel: ++49-551-3700002
 |_     |\ |     |  Service Network GmbH   |  FAX: ++49-551-3700009
 ._|ER  | \|ET   |  Bahnhofsallee 1b       |   mailto:[email protected]
Service Network  |  D-37081 Goettingen     |  http://www.SerNet.DE/


_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://ds9a.nl/lartc/
#3 lore raw
In reply to Lutz Pressler

Hi again,

ok, did some tests:

match ip sport 3128 does work (as does the more correct match ip sport 3128 0xffff match ip protocol 0xff to only consider TCP) - match tcp src 3128 does not.

The difference as shown by tc filter show dev eth0 parent ffff:
is that ip sport -> "match 0c380000/ffff0000 at 20"

        tcp src ->  "match 0c380000/ffff0000 at nexthdr+0".

This confirms my assumption, that nexthrd is broken. at nexthdr+0 _should_ work with IP options present, "at 20" not, correct?

Lutz

Signature · 9 lines
  _              |  Lutz Pressler          |  Tel: ++49-551-3700002
 |_     |\ |     |  Service Network GmbH   |  FAX: ++49-551-3700009
 ._|ER  | \|ET   |  Bahnhofsallee 1b       |   mailto:[email protected]
Service Network  |  D-37081 Goettingen     |  http://www.SerNet.DE/


_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://ds9a.nl/lartc/
#4 lore raw
In reply to Lutz Pressler

Hello,

Quoted 8 lines · Lutz Pressler

Hi again,

ok, did some tests:

match ip sport 3128 does work (as does the more correct match ip sport 3128 0xffff match ip protocol 0xff to only consider TCP) - match tcp src 3128 does not.

Quoted 5 lines

The difference as shown by tc filter show dev eth0 parent ffff:
is that ip sport -> "match 0c380000/ffff0000 at 20"

        tcp src ->  "match 0c380000/ffff0000 at nexthdr+0".

This confirms my assumption, that nexthrd is broken.

It confirms only that nexthdr does not work with your
settings. Nothing more. Read carefully iproute2/README.iproute2+tc and particularly the last filter in this file. I agree, it is not documented very well. To use nexthdr you must use "offset" with hash table. U32 is universal (read line #2 in cls_u32.c), it does not know that you are using IPv4, so the value 20 can not be guessed. For this, "offset" is used to extract the iphdr->ihl value and to use it as a base for all nexthdr+ relative offsets.

Quoted 4 lines

at nexthdr+0 _should_ work with IP options present, "at 20" not, correct?

Lutz

Regards

--
Julian Anastasov <[email protected]>

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://ds9a.nl/lartc/

#5 lore raw
In reply to Lutz Pressler
Quoted 7 lines · Julian Anastasov
Quoted 3 lines

The difference as shown by tc filter show dev eth0 parent ffff:
is that ip sport -> "match 0c380000/ffff0000 at 20"

        tcp src ->  "match 0c380000/ffff0000 at nexthdr+0".

not know that you are using IPv4, so the value 20 can not be guessed. For this, "offset" is used to extract the iphdr->ihl value and to use it as a base for all nexthdr+ relative offsets.

Damn, that's broken. Or at least, extremely non-obvious and hard to get working. Overly universal comes to mind. So 'ip sport' would stop matching packets with ip options?

Thanks for enlightening us - will update the HOWTO to this effect.

Regards,

bert

Signature · 8 lines
http://www.PowerDNS.com          Versatile DNS Software & Services
Trilab                                 The Technology People
Netherlabs BV / Rent-a-Nerd.nl           - Nerd Available -
'SYN! .. SYN|ACK! .. ACK!' - the mating call of the internet

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://ds9a.nl/lartc/
#6 lore raw
In reply to Lutz Pressler

Hello,

Quoted 8 lines · bert hubert
Quoted 4 lines

not know that you are using IPv4, so the value 20 can not be guessed. For this, "offset" is used to extract the iphdr->ihl value and to use it as a base for all nexthdr+ relative offsets.

Damn, that's broken. Or at least, extremely non-obvious and hard to get working. Overly universal comes to mind. So 'ip sport' would stop matching packets with ip options?

No, ihl includes the options. Everything works perfectly.
It is bug to use sport and dport if ip options are present. There are tcp dst and tcp src for example. Same for udp. For icmp there are icmp type and icmp code. All they use the same base pointer.

Quoted 3 lines

Regards,

bert

Regards

--
Julian Anastasov <[email protected]>

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://ds9a.nl/lartc/

#7 lore raw
In reply to Lutz Pressler
Quoted 6 lines · Julian Anastasov
Quoted 3 lines

Damn, that's broken. Or at least, extremely non-obvious and hard to get working. Overly universal comes to mind. So 'ip sport' would stop matching packets with ip options?

No, ihl includes the options. Everything works perfectly.
It is bug to use sport and dport if ip options are present. There

Geh. Or an 'undocumented feature'. Because you don't know what kind of packets you will send or forward, using 'ip sport' is always a bug.

Quoted 2 lines

are tcp dst and tcp src for example. Same for udp. For icmp there are icmp type and icmp code. All they use the same base pointer.

But tcp src only works when operating in a hashed filter? Which is not often the case.

I tried this:

tc filter add dev eth0 parent 1:0 prio 5 u32  \
	match ip nofrag \
	offset mask 0x0F00 shift 6 \
	match tcp src 22 0xffff classid 1:2

But it doesn't work, gives:
RTNETLINK answers: Invalid argument

Regards,

bert

Signature · 8 lines
http://www.PowerDNS.com          Versatile DNS Software & Services
Trilab                                 The Technology People
Netherlabs BV / Rent-a-Nerd.nl           - Nerd Available -
'SYN! .. SYN|ACK! .. ACK!' - the mating call of the internet

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://ds9a.nl/lartc/
#8 lore raw
In reply to Lutz Pressler

Hello,

Quoted 5 lines · bert hubert
Quoted 2 lines

No, ihl includes the options. Everything works perfectly.
It is bug to use sport and dport if ip options are present. There

Geh. Or an 'undocumented feature'. Because you don't know what kind of packets you will send or forward, using 'ip sport' is always a bug.

Yes

Quoted 5 lines
Quoted 2 lines

are tcp dst and tcp src for example. Same for udp. For icmp there are icmp type and icmp code. All they use the same base pointer.

But tcp src only works when operating in a hashed filter? Which is not often the case.

Right. But only then we can match packets with options.

Quoted 7 lines

I tried this:

tc filter add dev eth0 parent 1:0 prio 5 u32  \
	match ip nofrag \
	offset mask 0x0F00 shift 6 \
	match tcp src 22 0xffff classid 1:2

But it doesn't work, gives:

Of course

Quoted 1 line

RTNETLINK answers: Invalid argument

Didn't tried it but something like this:

F="tc filter add dev eth0 parent 1:0 protocol ip prio 5"
$F handle 1: u32 divisor 1
$F u32 ht 1: match tcp src 22 0xFFFF match ip protocol 6 0xFF match ip firstfrag flowid 1:2 $F u32 ht 800:: match u8 0 0 offset at 0 mask 0x0f00 shift 6 link 1:

Using ip nofrag is another bug :) Small? You miss traffic.

Quoted 3 lines

Regards,

bert

Regards

--
Julian Anastasov <[email protected]>

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://ds9a.nl/lartc/

#9 lore raw
In reply to Lutz Pressler
Quoted 4 lines · Julian Anastasov

        No, ihl includes the options. Everything works perfectly. It is bug to use sport and dport if ip options are present. There are tcp dst and tcp src for example. Same for udp. For icmp there are icmp type and icmp code. All they use the same base pointer.

Which only works if you have a chained the filter rules using a hash table, where the hash table has a IP offset rule.

Regards
Henrik

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://ds9a.nl/lartc/

#10 lore raw
In reply to Lutz Pressler
Quoted 6 lines · Julian Anastasov

Didn't tried it but something like this:

F="tc filter add dev eth0 parent 1:0 protocol ip prio 5"
$F handle 1: u32 divisor 1
$F u32 ht 1: match tcp src 22 0xFFFF match ip protocol 6 0xFF match ip firstfrag flowid 1:2 $F u32 ht 800:: match u8 0 0 offset at 0 mask 0x0f00 shift 6 link 1:

Thanks for that example; a few more U32 filter examples in the HOWTO would be welcome I'm sure ... ;-~

Signature · 7 lines
Michael T. Babcock
CTO, FibreSpeed Ltd.     (Hosting, Security, Consultation, Database, etc)
http://www.fibrespeed.net/~mbabcock/

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://ds9a.nl/lartc/
#11 lore raw
In reply to Lutz Pressler
Quoted 10 lines · Michael T. Babcock
Quoted 6 lines · Julian Anastasov

Didn't tried it but something like this:

F="tc filter add dev eth0 parent 1:0 protocol ip prio 5"
$F handle 1: u32 divisor 1
$F u32 ht 1: match tcp src 22 0xFFFF match ip protocol 6 0xFF match ip firstfrag flowid 1:2 $F u32 ht 800:: match u8 0 0 offset at 0 mask 0x0f00 shift 6 link 1:

Thanks for that example; a few more U32 filter examples in the HOWTO would be welcome I'm sure ... ;-~

I'm always happy to receive tested examples. That is what takes the most time - I actually try to test everything these days or I need to be *sure* that somebody tested it.

In the past a lot of crap was merged which later turned out not to work :-(

Quoted 3 lines

Michael T. Babcock
CTO, FibreSpeed Ltd. (Hosting, Security, Consultation, Database, etc)
http://www.fibrespeed.net/~mbabcock/

Oh, I've been exploring how the 'virtual clock' works in the Linux CBQ implementation, it turns out that you can misconfigure it quite badly and still get *statistically* accurate shaping. I'm still figuring out the effects at short timescales of misconfiguring bandwidth.

Regards,

bert hubert

Signature · 8 lines
http://www.PowerDNS.com          Versatile DNS Software & Services
Trilab                                 The Technology People
Netherlabs BV / Rent-a-Nerd.nl           - Nerd Available -
'SYN! .. SYN|ACK! .. ACK!' - the mating call of the internet

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://ds9a.nl/lartc/