Skip to contentSkip to conversation

Is negative offset possible in u32 ?

LARTC Eric Leblond 3 participants 4 messages Jan 14, 2003

lore
Share & tools
lore
#0 lore raw

Has somebody realyy manage to use the examples given when using negative offset in u32 ?

I look at the kernel code, I'm almost a real beginner here so I could wrote stupid things :

I saw that in the file cls_u32.c we work with skb and use only skb->nh.raw. That's the network header, so we don't have any information about Ethernet header (it's in skb->mac.raw that we have the ethernet header and that the protocol is given).
Furthermore (maybe i'm wrong cause of inverted stockage in memory) in the skbuf struct the ethernet header union follow the network header union so we should read something else.
Thus we can at least say that negative offset in u32 are really "tricky" and really non clean and as seems to show experiment that they don't work (?)

Signature · 2 lines
Éric Leblond
courriel : [email protected]
#1 lore raw
Quoted 6 lines · Eric Leblond

Has somebody realyy manage to use the examples given when using negative offset in u32 ?

I look at the kernel code, I'm almost a real beginner here so I could wrote stupid things :

Quoted 13 lines

I saw that in the file cls_u32.c we work with skb and use only skb->nh.raw. That's the network header, so we don't have any information about Ethernet header (it's in skb->mac.raw that we have the ethernet header and that the protocol is given).
Furthermore (maybe i'm wrong cause of inverted stockage in memory) in the skbuf struct the ethernet header union follow the network header union so we should read something else.
Thus we can at least say that negative offset in u32 are really "tricky" and really non clean and as seems to show experiment that they don't work (?)

Eric,

the following offsets are from a mail previously posted on this list.
I hope it helps.

Stephane Ouellette.

Decimal Ofs Description
-----------------------------------
-14: DST MAC, 6 bytes
-8: SRC MAC, 6 bytes
-2: Eth PROTO, 2 bytes, eg. ETH_P_IP
0: Protocol header (IP Header)

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

#2 lore raw
In reply to Eric Leblond
Quoted 7 lines
Quoted 2 lines · Eric Leblond

Has somebody realyy manage to use the examples given when using negative offset in u32 ?

Quoted 6 lines

Decimal Ofs Description
-----------------------------------
-14: DST MAC, 6 bytes
-8: SRC MAC, 6 bytes
-2: Eth PROTO, 2 bytes, eg. ETH_P_IP
0: Protocol header (IP Header)

Yes I try these one. But I was unable to get them working.
So I look at the kernel code and find that's it is (for me) impossible to access these fields

BR

Signature · 7 lines
Eric Leblond
courriel : [email protected]
Computer are like air conditionners, they don't work when windows are open.

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/
#3 lore raw
In reply to Eric Leblond

Hello,

Quoted 7 lines · Eric Leblond

I look at the kernel code, I'm almost a real beginner here so I could wrote stupid things :

I saw that in the file cls_u32.c we work with skb and use only skb->nh.raw. That's the network header, so we don't have any information about Ethernet header (it's in skb->mac.raw that we have the ethernet header and that the protocol is given).

Everything starts from the net drivers (drivers/net/*.c):

- dev_alloc_skb() is used to reserve skb head space for the eth hdr and data space for the packet

- NIC stores ethhdr and packet there

- eth_type_trans() is called to set skb->mac.raw and to skip the eth header by incrementing skb->data with skb_pull()

- net/core/dev.c sets skb->nh.raw = skb->data and packet is passed to upper layers where tc ingress works

Quoted 3 lines

Furthermore (maybe i'm wrong cause of inverted stockage in memory) in the skbuf struct the ethernet header union follow the network header union so we should read something else.

tc sees:

skb:

+-------+	head
|	|		before ofs=-14: more reserved bytes
|	|		ofs=-14: dst mac
|	|		ofs=-8: src mac
|ethhdr	|		ofs=-2: eth proto
+-------+	data	ofs=+0, same as nh.raw
|packet	|
|	|
+-------+	tail
|	|
+-------+	end

As for u32_classify, nh.ptr is used as base offset, later the 'ptr' is adjusted by signed int offsets, so it can touch lower addresses.

Quoted 3 lines

Thus we can at least say that negative offset in u32 are really "tricky" and really non clean and as seems to show experiment that they don't work (?)

This is a hack, of course (may be designed so). But
it works for me (tm)

Regards

--
Julian Anastasov <[email protected]>

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/