LIST_FIND in netfilter_ipv4/listhelp.h
Hi folks,
I'm currently trying to make a patch on conntrack module. While reading some code I saw the following in include/linux/netfilter_ipv4/listhelp.h :
/* Works on circular linked list. */
#define LIST_FIND(head, cmpfn, type, args...) \
({ \
const struct list_head *__i = (head); \
\
ASSERT_READ_LOCK(head); \
do { \
__i = __i->next; \
if (__i = (head)) { \
__i = NULL; \
break; \
} \
} while (!cmpfn((const type)__i , ## args)); \
(type)__i; \
})Unless I really drank too much yesterday evening, I'm pretty sure this algorithm will fail if the list has only one element, returning NULL immediately without even trying to compare the element.
On the other hand, it seems to work pretty well for months, since it is widely used accross the NetFilter conntrack code. So where am I wrong ?
Thanks in advance.
Regards,
Signature · 6 lines
Jeremie LE HEN aka TtZ/TataZ [email protected] [email protected] Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread! _______________________________________________ LARTC mailing list / [email protected] http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/
Hi
* jeremie le-hen <[email protected]> 2003-10-06 16:44
Quoted 5 lines
Unless I really drank too much yesterday evening, I'm pretty sure this algorithm will fail if the list has only one element, returning NULL immediately without even trying to compare the element.
On the other hand, it seems to work pretty well for months, since it is widely used accross the NetFilter conntrack code. So where am I wrong ?
The code is correct.
Check include/linux/list.h, it's a cyclic list:head->next points to first elementhead->prev points to last element
the list iteration code will make it clear:
#define __list_for_each(pos, head) \
for (pos = (head)->next; pos != (head); pos = pos->next)Regards
Signature · 4 lines
Thomas GRAF <[email protected]> _______________________________________________ LARTC mailing list / [email protected] http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/