Skip to contentSkip to conversation

patch: avoid segfault when using PRIO qdisc

LARTC Nikolai Vladychevski 1 participant 1 message Jul 7, 2001

lore
Share & tools
lore
#0 lore raw

Hi,

I am attaching the patch for tc_class.c file in ./tc directory of iproute2 lastest version. This patch is to avoid segfault when listing classes. It happends only when using PRIO qdisc. I didn't look why exactly it segfaults (guess becasue PRIO is classless), but this patch at least prevents it, so you can run the command and look what is happening to other classes.

cd to iproute2 directory:

# patch tc/tc_class.c antisegfault-patch-for-tc.diff
# make
# cp tc/tc /usr/bin

tc -s class show dev eth0
now works

Regards

Nikolai

233c233,235
< if ((q = get_qdisc_kind(RTA_DATA(tb[TCA_KIND]))) != NULL)
---

Quoted 3 lines
	if ((q = get_qdisc_kind(RTA_DATA(tb[TCA_KIND]))) != NULL) {
	    if (!q->print_copt) fprintf(fp, "[can't get Class options, no function defined, sorry the code is buggy!!]");
	    else

235c237
< else
---

Quoted 1 line
	} else