aic7xxx and hotplug : part II

DISCUSSION christophe barbe 3 participants 8 messages Oct 16, 2001

Share & tools

christophe barbe

author

2001-10-16 16:13 UTC #0 lore raw

So I've proposed the patch to the driver author. The export table macro was already in the pending patch for 2.4.12. So this should be solved soon.

Remains a problem, I get a OOPS when I do the following :
. insert card (card detected, module loaded)
. mount /dev/sdc0 /cdrw
. use /cdrw
. umount /cdrw
. remove the card
. mount /dev/sdc0 /cdrw (oops and mount segfault)

lspci show the adaptec card when inserted
...
00:13.0 CardBus bridge: Toshiba America Info Systems ToPIC95 (rev 07) 00:13.1 CardBus bridge: Toshiba America Info Systems ToPIC95 (rev 07) 14:00.0 SCSI storage controller: Adaptec AIC-1480 / APA-1480 (rev 03) and no more after reemoving the card.

I see in /var/log/message that the 'PCI remove event' is not supported by hotplug

Oct 16 17:33:13 turing kernel: cs: cb_free(bus 20)
Oct 16 17:33:14 turing /etc/hotplug/pci.agent: PCI remove event not

supported

My understanding was that here the hotplug job was only to unload the driver but because it can be used by another device, I understand it's not so simple.

But the oops tells me that Something is required. It looks like the driver still believe that the card is available.
Is it something that must be done like ask to the driver to rescan its own devices.

Christophe

Signature · 7 lines

Christophe Barbé <[email protected]>
GnuPG FingerPrint: E0F6 FADF 2A5C F072 6AF8  F67A 8F45 2F1E D72C B41E

_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Greg KH

2001-10-16 16:41 UTC #1 lore raw

Quoted 1 line · christophe barbe

. mount /dev/sdc0 /cdrw (oops and mount segfault)

Please run the oops through ksymoops and send it to the driver's author. We can't do much here :)

thanks,

greg k-h

_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

christophe barbe

author

2001-10-16 17:42 UTC #2 lore raw

In reply to christophe barbe

Quoted 5 lines · Greg KH

Quoted 1 line · christophe barbe
. mount /dev/sdc0 /cdrw (oops and mount segfault)
Please run the oops through ksymoops and send it to the driver's author. We can't do much here :)

So do you suggest me that this is a problem with the driver. I was convinced it was because nobody notified the driver that the device was removed.

I need to do some other test but I guess that if I manually unload the driver then I will avoid the oops.

Christophe

Quoted 9 lines

thanks,
greg k-h
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Signature · 7 lines

Christophe Barbé <[email protected]>
GnuPG FingerPrint: E0F6 FADF 2A5C F072 6AF8  F67A 8F45 2F1E D72C B41E

_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Greg KH

2001-10-16 18:03 UTC #3 lore raw

In reply to christophe barbe

Quoted 2 lines · christophe barbe

So do you suggest me that this is a problem with the driver.

Yes.

Quoted 2 lines

I was convinced it was because nobody notified the driver that the device was removed.

The driver knows that it was removed due to the pci interface. The linux-hotplug package is for notifying userspace that a device was removed, not for telling the driver this :)

thanks,

greg k-h

David Brownell

2001-10-16 18:15 UTC #4 lore raw

In reply to christophe barbe

Quoted 4 lines

Quoted 2 lines
Please run the oops through ksymoops and send it to the driver's author. We can't do much here :)
So do you suggest me that this is a problem with the driver.

Nobody can do more than "suggest" without facts like the ksymoops output ...

Quoted 2 lines

I was convinced it was because nobody notified the driver that the device was removed.

The kernel tells the driver when the device goes away. Of course that might be _after_ the CardBus device was physically removed; the driver has to cope with that.

- Dave

christophe barbe

author

2001-10-16 20:22 UTC #5 lore raw

In reply to christophe barbe

Ok sorry if it takes time for me to understand.
You start convinced me that the problem can be from the driver.

I attach the oops and the ksymoops output.

Christophe

Quoted 23 lines · David Brownell

Quoted 1 line
Quoted 1 line
Please run the oops through ksymoops and send it to the driver's
author.
Quoted 3 lines
Quoted 1 line
We can't do much here :)
So do you suggest me that this is a problem with the driver.
Nobody can do more than "suggest" without facts like the ksymoops output ...
Quoted 1 line
I was convinced it was because nobody notified the driver that the
device
Quoted 1 line
was removed.
The kernel tells the driver when the device goes away. Of course that might be _after_ the CardBus device was physically removed; the driver has to cope with that.
- Dave

Signature · 2 lines

Christophe Barbé <[email protected]>
GnuPG FingerPrint: E0F6 FADF 2A5C F072 6AF8  F67A 8F45 2F1E D72C B41E

Greg KH

2001-10-16 20:27 UTC #6 lore raw

In reply to christophe barbe

Quoted 4 lines · christophe barbe

Ok sorry if it takes time for me to understand.
You start convinced me that the problem can be from the driver.
I attach the oops and the ksymoops output.

You might want to send this to the author of the driver, along with the steps that you did to get the oops.

thanks,

greg k-h

christophe barbe

author

2001-10-16 20:53 UTC #7 lore raw

In reply to christophe barbe

I'm doing it now that I'm convinced that it's a driver bug. Thank for your help.

Christophe

Quoted 13 lines · Greg KH

Quoted 4 lines · christophe barbe
Ok sorry if it takes time for me to understand.
You start convinced me that the problem can be from the driver.
I attach the oops and the ksymoops output.
You might want to send this to the author of the driver, along with the steps that you did to get the oops.
thanks,
greg k-h

Signature · 7 lines

Christophe Barbé <[email protected]>
GnuPG FingerPrint: E0F6 FADF 2A5C F072 6AF8  F67A 8F45 2F1E D72C B41E

_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel