Skip to contentSkip to conversation

ieee1394 patch

PATCH Dan Dennedy 3 participants 4 messages Mar 20, 2003 – Apr 18, 2003

lore
Share & tools
lore

Dan Dennedy

author
#0 lore raw

I am a member of the Linux 1394 team, and I have been improving hotplug capabilities of various ieee1394 modules. Below is my patch to the agent script. For two different classes of video camera, some applications require 2 modules: one for the control protocol and another for the streaming video. Therefore, you see I removed that break. Also, I added support for a module-specific script directory. This is especially useful for sbp2 to invoke the popular rescan-scsi-bus.sh script, /etc/hotplug/ieee1394/sbp2 script:

#!/bin/bash
if [ "${ACTION}" = "add" ]; then
. rescan-scsi-bus.sh
else
. rescan-scsi-bus.sh -r
fi

Similarly, a dv1394 script could launch Kino on add, and a video1394 script could launch Coriander on add.

Index: etc/hotplug/ieee1394.agent
===================================================================
RCS file: /cvsroot/linux-hotplug/admin/etc/hotplug/ieee1394.agent,v retrieving revision 1.8

hotplug/ieee1394.agent 20 Mar 2003 17:59:02 -0000 renamed from hotplug/ieee1394.agent 18 Jan 2003 01:27:07 -0000 1.8 +8 -2
diff -u -p -r1.8 ieee1394.agent
@@ -51,7 +51,7 @@ MATCH_VERSION=0x0008
  
 #
 # stdin is "modules.ieee1394map" syntax
-# on return, ONE matching module was added to $DRIVERS
+# on return, all matching modules were added to $DRIVERS
 #
 ieee1394_map_modules ()
 {

@@ -82,7 +82,6 @@ ieee1394_map_modules ()
        fi
  
         DRIVERS="$module $DRIVERS"
-       break
     done
 }
  

@@ -103,6 +102,13 @@ add)
        mesg "... no drivers for $LABEL"
        exit 2
     fi
+
+    for MODULE in $DRIVERS
+    do
+    if [ -x $HOTPLUG_DIR/ieee1394/$MODULE ]; then
+           $HOTPLUG_DIR/ieee1394/$MODULE
+    fi
+    done
  
     if [ -x /sbin/devlabel ]; then
         /sbin/devlabel restart
#1 lore raw
Quoted 9 lines · Dan Dennedy

I am a member of the Linux 1394 team, and I have been improving hotplug capabilities of various ieee1394 modules. Below is my patch to the agent script. For two different classes of video camera, some applications require 2 modules: one for the control protocol and another for the streaming video. Therefore, you see I removed that break. Also, I added support for a module-specific script directory. This is especially useful for sbp2 to invoke the popular rescan-scsi-bus.sh script, /etc/hotplug/ieee1394/sbp2 script:

Quoted 6 lines

#!/bin/bash
if [ "${ACTION}" = "add" ]; then
. rescan-scsi-bus.sh
else
. rescan-scsi-bus.sh -r
fi

Make sure this doesn't run on 2.5.x. We have scsi hotplug there.

Signature · 15 lines
Debian     - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
Deqo       - http://www.deqo.com/


-------------------------------------------------------
This SF.net email is sponsored by: Tablet PC.  
Does your code think in ink? You could win a Tablet PC. 
Get a free Tablet PC hat just for playing. What are you waiting for? 
http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
author
#2 lore raw
In reply to Dan Dennedy
Quoted 9 lines · Ben Collins
Quoted 7 lines

#!/bin/bash
if [ "${ACTION}" = "add" ]; then
. rescan-scsi-bus.sh
else
. rescan-scsi-bus.sh -r
fi

Make sure this doesn't run on 2.5.x. We have scsi hotplug there.

Good point. This is mostly an example of my personal configuration. It should be easy to add sed against uname or /proc/version to check the kernel version for a generic script.

-------------------------------------------------------
This SF.net email is sponsored by: Tablet PC.
Does your code think in ink? You could win a Tablet PC.
Get a free Tablet PC hat just for playing. What are you waiting for?
http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

#3 lore raw
In reply to Dan Dennedy
Quoted 5 lines · Dan Dennedy

I am a member of the Linux 1394 team, and I have been improving hotplug capabilities of various ieee1394 modules. Below is my patch to the agent script. For two different classes of video camera, some applications require 2 modules: one for the control protocol and another for the streaming video. Therefore, you see I removed that break.

Merged. Your other patch was already in CVS; were you not using the repository at SourceForge?

- Dave

-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel