static klibc udev does not link against crt0.o

PATCH In review Olaf Hering 2 participants 4 messages Nov 18, 2003 – Nov 23, 2003 Kbuild

lore

Share & tools

lore

Olaf Hering

author

2003-11-18 22:33 UTC #0 lore raw

PATCH 1/1 static klibc udev does not link against crt0.o

no crt0.o means no _start which means no environ which means segfault in start in getenv.c

Makefile 2003-11-18 23:30:43.839448790 +0100 renamed from Makefile~ 2003-11-18 23:12:28.000000000 +0100 +1 -1

@@ -166,7 +166,7 @@
 
 
 $(ROOT): $(GEN_HEADERS) $(OBJS)
-       $(CC) $(LDFLAGS) -o $(ROOT) $(OBJS) $(LIB_OBJS) $(ARCH_LIB_OBJS)
+       $(CC) $(LDFLAGS) -o $(ROOT) $(OBJS) $(LIB_OBJS) $(ARCH_LIB_OBJS) $(CRT0)
        $(STRIPCMD) $(ROOT)
 
 clean:

Or is there a reason to not link agaisnt crt0.o? Would be bad for ppc32.

Signature · 14 lines

USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Greg KH

2003-11-19 06:52 UTC #1 lore raw

Quoted 2 lines · Olaf Hering

no crt0.o means no _start which means no environ which means segfault in start in getenv.c

Use Makefile.klibc to build with klibc. If you look at the bk tree this is all fixed up. I'll try to make a release in a few days.

thanks,

greg k-h

-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Olaf Hering

author

2003-11-22 09:04 UTC #2 lore raw

In reply to Olaf Hering

Quoted 5 lines · Greg KH

Quoted 1 line
I did 'make KLIBC=true' in the current bk tree.
try 'make -f Makefile.klibc' in the current tree. For some reason I couldn't figure out how to have Makefile work for both KLIBC=true and KLIBCúlse. But I didn't try too hard :)

I dont understand that.

please do rm -f Makefile.klibc; apply this patch and tell me what fails. works for me.

Makefile +2 -2

@@ -166,7 +166,7 @@
 
 
 $(ROOT): $(GEN_HEADERS) $(OBJS)
-	$(CC) $(LDFLAGS) -o $(ROOT) $(OBJS) $(LIB_OBJS) $(ARCH_LIB_OBJS)
+	$(CC) $(LDFLAGS) -o $(ROOT) $(CRT0) $(OBJS) $(LIB_OBJS) $(ARCH_LIB_OBJS)
 	$(STRIPCMD) $(ROOT)
 
 clean:

@@ -215,7 +215,7 @@
 	$(INSTALL_DATA) -D udev.8 $(DESTDIR)$(mandir)/man8/udev.8
 	$(INSTALL_DATA) udev.config $(DESTDIR)$(configdir)
 	$(INSTALL_DATA) udev.permissions $(DESTDIR)$(configdir)
-	- rm $(DESTDIR)$(hotplugdir)/udev.hotplug
+	- rm -f $(DESTDIR)$(hotplugdir)/udev.hotplug
 	- ln -s $(sbindir)/$(ROOT) $(DESTDIR)$(hotplugdir)/udev.hotplug
 
 uninstall:

%build
make KLIBC=%{use_klibc} DEBUGúlse
cp -av udev udev.static
make KLIBC=%{use_klibc} DEBUGúlse clean
make KLIBCúlse DEBUG=true
cp -av udev udev.debug
cd libsysfs
ar cru libsysfs.a *.o ../logging.o
ranlib libsysfs.a
cd ..
make -C extras/scsi_id CC="gcc $RPM_OPT_FLAGS -Ipwd/libsysfs -Lpwd/libsysfs"

this is what I use.

Signature · 14 lines

USB is for mice, FireWire is for men!

sUse lINUX ag, nÃœRNBERG


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Greg KH

2003-11-23 06:00 UTC #3 lore raw

In reply to Olaf Hering

Quoted 4 lines · Olaf Hering

Quoted 2 lines · Greg KH
Quoted 1 line
I did 'make KLIBC=true' in the current bk tree.

Quoted 8 lines

Quoted 3 lines
try 'make -f Makefile.klibc' in the current tree. For some reason I couldn't figure out how to have Makefile work for both KLIBC=true and KLIBCúlse. But I didn't try too hard :)
I dont understand that.
please do rm -f Makefile.klibc; apply this patch and tell me what fails. works for me.

Doh, thanks, I've applied this and deleted Makefile.klibc. Thanks a lot for this.

Quoted 12 lines

%build
make KLIBC=%{use_klibc} DEBUGúlse
cp -av udev udev.static
make KLIBC=%{use_klibc} DEBUGúlse clean
make KLIBCúlse DEBUG=true
cp -av udev udev.debug
cd libsysfs
ar cru libsysfs.a *.o ../logging.o
ranlib libsysfs.a
cd ..
make -C extras/scsi_id CC="gcc $RPM_OPT_FLAGS -Ipwd/libsysfs -Lpwd/libsysfs"

Quoted 1 line

this is what I use.

Nice to see scsi_id building properly.

thanks,

greg k-h