Skip to contentSkip to conversation

Small patch for hotplug scripts, success story

DISCUSSION Norbert Preining 2 participants 2 messages Jan 12, 2001

lore
Share & tools
lore
#0 lore raw

Hi there!

Small success story after fixing one problem:

linux-2.4.0-final + modutils/hotplug patch
modutils-2.4.1

hotplugging works IF:

* usbmodules is removed: It gives NOTHING! at the moment, at least for my devices
* fix in hotplug.function:

	LISTER=`which ${1}modules 2>/dev/null`
  unfortunately if which is /usr/bin/which we get
	LISTER="which: no usbmodules in ...."
  because /usr/bin/which don't write this message to stderr, but stdout.
  Therefor no internal scanning is done and nothing works.
  Better would be
	LISTER=`type -p ${1}modules`

since these scripts are bash and `type' is a buildin.

But after these two changes (remove usbmodules and fix which<->type -p) it is working!

Best wishes

Norbert

Signature · 13 lines
ciao
norb

+-------------------------------------------------------------------+
| Norbert Preining              http://www.logic.at/people/preining |
| University of Technology Vienna, Austria        [email protected] |
| DSA: 0x09C5B094 (RSA: 0xCF1FA165) mail subject: get [DSA|RSA]-key |
+-------------------------------------------------------------------+

_______________________________________________
Linux-hotplug-devel mailing list
[email protected]
http://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
#1 lore raw

Hi Norbert,

Quoted 7 lines

linux-2.4.0-final + modutils/hotplug patch
modutils-2.4.1

hotplugging works IF:

* usbmodules is removed: It gives NOTHING! at the moment, at least for my devices

Right -- the current version won't understand the 2.4.1 modutils output, but then its standard install isn't in the path that the hotplug scripts use.

Quoted 6 lines

* fix in hotplug.function:
LISTER=which ${1}modules 2>/dev/null
unfortunately if which is /usr/bin/which we get
LISTER="which: no usbmodules in ...."
because /usr/bin/which don't write this message to stderr, but stdout. Therefor no internal scanning is done and nothing works.

Curious. I didn't see that, but then maybe I'm running with a "which" command that doesn't have that bug.

Quoted 3 lines

Better would be
LISTER=type -p ${1}modules
since these scripts are bash and `type' is a buildin.

Sounds good! The fix is now in CVS (at linux-usb for now).

Quoted 2 lines

But after these two changes (remove usbmodules and fix which<->type -p) it is working!

Great! Thanks for the confirmation.

- Dave

_______________________________________________
Linux-hotplug-devel mailing list
[email protected]
http://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel