Skip to contentSkip to conversation

fix for modules_install

PATCH In review Uros Prestor 3 participants 5 messages Aug 15, 2000 – Aug 17, 2000

lore
Share & tools
lore

Uros Prestor

author
#0 lore raw

PATCH 1/1 fix for modules_install

This trivial patch against 2.4.0-test6 + 000812 fixes a problem with modules_install target.

Uros

--
Uros Prestor
[email protected]

arch/ia64/tools/Makefile +1 -1
diff -ruN linux-2.4.0-test6-000811/arch/ia64/tools/Makefile linux-2.4.0-test6-000811.modules/arch/ia64/tools/Makefile
@@ -46,4 +46,4 @@
 
 endif
 
-.PHONY: all modules
+.PHONY: all modules modules_install
#1 lore raw
Quoted 5 lines · Uros Prestor

This trivial patch against 2.4.0-test6 + 000812 fixes a problem with modules_install target.

-.PHONY: all modules
+.PHONY: all modules modules_install

What problem does it fix?

author
#2 lore raw
In reply to Uros Prestor
Quoted 9 lines · Keith Owens
Quoted 5 lines · Uros Prestor

This trivial patch against 2.4.0-test6 + 000812 fixes a problem with modules_install target.

-.PHONY: all modules
+.PHONY: all modules modules_install

What problem does it fix?

File arch/ia64/tools/Makefile didn't have a target modules_install so `make modules_install' returned an error. This patch adds a phony target which does nothing.

Uros

--
Uros Prestor
[email protected]

#3 lore raw
In reply to Uros Prestor
Quoted 7 lines · Uros Prestor
Quoted 5 lines · Keith Owens
Quoted 3 lines · Uros Prestor

This trivial patch against 2.4.0-test6 + 000812 fixes a problem with modules_install target.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

-.PHONY: all modules
+.PHONY: all modules modules_install

What problem does it fix?

File arch/ia64/tools/Makefile didn't have a target modules_install so `make modules_install' returned an error. This patch adds a phony target which does nothing.

arch/ia64/tools/Makefile should include Rules.make instead of adding its own target and .PHONY rules. see arch/mips/tools/Makefile. AFAICT there is no reason not to include Rules.make.

#4 lore raw
In reply to Uros Prestor
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Keith Owens

Keith> arch/ia64/tools/Makefile should include Rules.make instead of Keith> adding its own target and .PHONY rules. see Keith> arch/mips/tools/Makefile. AFAICT there is no reason not to Keith> include Rules.make.

I'd be happy to make the change _if_ it's really safe to do so. We're doing some weird build tricks in a cross-build environment and I want to make sure we don't break that code.

	--david