Skip to contentSkip to conversation

unregister_rebbot_notifier()

Linux-ia64 Randall G Chan/Fremont/IBM 2 participants 4 messages Sep 21, 2000 – Sep 22, 2000

lore
Share & tools
lore
#0 lore raw

Below is a small snippet of code that will make the kernel hang on a reboot. It hangs in the call to unregister_reboot_notifier() [on a reboot when the module is loaded]. It seems that it hangs in this function while trying to call write_lock(&notifier_lock). Looks like something that grabbed the long before never set the lock back to unlocked. I've tried this on 2.4.0-test7 on a BigSur A3, 1 GB mem, BIOS 70 and a Lion B0, 1 GB mem, BIOS 55. This code works fine if you remove the module (rmmod), but if you insert it and reboot the machine using reboot, shutdown, three-finger-salute, it'll hang.

Also, I can't seem to get this module to load on 2.4.0-test8. This system just seems to hang after trying to insert the module. I've seen this happen on the same two machines listed above. Are there any known problems in test8 in relation to module loading?

Thanks,
Randy Chan
[email protected]

--------------------------------------------------------------------------

#define MODULE
#define __KERNEL__
#include <linux/version.h>
#include <linux/module.h>
#include <linux/types.h>
#include <linux/notifier.h>

static int mod_finalize(struct notifier_block *, unsigned long, void *); static struct notifier_block NBlk = { mod_finalize, NULL, 0 };

int init_module(void)

{
    printk("<1>Inserted!\n");
    register_reboot_notifier(&NBlk);
    return 0;
}

void cleanup_module(void)

{
    mod_finalize(&NBlk, SYS_RESTART, NULL);
    printk("<1>Removed!\n");
}

static int mod_finalize(struct notifier_block *nb, unsigned long event, void *buf)

{
    printk("Finalizing!\n");
    unregister_reboot_notifier(&NBlk);
}
#1 lore raw
Quoted 4 lines · Randall G Chan/Fremont/IBM

Also, I can't seem to get this module to load on 2.4.0-test8. This system just seems to hang after trying to insert the module. I've seen this happen on the same two machines listed above. Are there any known problems in test8 in relation to module loading?

Probably a mismatch between kernel code and modutils. What does this report?

grep -B 5 -A 5 module_arch_init kernel/module.c
/sbin/depmod --version

#2 lore raw
In reply to Randall G Chan/Fremont/IBM
Quoted 4 lines · Randall G Chan/Fremont/IBM

Also, I can't seem to get this module to load on 2.4.0-test8. This system just seems to hang after trying to insert the module. I've seen this happen on the same two machines listed above. Are there any known problems in test8 in relation to module loading?

Please try modutils 2.3.16 plus the patch at ftp://ftp.ocs.com.au/private/modutils-2.3.16-patch-1, let me know if it works so I can release it as modutils 2.3.17.

#3 lore raw
In reply to Randall G Chan/Fremont/IBM

I didn't test it extensively, but I inserted a couple of modules and everything seem to be okay. And my problem was that I did have a mismatch btwn modutils and the kernel.

Thanks,
Randy Chan
[email protected]

--------------------------------------------------------------------------

Keith Owens
<[email protected]> To: [email protected]
Sent by: cc: Randall G Chan/Fremont/IBM@IBMUS
linux-ia64-admin@lin Subject: Re: [Linux-ia64] unregister_rebbot_notifier()
uxia64.org

09/21/00 04:44 PM

Quoted 3 lines · Randall G Chan/Fremont/IBM

Also, I can't seem to get this module to load on 2.4.0-test8. This system just seems to hang after trying to insert the module. I've seen this happen on the same two machines listed above. Are there any known

problems

Quoted 1 line

in test8 in relation to module loading?

Please try modutils 2.3.16 plus the patch at ftp://ftp.ocs.com.au/private/modutils-2.3.16-patch-1, let me know if it works so I can release it as modutils 2.3.17.

_______________________________________________
Linux-IA64 mailing list
[email protected]
http://lists.linuxia64.org/lists/listinfo/linux-ia64