Skip to contentSkip to conversation

CR[TPR] initialization in test12 kernel

Linux-ia64 Hirofumi Fujita 1 participant 1 message Dec 21, 2000

lore
Share & tools
lore
#0 lore raw

Hi,

In test12 kernel,
CR[TPR] is not initialized for APs (application processors).

SAL spec says nothing about it's value at SAL to OS handoff, but we cannot expect it has been set to 0.
So it should be set to 0 when interrupts are enabled in smp_callin().

BSP's CR[TPR] is correctly initialized in init_IRQ().

arch/ia64/kernel/smp.c renamed from arch/ia64/kernel/smp.c.org +1 -0
@@ -532,6 +532,7 @@
 	ia64_set_lrr0(0, 1);	
 	ia64_set_lrr1(0, 1);	
 
+	ia64_set_tpr(0);
 	local_irq_enable();		/* Interrupts have been off until now */
 
 	calibrate_delay();

And, here is another patch for init_IRQ().
CR[CMCV] is already initialized to correct value in ia64_mca_init().

arch/ia64/kernel/irq_ia64.c renamed from arch/ia64/kernel/irq_ia64.c.org +0 -1
@@ -165,7 +165,6 @@
 #endif
 
 	ia64_set_pmv(1 << 16);
-	ia64_set_cmcv(CMC_IRQ);			/* XXX fix me */
 
 	platform_irq_init();
 

Thanks,

Hirofumi Fujita
Hitachi, Ltd.