Skip to contentSkip to conversation

more problems with 2001-02-28 kit (can't build uniprocessor)

Linux-ia64 John Kohl 2 participants 2 messages Mar 1, 2001

lore
Share & tools
lore

John Kohl

author
#0 lore raw

I ran into more build problems with the 2001-02-28 patch kit. I can't build a non-SMP kernel.

One bug I can fix, the other I'm not sure what the right thing to do is.

irq.c:458:28: too many arguments in invocation of macro "local_irq_count" irq.c:474:27: too many arguments in invocation of macro "local_irq_count" irq.c: In function `handle_IRQ_event':
irq.c:458: `local_irq_count' undeclared (first use in this function) irq.c:458: (Each undeclared identifier is reported only once irq.c:458: for each function it appears in.)

This is fixable by the attached patch.

irq_ia64.c: In function `init_IRQ':
irq_ia64.c:158: `ipi_irqaction' undeclared (first use in this function) irq_ia64.c:158: (Each undeclared identifier is reported only once irq_ia64.c:158: for each function it appears in.)

This, I'm not sure what to do--should IPI-related stuff even be compiled when CONFIG_SMP is not set?

asm-ia64/hardirq.h renamed from hardirq.h.~1~ +2 -2
@@ -41,8 +41,8 @@
 # define local_hardirq_trylock()	(local_irq_count() = 0)
 # define local_hardirq_endlock()	do { } while (0)
 
-# define local_irq_enter(irq)		(local_irq_count(cpu)++)
-# define local_irq_exit(irq)		(local_irq_count(cpu)--)
+# define local_irq_enter(irq)		(local_irq_count()++)
+# define local_irq_exit(irq)		(local_irq_count()--)
 
 # define synchronize_irq()		barrier()
 #else
Signature · 4 lines
=John Kohl <[email protected]>, Senior Staff Software Engineer
Rational Software, Configuration Management Business Unit
Mark your calendars!  Rational User Conference 2001, July 22-26, 2001
in beautiful Denver, Colorado
#1 lore raw

Re: [Linux-ia64] more problems with 2001-02-28 kit (can't build

Quoted 6 lines · John Kohl

I ran into more build problems with the 2001-02-28 patch kit. I can't build a non-SMP kernel.

One bug I can fix, the other I'm not sure what the right thing to do is.

Uh, I've submitted a patch which solves both of these problems (in fact, the first part is exactly the same as yours, indeed) but it hasn't reached the list for some reason...

Quoted 4 lines

This, I'm not sure what to do--should IPI-related stuff even be compiled when CONFIG_SMP is not set?

Normally no, IPI is not needed on UP.

Signature · 4 lines
Francis Galiegue, [email protected] - Normand et fier de l'être
"Programming is a race between programmers, who try and make more and more
idiot-proof software, and universe, which produces more and more remarkable
idiots. Until now, universe leads the race"  -- R. Cook