Skip to contentSkip to conversation

Compile fixes for UP ia64 - IRQ stuff (RESEND)

Linux-ia64 Francis Galiegue 1 participant 1 message Mar 1, 2001

lore
Share & tools
lore
#0 lore raw

[same as previous mail... Sent 6 hrs ago but did not arrive]

OK, I've found what was wrong... Attached patch is over 2.4.2 plus 010228 patch, and it fixes the following:

- include/asm-ia64/hardirq.h: invalid local_irq_count() usage in local_enter_irq()
- arch/ia64/kernel/irq_ia64.c: IPI was registered on UP also, but I don't think it's used at all (or is it?), and what's more ipi_irqaction definition is surrounded by #ifdef CONFIG_SMP .. #endif. So I also #ifdef'ed the IPI registering out.

WDYT?

Signature · 4 lines
Francis Galiegue, [email protected] - Normand et fier de l'être
"Programming is a race between programmers, who try and make more and more
idiot-proof software, and universe, which produces more and more remarkable
idiots. Until now, universe leads the race"  -- R. Cook
arch/ia64/kernel/irq_ia64.c +2 -0
diff -urN linux-old/arch/ia64/kernel/irq_ia64.c linux/arch/ia64/kernel/irq_ia64.c
@@ -155,7 +155,9 @@
 init_IRQ (void)
 {
 	register_percpu_irq(IA64_SPURIOUS_INT_VECTOR, NULL);
+#ifdef CONFIG_SMP
 	register_percpu_irq(IA64_IPI_VECTOR, &ipi_irqaction);
+#endif
 	platform_irq_init();
 }
 

Binary files linux-old/arch/ia64/tools/print_offsets and linux/arch/ia64/tools/print_offsets differ

include/asm-ia64/hardirq.h +2 -2
diff -urN linux-old/include/asm-ia64/hardirq.h linux/include/asm-ia64/hardirq.h
@@ -41,8 +41,8 @@
 # define local_hardirq_trylock()	(local_irq_count() == 0)
 # define local_hardirq_endlock()	do { } while (0)
 
-# define local_irq_enter(irq)		(local_irq_count(cpu)++)
-# define local_irq_exit(irq)		(local_irq_count(cpu)--)
+# define local_irq_enter(irq)		(local_irq_count()++)
+# define local_irq_exit(irq)		(local_irq_count()--)
 
 # define synchronize_irq()		barrier()
 #else