Skip to contentSkip to conversation

kdb v1.8 updates are available

Linux-ia64 Don Dugger 1 participant 1 message May 8, 2001

lore
Share & tools
lore

Don Dugger

author
#0 lore raw

Keith-

Here's a patch to the IA64 version of KDB that fixes two pet peeves of mine:

1) Enable ANY command (especially `ss') to be repeated by a simple carriage return. (I didn't implement one of your wish list items, only allow certain commands to be repeated. The cleanest way I could think of to do this is to add a flag to `kdb_register' to indicate this and, as this routine is an externally exported interface, I didn't feel comfortable changing it right now.)

2) Change `kdb_id1' to only print out the target instruction rather than the entire bundle. It's really tough to single step through a program when 3 single steps in a row print out the same instruction bundle.

Quoted 33 lines · Keith Owens

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Content-Type: text/plain; charset=us-ascii

These updates to kdb have had minimal testing, they compile and boot for me(TM).

http://oss.sgi.com/projects/kdb/download/

ix86/

    kdb-v1.8-2.4.2-ac28.gz
    kdb-v1.8-2.4.3.gz
    kdb-v1.8-2.4.3-ac14.gz
    kdb-v1.8-2.4.4-pre7.gz

ia64/

    kdb-v1.8-2.4.3-ia64-010405.gz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.3 (GNU/Linux)
Comment: Exmh version 2.1.1 10/15/1999

iD8DBQE66Lrki4UHNye0ZOoRAgRGAJ44b1+nky5+uNJhWD93+bcOkQfxcgCg0RPg xpsQqw7whImmdGaY9+QB8AM=
=Huto
-----END PGP SIGNATURE-----

_______________________________________________
Linux-IA64 mailing list
[email protected]
http://lists.linuxia64.org/lists/listinfo/linux-ia64

Signature · 4 lines
Don Dugger
"Censeo Toto nos in Kansa esse decisse." - D. Gale
[email protected]
Ph: 303/938-9838

Index: arch/ia64/kdb/kdba_bp.c
===================================================================
RCS file: /trillian/src/cvs_root/linux-2.4/arch/ia64/kdb/Attic/kdba_bp.c,v retrieving revision 1.1.2.1

ia64/kdb/kdba_bp.c +1 -1
diff -u -r1.1.2.1 kdba_bp.c
@@ -174,7 +174,7 @@
 			kdb_machreg_t pc = ef->cr_iip + ia64_psr(ef)->ri * 6;
 			kdb_printf("SS trap at ");
 			kdb_symbol_print(pc, NULL, KDB_SP_DEFAULT|KDB_SP_NEWLINE);
-			kdb_id1(ef->cr_iip);
+			kdb_id1(pc);
 			KDB_STATE_CLEAR(DOING_SS);
 		}
 

Index: arch/ia64/kdb/kdba_id.c
===================================================================
RCS file: /trillian/src/cvs_root/linux-2.4/arch/ia64/kdb/Attic/kdba_id.c,v retrieving revision 1.1.2.1

ia64/kdb/kdba_id.c +9 -1
diff -u -r1.1.2.1 kdba_id.c
@@ -244,11 +244,19 @@
 {
 	int ret;
 	int byte=0;
+	int off = 0;
+
+	dip->fprintf_func = dip->fprintf_dummy;
+	off = pc & 0xf;
 	kdba_check_pc(&pc);
 	while (byte < 16) {
+		if (byte == off)
+			dip->fprintf_func = kdb_dis_fprintf;
+		else
+			dip->fprintf_func = dip->fprintf_dummy;
 		kdba_dis_printaddr(pc+byte, dip);
 		ret = print_insn_ia64((kdb_machreg_t)(pc+byte), dip);
-		kdb_printf("\n");
+		dip->fprintf_func(dip->stream, "\n");
 		if (ret < 0)
 			break;
 		byte += ret;

Index: include/linux/dis-asm.h
===================================================================
RCS file: /trillian/src/cvs_root/linux-2.4/include/linux/Attic/dis-asm.h,v retrieving revision 1.1.2.1

linux/dis-asm.h +1 -0
diff -u -r1.1.2.1 dis-asm.h
@@ -67,6 +67,7 @@
 
 typedef struct disassemble_info {
   fprintf_ftype fprintf_func;
+  fprintf_ftype fprintf_dummy;
   PTR stream;
   PTR application_data;
 

Index: include/linux/kdbprivate.h
===================================================================
RCS file: /trillian/src/cvs_root/linux-2.4/include/linux/Attic/kdbprivate.h,v retrieving revision 1.1.2.1

linux/kdbprivate.h +1 -0
diff -u -r1.1.2.1 kdbprivate.h
@@ -284,6 +284,7 @@
 	/*
 	 * General Disassembler interfaces
 	 */
+extern int kdb_dis_fprintf(PTR, const char *, ...) __attribute__ ((format (printf, 2, 3)));
 extern int kdb_dis_fprintf_dummy(PTR, const char *, ...) __attribute__ ((format (printf, 2, 3)));
 extern disassemble_info	kdb_di;
 

Index: kdb/kdb_id.c
===================================================================
RCS file: /trillian/src/cvs_root/linux-2.4/kdb/Attic/kdb_id.c,v retrieving revision 1.1.2.1

kdb_id.c +6 -4
diff -u -r1.1.2.1 kdb_id.c
@@ -99,6 +99,8 @@
 	if (diag)
 		return diag;
 
+	dip->fprintf_dummy = kdb_dis_fprintf;
+
 	mode = kdbgetenv("IDMODE");
 	diag = kdba_id_parsemode(mode, dip);
 	if (diag) {
@@ -141,6 +143,9 @@
 	 * Allow the user to specify that this instruction
 	 * should be treated differently.
 	 */
+
+	kdb_di.fprintf_dummy = kdb_dis_fprintf_dummy;
+
 	mode = kdbgetenv("IDMODE");
 	diag = kdba_id_parsemode(mode, &kdb_di);
 	if (diag) {
@@ -167,10 +172,7 @@
  * 	Result of format conversion cannot exceed 255 bytes.
  */
 
-static int
-kdb_dis_fprintf(PTR file, const char *fmt, ...)
-		__attribute__ ((format (printf, 2, 3)));
-static int
+int
 kdb_dis_fprintf(PTR file, const char *fmt, ...)
 {
 	char buffer[256];

Index: kdb/kdbmain.c
===================================================================
RCS file: /trillian/src/cvs_root/linux-2.4/kdb/Attic/kdbmain.c,v retrieving revision 1.1.2.1

kdbmain.c +32 -39

113 lines not on this page · raw message