Skip to contentSkip to conversation

efibootmgr-0.3.3 release

Linux-ia64 [email protected] 2 participants 3 messages Aug 3, 2001 – Aug 6, 2001

lore
Share & tools
lore

[email protected]

author
#0 lore raw
Quoted 8 lines

We have noticed (during RH7.1) install that efibootmgr was not checking
for options with an identical names and it was creating menu options with the same name for instance if you reinstall the system a second time.

Would it be possible to add a warning/error/check that would avoid such a thing ?

Good idea Stephane. I've added just such a warning. When creating a new boot variable, you'll get a warning on stderr if the label conflicts with an existing label. It'll let you do it though.

New release efibootmgr 0.3.3 is now available at
http://domsch.com/linux/ia64/efibootmgr-0.3.3.tar.gz.

Thanks,
Matt

--
Matt Domsch
Sr. Software Engineer
Dell Linux Solutions
www.dell.com/linux
#2 Linux Server provider with 17% in the US and 14% Worldwide (IDC)! #3 Unix provider with 18% in the US (Dataquest)!

#1 lore raw
Quoted 2 lines · On Fri, Aug 03, 2001 at 05:21:36PM -0500, [email protected] wrote:

New release efibootmgr 0.3.3 is now available at
http://domsch.com/linux/ia64/efibootmgr-0.3.3.tar.gz.

Goes bang for me... assuming efichar_strlen() is supposed to return the length in efichars, not bytes, the following fixes it. In any case a null is needed on the end of buffer[].

Richard

src/lib/efichar.c renamed from src/lib/efichar.c- +2 -1
@@ -36,11 +36,12 @@
 	char *buffer;
 	int s2_len = efichar_strlen(s2, -1);
 	
-	buffer = malloc(s2_len / sizeof(efi_char16_t));
+	buffer = malloc(s2_len+1);
 	if (!buffer) return -1;
 	for (i=0; i<(s2_len); i++) {
 		buffer[i] = s2[i] & 0xFF;
 	}
+	buffer[i] = '\0';
 	rc = strcmp(s1, buffer);
 	free(buffer);
 	return rc;
author
#2 lore raw
In reply to [email protected]
Quoted 4 lines

Goes bang for me... assuming efichar_strlen() is supposed to return the length in efichars, not bytes, the following fixes it. In any case
a null is needed on the end of buffer[].

Good catch. It hadn't blown up on me, but your patch is correct, and I've applied it. Thanks!!

--
Matt Domsch
Sr. Software Engineer
Dell Linux Solutions
www.dell.com/linux
#2 Linux Server provider with 17% in the US and 14% Worldwide (IDC)! #3 Unix provider with 18% in the US (Dataquest)!