to remove unused hcl_spinlock
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · David C. Hansen
David.Hansen> I was looking at spinlocks in the kernel and came David.Hansen> across hcl_spinlock. If you look at this paper:
David.Hansen> http://lse.sourceforge.net/lockhier/global-spin-lock , David.Hansen> you can see a part on hcl_spinlock. It is David.Hansen> initialized. but never used. Was this lock meant to David.Hansen> guard something? Is that thing still in the code? If David.Hansen> it isn't, here is a patch to remove hcl_spinlock.
Just FYI: stuff in the sn/ subdirectories is SGI specific. Since I can't test that, I try to avoid touching it and it would be up to SGI to incorporate your patch (I suspect they have fixed that already: the SN code hasn't been synced in a while).
--david
Quoted 10 lines · David Mosberger
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · David C. Hansen
David.Hansen> I was looking at spinlocks in the kernel and came David.Hansen> across
hcl_spinlock. If you look at this paper:
David.Hansen> http://lse.sourceforge.net/lockhier/global-spin-lock , David.Hansen> you can see a part onhcl_spinlock. It is David.Hansen> initialized. but never used. Was this lock meant to David.Hansen> guard something? Is that thing still in the code? If David.Hansen> it isn't, here is a patch to removehcl_spinlock.
Quoted 6 lines
Just FYI: stuff in the sn/ subdirectories is SGI specific. Since I can't test that, I try to avoid touching it and it would be up to SGI to incorporate your patch (I suspect they have fixed that already: the SN code hasn't been synced in a while).
--david
Nope, it's still in our tree.
We're syncing up soon, so I'll take a look at this.
John