console_loglevel is broken on ia64
Quoted 11 lines · Keith Owens
kernel/printk.chas this abomination./* Keep together for sysctl support */
intconsole_loglevel=DEFAULT_CONSOLE_LOGLEVEL; intdefault_message_loglevel=DEFAULT_MESSAGE_LOGLEVEL; intminimum_console_loglevel=MINIMUM_CONSOLE_LOGLEVEL; intdefault_console_loglevel=DEFAULT_CONSOLE_LOGLEVEL;sysctl assumes that the 4 variables occupy contiguous storage. They don't on ia64,
console_loglevelis separate from the other variables.
Quoted 7 lines
echo 6 4 1 7 >
/proc/sys/kernel/printkon ia64 overwrites
console_logleveland the next 3 integers, whatever they happen to be. On 2.4.12 it corruptsconsole_sem, other ia64 kernels will corrupt different data.Does anybody fancy a small project to clean up these variables?
I would like to give it a try. Seems like a good little project for one who is trying to learn his way around the kernel :) It will probably take me a lot longer than one of the experienced kernel hackers and would probably not be perfect on the first try, but I'm willing to invest some time in it.
Best regards,
Jesper Juhl
Quoted 10 lines · Jesper Juhl
Quoted 6 lines · Keith Owens
kernel/printk.chas this abomination.
intconsole_loglevel=DEFAULT_CONSOLE_LOGLEVEL;
intdefault_message_loglevel=DEFAULT_MESSAGE_LOGLEVEL; intminimum_console_loglevel=MINIMUM_CONSOLE_LOGLEVEL; intdefault_console_loglevel=DEFAULT_CONSOLE_LOGLEVEL; Does anybody fancy a small project to clean up these variables?I would like to give it a try. Seems like a good little project for one who is trying to learn his way around the kernel :)
Good, I was hoping for somebody who wanted to get started on the kernel. It's all yours, unless somebody else does a patch first.
Ensure that you find all references to these variables and make them all use the common #define, instead of random files declaring the variables themselves. Check all architectures as well.
Quoted 17 lines · Keith Owens
kernel/printk.chas this abomination./* Keep together for sysctl support */
intconsole_loglevel=DEFAULT_CONSOLE_LOGLEVEL; intdefault_message_loglevel=DEFAULT_MESSAGE_LOGLEVEL; intminimum_console_loglevel=MINIMUM_CONSOLE_LOGLEVEL; intdefault_console_loglevel=DEFAULT_CONSOLE_LOGLEVEL;sysctl assumes that the 4 variables occupy contiguous storage. They don't on ia64,
console_loglevelis separate from the other variables.echo 6 4 1 7 >
/proc/sys/kernel/printkon ia64 overwrites
console_logleveland the next 3 integers, whatever they happen to be. On 2.4.12 it corruptsconsole_sem, other ia64 kernels will corrupt different data.
Quoted 5 lines
Does anybody fancy a small project to clean up these variables? They need to become an integer array (say
console_printk) containing 4 elements, which is what sysctl assumes. All references to these fields have to be changed to refer to the corresponding array element. That should be as simple as
This is not the only problem related to sysctl. We still have
{KERN_REALROOTDEV, "real-root-dev", &real_root_dev, sizeof(int)
in kernel/sysctl.c, with
kdev_t real_root_dev;
in init/main.c,
extern kdev_t real_root_dev;
in drivers/block/rd.c, and
typedef unsigned short kdev_t;
in <linux/kdev_t.h>. Kaboom on big endian boxes, escpecially if the alignment rules are 2-bytes, like on m68k.
In the m68k tree we have (since ages) a patch to change real_root_dev to int and add some casts. Patch available upon request.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 18 lines · Keith Owens
kernel/printk.chas this abomination./* Keep together for sysctl support */
intconsole_loglevel=DEFAULT_CONSOLE_LOGLEVEL; intdefault_message_loglevel=DEFAULT_MESSAGE_LOGLEVEL; intminimum_console_loglevel=MINIMUM_CONSOLE_LOGLEVEL; intdefault_console_loglevel=DEFAULT_CONSOLE_LOGLEVEL;sysctl assumes that the 4 variables occupy contiguous storage. They don't on ia64,
console_loglevelis separate from the other variables.echo 6 4 1 7 >
/proc/sys/kernel/printkon ia64 overwrites
console_logleveland the next 3 integers, whatever they happen to be. On 2.4.12 it corruptsconsole_sem, other ia64 kernels will corrupt different data.
Quoted 5 lines
Does anybody fancy a small project to clean up these variables? They need to become an integer array (say
console_printk) containing 4 elements, which is what sysctl assumes. All references to these fields have to be changed to refer to the corresponding array element. That should be as simple as
Yep. I asked someone to clean this up about 3 weeks ago, and he said that he would do so, but....?
So Jesper or someone else should jump on it.
~Randy