Skip to contentSkip to conversation

#ifdef missing in linux/irq_cpustat.h

Linux-ia64 David Mosberger 1 participant 1 message Dec 26, 2001

lore
Share & tools
lore
#0 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Erich Focht

Erich> Hi David, as far as I understand the type irq_cpustat_t is Erich> not defined on IA64 therefore the line (in Erich> include/linux/irq_cpustat.h):

Erich> extern irq_cpustat_t irq_stat[]; /* defined in asm/hardirq.h Erich> */

Erich> should probably be inside an #ifndef CONFIG_IA64 block...

Technically, you're correct. But I don't think the extra declaration hurts anything. It is a platform-independent file, so I'm reluctant to add an #ifdef. I am working on getting the per-CPU data changes accepted into the main line tree, but the going is very slow (Linus is focusing on the bio stuff). Actually, if someone has a good idea of implementing fast local access to per-CPU data on x86, I'm all ears, as this would help getting the changes accepted into the main tree. I assume the Sequent/IBM folks have solved this problem for their x86 NUMA machines already?

	--david