Skip to contentSkip to conversation

show_trace_task portability

Linux-ia64 Vladimir Simonov 3 participants 3 messages Mar 21, 2003 – Apr 16, 2003

lore
Share & tools
lore
#0 lore raw

Hi!
Trying to port some patches from i386 to ia64 I've found that show_trace_task is the only portable way to show tasks' call traces(perhaps because it is called from ./kernel/sched.c:)). But its ia64 implementation can't work with running task.

Attached patch fixes this issue.

As I understand show_trace and show_stack are platform dependent or have different sense/args.

Any opinion?

Best regards
Vladimir Simonov

arch/ia64/kernel/process.c +1 -4
@@ -53,10 +53,7 @@
 void
 show_trace_task (struct task_struct *task)
 {
-	struct unw_frame_info info;
-
-	unw_init_from_blocked_task(&info, task);
-	do_show_stack(&info, 0);
+	show_stack(task);
 }
 
 void
#1 lore raw

Hi Vladimir,

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Vladimir Simonov

Vladimir> Hi! Trying to port some patches from i386 to ia64 I've Vladimir> found that show_trace_task is the only portable way to Vladimir> show tasks' call traces(perhaps because it is called from Vladimir> ./kernel/sched.c:)). But its ia64 implementation can't Vladimir> work with running task.

Vladimir> Attached patch fixes this issue.

Vladimir> As I understand show_trace and show_stack are platform Vladimir> dependent or have different sense/args.

Vladimir> Any opinion?

The patch looks fine to me. I applied it in the 2.5 tree.

Thanks,

	--david
#2 lore raw
In reply to Vladimir Simonov
Quoted 7 lines · Vladimir Simonov

Hi!
Trying to port some patches from i386 to ia64 I've found that show_trace_task is the only portable way to show tasks' call traces(perhaps because it is called from ./kernel/sched.c:)). But its ia64 implementation can't work with running task.

Attached patch fixes this issue.

I applied this for 2.4.

Bjorn