Skip to contentSkip to conversation

Missing Kconfig dependencies

PATCH In review Matthew Wilcox 2 participants 2 messages Jun 23, 2003

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Missing Kconfig dependencies

If one turns off SERIAL_8250, these items shouldn't be selectable. Also gets the indentation right in `make oldconfig'.

Index: drivers/serial/Kconfig
=================================RCS file: /var/cvs/linux-2.5/drivers/serial/Kconfig,v retrieving revision 1.13

drivers/serial/Kconfig +2 -2
diff -u -p -r1.13 Kconfig
@@ -80,14 +80,14 @@ config SERIAL_8250_CS
 config SERIAL_8250_ACPI
 	bool "8250/16550 device discovery via ACPI namespace"
 	default y if IA64
-	depends on ACPI_BUS
+	depends on ACPI_BUS && SERIAL_8250
 	---help---
 	  If you wish to enable serial port discovery via the ACPI
 	  namespace, say Y here.  If unsure, say N.
 
 config SERIAL_8250_HCDP
 	bool "8250/16550 device discovery support via EFI HCDP table"
-	depends on IA64
+	depends on IA64 && SERIAL_8250
 	---help---
 	  If you wish to make the serial console port described by the EFI
 	  HCDP table available for use as serial console or general
Signature · 3 lines
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
#1 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Matthew Wilcox

Matthew> If one turns off SERIAL_8250, these items shouldn't be selectable. Matthew> Also gets the indentation right in `make oldconfig'.

Agreed, but could you send these on directly to Russell King and lkml?

Thanks,

	--david