Skip to contentSkip to conversation

move efivars to drivers/efi

PATCH Patrick Mochel 3 participants 4 messages Aug 9, 2003 – Aug 12, 2003

lore
Share & tools
lore

Patrick Mochel

author
#0 lore raw
Quoted 10 lines

This patch against 2.6.0-test2 does several things:

1. Creates a new directory (drivers/efi) into which I propose current and future drivers that interact with EFI firmware be placed. This enables architectures that employ EFI compliant firmware to use the same drivers and avoid the maintenance hassle of multiple copies.

2. Move the current EFI variable services driver (efivars) found in arch/ia64/kernel into drivers/efi.

Note that I've added similar config options for x86 in a separate patch that also enables EFI awareness that I'll resend to the list shortly.

Thoughts? Comments?

Yes - have you considered doing a sysfs interface instead of procfs? :)

-pat

#1 lore raw
Quoted 1 line

Yes - have you considered doing a sysfs interface instead of procfs? :)

It's crossed my mind, but I haven't had much time to spend on IA-64 the past year, and that isn't likely to change soon... I think the only tool that uses /proc/efi/vars is efibootmgr, which would also need to learn of a move to /sys. Your binary-blob interface for sysfs is exactly the right thing to use for it though.

Anyone want to take a stab at switching it, or do you want to wait for me to have time?

Thanks,
Matt

Signature · 4 lines
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
#2 lore raw
In reply to Patrick Mochel
Quoted 13 lines
Quoted 1 line

Yes - have you considered doing a sysfs interface instead

of procfs? :)

It's crossed my mind, but I haven't had much time to spend on IA-64 the
past year, and that isn't likely to change soon... I think the only tool
that uses /proc/efi/vars is efibootmgr, which would also need to learn of
a move to /sys. Your binary-blob interface for sysfs is exactly the right
thing to use for it though.

Quoted 3 lines

Anyone want to take a stab at switching it, or do you want to wait for me
to have time?

Sure, I'll see if I can cook this up in the next few days and send an updated patch...

matt

#3 lore raw
In reply to Patrick Mochel
Quoted 2 lines

Sure, I'll see if I can cook this up in the next few days and send an updated patch...

Great, thanks. And to be clear, I'm happy to see efivars.c move to drivers/efi. Perhaps you can get that move done first, then do the conversion to sysfs.

Thanks,
Matt

Signature · 4 lines
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com