Skip to contentSkip to conversation

patch suggestion (was Re: [PATCH] move find_memory())

DISCUSSION David Mosberger 2 participants 3 messages Oct 8, 2003 – Oct 9, 2003

lore
Share & tools
lore
#0 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · On Wed, 8 Oct 2003 16:20:22 -0700, [email protected] (Jesse Barnes) said:

Jesse> Now that the ACPI table parsing stuff has been fixed we can Jesse> move find_memory() back where it belongs--after the SRAT Jesse> table has been parsed.

Quick suggestion: when you submit patches for 2.6.0, it would be a good idea to explain what kind of bug this fixes, so that Linus can see easily that it's a bug fix.

(Jess, don't worry about this particular patch, I'll update the changelog myself.)

	--david
#1 lore raw
Quoted 9 lines · David Mosberger
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · On Wed, 8 Oct 2003 16:20:22 -0700, [email protected] (Jesse Barnes) said:

Jesse> Now that the ACPI table parsing stuff has been fixed we can Jesse> move find_memory() back where it belongs--after the SRAT Jesse> table has been parsed.

Quick suggestion: when you submit patches for 2.6.0, it would be a good idea to explain what kind of bug this fixes, so that Linus can see easily that it's a bug fix.

Oh sorry. I'll try to be more descriptive of the fix in the future.

Quoted 2 lines

(Jess, don't worry about this particular patch, I'll update the changelog myself.)

Ok, thanks.

Jesse

#2 lore raw
In reply to David Mosberger
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line · On Wed, 8 Oct 2003 17:00:38 -0700, [email protected] (Jesse Barnes) said:

(Jess, don't worry about this particular patch, I'll update the changelog myself.)

Jesse> Ok, thanks.

And there, I did it again, mistyping your name! Sorry about that! (I swear, it's the keyboards that's eating the lettr! ;-)

	--david