Missing exported symbol
PATCH 1/1 Missing exported symbol
This fixes some missing symbol exports.
Andreas.
arch/ia64/kernel/ia64_ksyms.c +7 -0
@@ -41,6 +41,7 @@EXPORT_SYMBOL (csum_tcpudp_magic);EXPORT_SYMBOL (ip_compute_csum);EXPORT_SYMBOL (ip_fast_csum); +EXPORT_SYMBOL (csum_partial);#include <asm/io.h> EXPORT_SYMBOL (__ia64_memcpy_fromio);
@@ -61,6 +62,8 @@#include <asm/pgtable.h> EXPORT_SYMBOL (vmalloc_end);EXPORT_SYMBOL (ia64_pfn_valid); +EXPORT_SYMBOL (max_low_pfn); +EXPORT_SYMBOL (vmem_map);#endif #include <asm/processor.h>
@@ -213,3 +216,7 @@#include <linux/pm.h> EXPORT_SYMBOL (pm_idle); + +#include <linux/reboot.h> +EXPORT_SYMBOL (machine_power_off); +EXPORT_SYMBOL (machine_restart);
Signature · 4 lines
Andreas Schwab, SuSE Labs, [email protected] SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."
Quoted 1 line · Andreas Schwab
+EXPORT_SYMBOL(csum_partial);
ok.
arch/ia64/kernel/ia64_ksyms.c line 66
Quoted 6 lines
arch/ia64/kernel/ia64_ksyms.c +2
-0@@ -61,6 +62,8 @@#include <asm/pgtable.h> EXPORT_SYMBOL (vmalloc_end);EXPORT_SYMBOL (ia64_pfn_valid); +EXPORT_SYMBOL (max_low_pfn); +EXPORT_SYMBOL (vmem_map);
what needs these?
arch/ia64/kernel/ia64_ksyms.c line 222
Quoted 3 lines
arch/ia64/kernel/ia64_ksyms.c +3
-0+#include <linux/reboot.h> +EXPORT_SYMBOL (machine_power_off); +EXPORT_SYMBOL (machine_restart);
dito. If these are needed the export should probably go into architecture-independent code.
Quoted 5 lines · Christoph Hellwig
Quoted 1 line · Andreas Schwab
+EXPORT_SYMBOL(csum_partial);
ok.
Quoted 8 lines
arch/ia64/kernel/ia64_ksyms.c line 66
Quoted 6 lines
arch/ia64/kernel/ia64_ksyms.c +2
-0@@ -61,6 +62,8 @@#include <asm/pgtable.h> EXPORT_SYMBOL (vmalloc_end);EXPORT_SYMBOL (ia64_pfn_valid); +EXPORT_SYMBOL (max_low_pfn); +EXPORT_SYMBOL (vmem_map);what needs these?
Anything that uses virt_addr_valid (net/scpt).
Quoted 5 lines
arch/ia64/kernel/ia64_ksyms.c line 222
Quoted 3 lines
arch/ia64/kernel/ia64_ksyms.c +3
-0+#include <linux/reboot.h> +EXPORT_SYMBOL (machine_power_off); +EXPORT_SYMBOL (machine_restart);dito.
drivers/char/watchdog/pcwd
Quoted 2 lines
If these are needed the export should probably go into
architecture-independent code.
Those are architecture dependent functions, implemented under arch.
Andreas.
Signature · 4 lines
Andreas Schwab, SuSE Labs, [email protected] SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."
Quoted 16 lines · Andreas Schwab
Quoted 5 lines · Christoph Hellwig
Quoted 1 line · Andreas Schwab
+EXPORT_SYMBOL(csum_partial);
ok.
Quoted 8 lines
arch/ia64/kernel/ia64_ksyms.c line 66
Quoted 6 lines
arch/ia64/kernel/ia64_ksyms.c +2
-0@@ -61,6 +62,8 @@#include <asm/pgtable.h> EXPORT_SYMBOL (vmalloc_end);EXPORT_SYMBOL (ia64_pfn_valid); +EXPORT_SYMBOL (max_low_pfn); +EXPORT_SYMBOL (vmem_map);what needs these?
Quoted 1 line
Anything that uses
virt_addr_valid(net/scpt).
Yep, my fault. Sorry I forgot to export them. I've only tested a few modules so far so I didn't catch the missing symbols.
That said, shouldn't these symols be exported in the files that contain them?
Jesse
Quoted 2 lines · [email protected] (Jesse Barnes) writes:
That said, shouldn't these symols be exported in the files that contain them?
Yes, that's true. We should eventually remove all exports from ia64_ksyms.c except those that are implemented in assembler. But I think we should postpone that after test8 since Linus only wants bug fixes at this time.
Andreas.
Signature · 4 lines
Andreas Schwab, SuSE Labs, [email protected] SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Andreas Schwab
Andreas> +EXPORT_SYMBOL(machine_power_off); Andreas> +EXPORT_SYMBOL(machine_restart);
These are supposed to be exported where they get defined (actually, true for everything in ia64_ksyms.c). I had a fix for this, but due to operator-error it got lost. I'll re-fix it.
--david
Quoted 1 line · Andreas Schwab
+EXPORT_SYMBOL(csum_partial);
yeah - the netfilter code needs this.
2.6.0-test7 plus csum_partial is running on my external box now. I've uploaded tarball of vmlinuz+config+modules to
ftp://gsyprf10.external.hp.com/kernels/ia64/2.6.0-test7.tgz
setserial crashes the box though. bjorn is looking into it. (2.6.0-test5 returns EBUSY to setserial)
I've "apt-get remove setserial" since I don't need setserial.
hth,
grant