Skip to contentSkip to conversation

Fix compiler warning in arch/ia64/kernel/irq_lsapic.c

PATCH Jack Steiner 3 participants 4 messages Nov 5, 2003 – Nov 7, 2003

lore
Share & tools
lore
#0 lore raw

Not sure if you are taking fixes like this right now, but...

This fixes a compoiler warning that occurs when NR_CPUS is > 64.

arch/ia64/kernel/irq_lsapic.c +1 -1
@@ -34,5 +34,5 @@
 	.disable =	lsapic_noop,
 	.ack =		lsapic_noop,
 	.end =		lsapic_noop,
-	.set_affinity =	(void (*)(unsigned int, unsigned long)) lsapic_noop
+	.set_affinity =	(void (*)(unsigned int, cpumask_t)) lsapic_noop
 };
Signature · 4 lines
Thanks

Jack Steiner ([email protected])          651-683-5302
Principal Engineer                      SGI - Silicon Graphics, Inc.
#1 lore raw
Quoted 3 lines · Jack Steiner

Not sure if you are taking fixes like this right now, but...

This fixes a compoiler warning that occurs when NR_CPUS is > 64.

I think the right fix would be to just not set this value, IIRC set_affinity is optional.

--
Christoph Hellwig <[email protected]> - Freelance Hacker
Contact me for driver hacking and kernel development consulting

#2 lore raw
In reply to Jack Steiner
Quoted 7 lines · Christoph Hellwig
Quoted 3 lines · Jack Steiner

Not sure if you are taking fixes like this right now, but...

This fixes a compoiler warning that occurs when NR_CPUS is > 64.

I think the right fix would be to just not set this value, IIRC set_affinity is optional.

Good point. The field looks like it is optional. Should I update the patch???

Quoted 4 lines

--
Christoph Hellwig <[email protected]> - Freelance Hacker
Contact me for driver hacking and kernel development consulting

Signature · 4 lines
Thanks

Jack Steiner ([email protected])          651-683-5302
Principal Engineer                      SGI - Silicon Graphics, Inc.
#3 lore raw
In reply to Jack Steiner
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Jack Steiner
Quoted 7 lines · Christoph Hellwig
Quoted 7 lines · Jack Steiner
Quoted 3 lines

Not sure if you are taking fixes like this right now, but...

This fixes a compoiler warning that occurs when NR_CPUS is > 64.

I think the right fix would be to just not set this value, IIRC set_affinity is optional.

Jack> Good point. The field looks like it is optional. Should I update Jack> the patch???

Yes, and please resend it after 2.6.0 is out, as this hardly qualifies as a critical bug-fix.

	--david