ad1848 infinite loop fix

I think I found the problem which causes the infinite loop when the activation fails:

@@ -3058,7 +3058,7 @@
        else
                printk(KERN_INFO "ad1848: Failed to initialize %s\n", 

devname);

- return 0;
+ return -ENODEV;
}

static int __init ad1848_isapnp_probe(struct address_info *hw_config)

This will break the isapnp probe in ad1848, the problem could possibly be elsewhere. You have to be a bit careful when changing the return values of functions in some of the older OSS code.

Zwane

function.linuxpower.ca

I just looked into some of the other drivers and they also use "return 0" in case of failure. So you are right, this is not the proper way to fix this! But this means that there are some generic problems with the loading of kernel modules!?

If I use "return -ENODEV" the module will do the init stuff, fail, and thats it. With the original "return 0" the module will do the init stuff in an infinite loop. I do not think this is a problem inside the module since it looks like the main init function gets called over and over again (blocking the kernel and hence freezing the system).

Gerald