Skip to contentSkip to conversation

Input: Disable Intertouch for Lenovo T14 and P14s AMD G1

PATCH Applied Mark Pearson 2 participants 4 messages Sep 20, 2022 – Oct 14, 2022 1 message not in the archive

Subsystems (2)
HID Input drivers
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected],

Mark Pearson

author
#1 lore raw

PATCH 1/1 Input: Disable Intertouch for Lenovo T14 and P14s AMD G1

Since intertouch was enabled for the T14 and P14s AMD G1 laptops there have been a number of reports of touchpads not working well.

Debugging this with Synaptics they noted that intertouch should not be enabled as SMBUS host notify is not available on these laptops.

Reverting the previous commit (e4ce4d3a939d97bea045eafa13ad1195695f91ce) to restore functionality back to what it was.

Note - we are working with Synaptics to see if there is a better solution, but nothing is confirmed as yet.

Signed-off-by Mark Pearson <[email protected]>
---
 drivers/input/mouse/synaptics.c | 1 -
 1 file changed, 1 deletion(-)
drivers/input/mouse/synaptics.c +0 -1
index 434d48ae4b12..ffad142801b3 100644
@@ -186,7 +186,6 @@ static const char * const smbus_pnp_ids[] = {
 	"LEN2044", /* L470  */
 	"LEN2054", /* E480 */
 	"LEN2055", /* E580 */
-	"LEN2064", /* T14 Gen 1 AMD / P14s Gen 1 AMD */
 	"LEN2068", /* T14 Gen 1 */
 	"SYN3052", /* HP EliteBook 840 G4 */
 	"SYN3221", /* HP 15-ay000 */
Signature · 1 line
2.37.2
maintainer Applied
#2 lore raw
Quoted 6 lines · Mark Pearson

Since intertouch was enabled for the T14 and P14s AMD G1 laptops there have been a number of reports of touchpads not working well.

Debugging this with Synaptics they noted that intertouch should not be enabled as SMBUS host notify is not available on these laptops.

Quoted 7 lines

Reverting the previous commit (e4ce4d3a939d97bea045eafa13ad1195695f91ce) to restore functionality back to what it was.

Note - we are working with Synaptics to see if there is a better solution, but nothing is confirmed as yet.

Signed-off-by Mark Pearson <[email protected]>

Applied, thank you.

Signature · 1 line
Dmitry
author
#3 lore raw
In reply to Mark Pearson

Resending as I hadn't seen any reviews. I think this didn't make it on the list as I can't see it on the archives :(

Please let me know if there are any concerns.

Thanks
Mark

Quoted 29 lines · Mark Pearson

Since intertouch was enabled for the T14 and P14s AMD G1 laptops there have been a number of reports of touchpads not working well.

Debugging this with Synaptics they noted that intertouch should not be enabled as SMBUS host notify is not available on these laptops.

Reverting the previous commit (e4ce4d3a939d97bea045eafa13ad1195695f91ce) to restore functionality back to what it was.

Note - we are working with Synaptics to see if there is a better solution, but nothing is confirmed as yet.

Signed-off-by Mark Pearson <[email protected]>
---
 drivers/input/mouse/synaptics.c | 1 -
 1 file changed, 1 deletion(-)
drivers/input/mouse/synaptics.c +0 -1
index 434d48ae4b12..ffad142801b3 100644
@@ -186,7 +186,6 @@ static const char * const smbus_pnp_ids[] = {
 	"LEN2044", /* L470  */
 	"LEN2054", /* E480 */
 	"LEN2055", /* E580 */
-	"LEN2064", /* T14 Gen 1 AMD / P14s Gen 1 AMD */
 	"LEN2068", /* T14 Gen 1 */
 	"SYN3052", /* HP EliteBook 840 G4 */
 	"SYN3221", /* HP 15-ay000 */
maintainer
#4 lore raw

Hi Mark,

Quoted 2 lines · Mark Pearson

Resending as I hadn't seen any reviews. I think this didn't make it on the list as I can't see it on the archives :(

I believe this is commit 2fd003ee8ade6b7f2777becc6f9917d7c313784f and it should be part of 6.0 release.

Thanks.

Signature · 1 line
Dmitry