Skip to contentSkip to conversation

[2.6][2/5]Support for HPET based timer

PATCH Andi Kleen 1 participant 1 message Aug 19, 2003 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Andi Kleen

author
#1 lore raw
Quoted 5 lines · Venkatesh

/*
+ * Default initialization for 8254 timers. If we use other timers like HPET,
+ * we override this later
+ */
+void (*wait_timer_tick)(void) = wait_8254_wraparound;

It would be much cleaner to just poll the generic monotonic time source here, not add more special cases.

arch/i386/kernel/time_hpet.c

Quoted 3 lines

diff -purN linux-2.6.0-test1/arch/i386/kernel/time_hpet.c linux-2.6.0-test1-hpet/arch/i386/kernel/time_hpet.c

arch/i386/kernel/time_hpet.c +0 -0

000000 -0700

Shouldn't that be in arch/i386/kernel/timers/hpet.c ?

Also I suspect it should be made an generic timer object there with a timer_ops structure. If some hook for that is missing it could be added to timer_ops and timers/timer.c

When there is already a generic framework to add new timers it would be a shame not to use it.

-Andi