Request 339055 commented by jengelh (submit devel:tools/coccinelle)
Quoted 5 lines · Jan Engelhardt
Visit https://build.opensuse.org/request/show/339055
Jan Engelhardt wrote in request 339055:
Why is this even needed? Are changes planned to the implicitly-installed packages in prjconf?
Not sure what you mean. The coccinelel build as of today uses the concept of bundles and that requires tar to unpack things. Other than this in the future I don't expect ./configure to be redistributed but rather ./autogen will be required as with other software projects to keep history clean, and since autotools is prevalent on build systems these days anyway.
Luis
Quoted 9 lines · Luis R. Rodriguez
Quoted 5 lines · Jan Engelhardt
Visit https://build.opensuse.org/request/show/339055
Jan Engelhardt wrote in request 339055:
Why is this even needed? Are changes planned to the implicitly-installed packages in prjconf?
Not sure what you mean. The coccinelel build as of today uses the concept of bundles and that requires tar to unpack things.
tar is in the list of packages installed by default on OBS, just like gcc. And we don't have BuildRequires: gcc everywhere for that reason.
Quoted 7 lines · Jan Engelhardt
Quoted 5 lines · Luis R. Rodriguez
Quoted 4 lines · Jan Engelhardt
Visit https://build.opensuse.org/request/show/339055
Jan Engelhardt wrote in request 339055:
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Why is this even needed? Are changes planned to the implicitly-installed packages in prjconf?
Not sure what you mean. The coccinelel build as of today uses the concept of bundles and that requires tar to unpack things.
tar is in the list of packages installed by default on OBS, just like gcc. And we don't have BuildRequires: gcc everywhere for that reason.
Great, thanks. How about the others?
Luis
Quoted 10 lines · Luis R. Rodriguez
Quoted 9 lines · Jan Engelhardt
Quoted 7 lines · Luis R. Rodriguez
Quoted 5 lines · Jan Engelhardt
Visit https://build.opensuse.org/request/show/339055
Jan Engelhardt wrote in request 339055:
Why is this even needed? Are changes planned to the implicitly-installed packages in prjconf?
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Not sure what you mean. The coccinelel build as of today uses the concept of bundles and that requires tar to unpack things.
tar is in the list of packages installed by default on OBS, just like gcc. And we don't have BuildRequires: gcc everywhere for that reason.
Great, thanks. How about the others?
Since coccinelle.spec does not invoke autoreconf or any of the developer-side regenration tools, we do not need autoconf/automake/libtool in the .spec at all.
Quoted 1 line
Since coccinelle.spec does not invoke autoreconf
How does the script "https://github.com/coccinelle/coccinelle/blob/a46bef70162d17cec6b0fc6101d737989f735ee4/autogen" fit to your view?
Quoted 1 line
or any of the developer-side regenration tools,
Do you see any more software evolution there?
Quoted 1 line
we do not need autoconf/automake/libtool in the .spec at all.
Can it occasionally help to make more software dependencies explicit also in the package specification?
Regards,
Markus
Quoted 5 lines · SF Markus Elfring
Quoted 2 lines
Since coccinelle.spec does not invoke autoreconf
How does the script "https://github.com/coccinelle/coccinelle/blob/a46bef70162d17cec6b0fc6101d737989f735ee4/autogen" fit to your view?
1. Running aclocal; autoconf is not enough. I spot a Makefile.am in the source tree, so you more or less need autoreconf -fi instead in the "autogen" script.
2. My point was that autogen / aclocal / autoconf / etc.
only needs to be run if there is no "configure" script present. Because there is a configure script in the released tarballs (at least there was so far), there is no need for coccinelle.spec to run autogen. And if autogen/aclocal/autoconf/etc. is not run, we do not need to BuildRequire it.
Quoted 3 lines
1. Running
aclocal; autoconfis not enough. I spot a Makefile.am in the source tree, so you more or less needautoreconf -fiinstead in the "autogen" script.
Are you interested in achieving progress on a topic like 'Collateral evolution around "Automake"'?
https://github.com/coccinelle/coccinelle/issues/41
Quoted 2 lines
2. My point was that autogen / aclocal / autoconf / etc. only needs to be run if there is no "configure" script present.
That is usual.
Quoted 2 lines
Because there is a configure script in the released tarballs (at least there was so far),
This might look convenient.
Quoted 1 line
there is no need for coccinelle.spec to run autogen.
Have you got any concerns for the dependency on such a pregenerated script together with the discussed distribution package?
Regards,
Markus
Quoted 7 lines · SF Markus Elfring
Quoted 3 lines
1. Running
aclocal; autoconfis not enough. I spot a Makefile.am in the source tree, so you more or less needautoreconf -fiinstead in the "autogen" script.Are you interested in achieving progress on a topic like 'Collateral evolution around "Automake"'?
https://github.com/coccinelle/coccinelle/issues/41
Sort of.
Quoted 4 lines
Quoted 1 line
there is no need for coccinelle.spec to run autogen.
Have you got any concerns for the dependency on such a pregenerated script together with the discussed distribution package?
If a tarball ships configure, good for us. If it does not, well, then that means it will take a few seconds more to build and extra dependencies to be installed. For a build system, all of that is a no-brainer, but for "users", it can get annoying when they have to install, for example, half of the gnome-devel stack just to satisfy an m4 macro in case they have to rerun the configure generator.
Quoted 5 lines
Quoted 3 lines
Are you interested in achieving progress on a topic like 'Collateral evolution around "Automake"'?
https://github.com/coccinelle/coccinelle/issues/41Sort of.
I am curious if you would like to contribute a bit more help for the affected design details.
Quoted 6 lines
If a tarball ships configure, good for us. If it does not, well, then that means it will take a few seconds more to build and extra dependencies to be installed. For a build system, all of that is a no-brainer, but for "users", it can get annoying when they have to install, for example, half of the gnome-devel stack just to satisfy an m4 macro in case they have to rerun the configure generator.
Do you care which software versions were involved in the generation of the preferred configuration script?
Regards,
Markus
Quoted 11 lines · Jan Engelhardt
Quoted 5 lines · SF Markus Elfring
Quoted 2 lines
Since coccinelle.spec does not invoke autoreconf
How does the script "https://github.com/coccinelle/coccinelle/blob/a46bef70162d17cec6b0fc6101d737989f735ee4/autogen" fit to your view?
1. Running
aclocal; autoconfis not enough. I spot a Makefile.am in the source tree, so you more or less needautoreconf -fiinstead in the "autogen" script.
Then autogen should have this as well, how about:
autogen +1 -2
@@ -4,5 +4,4 @@ if [ "$1" = "--ignore_localversion" ]; then else unset MAKE_COCCI_RELEASE fi -aclocal -I setup -autoconf -Wall +autoreconf -f -i --warnings=all
Quoted 6 lines
2. My point was that autogen / aclocal / autoconf / etc.
only needs to be run if there is no "configure" script present. Because there is a configure script in the released tarballs (at least there was so far), there is no need for coccinelle.spec to run autogen. And if autogen/aclocal/autoconf/etc. is not run, we do not need to BuildRequire it.
The latest tarballs do not require it but the next releases will, so configure will not be carried, so this was more of a heads up note / pro-active patch.
Luis
Hi,
Sorry for the delayed response.
Luis R. Rodriguez (2015/10/22 15:18 +0200):
Quoted 12 lines · Jan Engelhardt
Quoted 11 lines · SF Markus Elfring
Quoted 5 lines
Quoted 2 lines
Since coccinelle.spec does not invoke autoreconf
How does the script "https://github.com/coccinelle/coccinelle/blob/a46bef70162d17cec6b0fc6101d737989f735ee4/autogen" fit to your view?
1. Running
aclocal; autoconfis not enough. I spot a Makefile.am in the source tree, so you more or less needautoreconf -fiinstead in the "autogen" script.
Well, the Makefile.am is indeed present but not actually used so are you really sure the change you suggest is required?
Is there any specific problem you are trying to solve with the current code?
Quoted 10 lines
Quoted 6 lines
2. My point was that autogen / aclocal / autoconf / etc.
only needs to be run if there is no "configure" script present. Because there is a configure script in the released tarballs (at least there was so far), there is no need for coccinelle.spec to run autogen. And if autogen/aclocal/autoconf/etc. is not run, we do not need to BuildRequire it.The latest tarballs do not require it but the next releases will, so configure will not be carried, so this was more of a heads up note / pro-active patch.
Well, so far my idea was to not provide configure in a public coccinelle repository but to provide it in tarballs, following an approach which I believe is common to many open-source projects, i.e. not version-controlling any generated file but still distribute them in tarballs.
S?bastien.
Quoted 18 lines · S?bastien Hinderer
Hi,
Sorry for the delayed response.
Luis R. Rodriguez (2015/10/22 15:18 +0200):
Quoted 12 lines · Jan Engelhardt
Quoted 11 lines · SF Markus Elfring
Quoted 5 lines
Quoted 2 lines
Since coccinelle.spec does not invoke autoreconf
How does the script "https://github.com/coccinelle/coccinelle/blob/a46bef70162d17cec6b0fc6101d737989f735ee4/autogen" fit to your view?
1. Running
aclocal; autoconfis not enough. I spot a Makefile.am in the source tree, so you more or less needautoreconf -fiinstead in the "autogen" script.
Quoted 5 lines
Well, the Makefile.am is indeed present but not actually used so are you really sure the change you suggest is required?
Is there any specific problem you are trying to solve with the current code?
Note: this was addressed to Markus.
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
2. My point was that autogen / aclocal / autoconf / etc.
only needs to be run if there is no "configure" script present. Because there is a configure script in the released tarballs (at least there was so far), there is no need for coccinelle.spec to run autogen. And if autogen/aclocal/autoconf/etc. is not run, we do not need to BuildRequire it.
Quoted 8 lines
Quoted 3 lines
The latest tarballs do not require it but the next releases will, so configure will not be carried, so this was more of a heads up note / pro-active patch.
Well, so far my idea was to not provide configure in a public coccinelle repository but to provide it in tarballs, following an approach which I believe is common to many open-source projects, i.e. not version-controlling any generated file but still distribute them in tarballs.
Sounds good.
Luis